From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4E43745C76; Mon, 4 Nov 2024 12:14:17 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 23A8642799; Mon, 4 Nov 2024 12:11:22 +0100 (CET) Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by mails.dpdk.org (Postfix) with ESMTP id 89C6740E27 for ; Mon, 4 Nov 2024 12:10:45 +0100 (CET) Received: from mail.maildlp.com (unknown [172.19.88.105]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4Xhpbr3W7Zzfdh5; Mon, 4 Nov 2024 19:08:08 +0800 (CST) Received: from dggpeml500011.china.huawei.com (unknown [7.185.36.84]) by mail.maildlp.com (Postfix) with ESMTPS id 6EA151402C8; Mon, 4 Nov 2024 19:10:44 +0800 (CST) Received: from localhost.huawei.com (10.50.165.33) by dggpeml500011.china.huawei.com (7.185.36.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Mon, 4 Nov 2024 19:10:44 +0800 From: Dengdui Huang To: CC: , , , , , , , , , , Subject: [PATCH v5 35/52] net/ice: replace strerror with reentrant version Date: Mon, 4 Nov 2024 19:10:20 +0800 Message-ID: <20241104111037.3632161-36-huangdengdui@huawei.com> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20241104111037.3632161-1-huangdengdui@huawei.com> References: <20231114082539.1858594-1-huangdengdui@huawei.com> <20241104111037.3632161-1-huangdengdui@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-Originating-IP: [10.50.165.33] X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To dggpeml500011.china.huawei.com (7.185.36.84) X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org The function strerror() is insecure in a multi-thread environment. This patch uses strerror_r() to replace it. Signed-off-by: Dengdui Huang Acked-by: Chengwen Feng Acked-by: Morten Brørup Acked-by: Huisong Li --- drivers/net/ice/ice_testpmd.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/drivers/net/ice/ice_testpmd.c b/drivers/net/ice/ice_testpmd.c index 98c02d68c6..03ec3e0adc 100644 --- a/drivers/net/ice/ice_testpmd.c +++ b/drivers/net/ice/ice_testpmd.c @@ -38,6 +38,7 @@ cmd_ddp_dump_parsed(void *parsed_result, __rte_unused void *data) { struct cmd_ddp_dump_result *res = parsed_result; + char errmsg[RTE_STRERR_BUFSIZE]; uint8_t *buff; uint32_t size; int ret = -ENOTSUP; @@ -59,9 +60,11 @@ cmd_ddp_dump_parsed(void *parsed_result, "dump DDP runtime configure.\n"); break; default: + if (strerror_r(-ret, errmsg, sizeof(errmsg)) != 0) + snprintf(errmsg, sizeof(errmsg), "Unknown error %d", -ret); fprintf(stderr, "Failed to dump DDP runtime configure," - " error: (%s)\n", strerror(-ret)); + " error: (%s)\n", errmsg); } } free(buff); @@ -105,6 +108,7 @@ cmd_ddp_dump_switch_parsed(void *parsed_result, __rte_unused void *data) { struct cmd_ddp_dump_switch_result *res = parsed_result; + char errmsg[RTE_STRERR_BUFSIZE]; uint8_t *buff; uint32_t size; int ret = -ENOTSUP; @@ -126,9 +130,11 @@ cmd_ddp_dump_switch_parsed(void *parsed_result, "dump DDP switch runtime configure.\n"); break; default: + if (strerror_r(-ret, errmsg, sizeof(errmsg)) != 0) + snprintf(errmsg, sizeof(errmsg), "Unknown error %d", -ret); fprintf(stderr, "Failed to dump DDP switch runtime configure," - " error: (%s)\n", strerror(-ret)); + " error: (%s)\n", rte_strerror(-ret)); } } free(buff); -- 2.33.0