From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2973D45C76; Mon, 4 Nov 2024 12:16:08 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 18A4C427E5; Mon, 4 Nov 2024 12:11:41 +0100 (CET) Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by mails.dpdk.org (Postfix) with ESMTP id DCB2A40E44 for ; Mon, 4 Nov 2024 12:10:46 +0100 (CET) Received: from mail.maildlp.com (unknown [172.19.163.252]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4XhpcD0kPQz10PZB; Mon, 4 Nov 2024 19:08:28 +0800 (CST) Received: from dggpeml500011.china.huawei.com (unknown [7.185.36.84]) by mail.maildlp.com (Postfix) with ESMTPS id C0CB31800A7; Mon, 4 Nov 2024 19:10:45 +0800 (CST) Received: from localhost.huawei.com (10.50.165.33) by dggpeml500011.china.huawei.com (7.185.36.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Mon, 4 Nov 2024 19:10:45 +0800 From: Dengdui Huang To: CC: , , , , , , , , , , Subject: [PATCH v5 43/52] net/qede: replace strerror with reentrant version Date: Mon, 4 Nov 2024 19:10:28 +0800 Message-ID: <20241104111037.3632161-44-huangdengdui@huawei.com> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20241104111037.3632161-1-huangdengdui@huawei.com> References: <20231114082539.1858594-1-huangdengdui@huawei.com> <20241104111037.3632161-1-huangdengdui@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-Originating-IP: [10.50.165.33] X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To dggpeml500011.china.huawei.com (7.185.36.84) X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org The function strerror() is insecure in a multi-thread environment. This patch uses strerror_r() to replace it. Signed-off-by: Dengdui Huang Acked-by: Chengwen Feng Acked-by: Morten Brørup Acked-by: Huisong Li --- drivers/net/qede/qede_regs.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/drivers/net/qede/qede_regs.c b/drivers/net/qede/qede_regs.c index d2ea1c9108..ca8efd796e 100644 --- a/drivers/net/qede/qede_regs.c +++ b/drivers/net/qede/qede_regs.c @@ -213,6 +213,7 @@ qede_set_fw_dump_file_name(struct qede_dev *qdev) static int qede_write_fwdump(const char *dump_file, void *dump, size_t len) { + char errmsg[RTE_STRERR_BUFSIZE]; int err = 0; FILE *f; size_t bytes; @@ -220,8 +221,10 @@ qede_write_fwdump(const char *dump_file, void *dump, size_t len) f = fopen(dump_file, "wb+"); if (!f) { + if (strerror_r(errno, errmsg, sizeof(errmsg)) != 0) + snprintf(errmsg, sizeof(errmsg), "Unknown error %d", errno); fprintf(stderr, "Can't open file %s: %s\n", - dump_file, strerror(errno)); + dump_file, errmsg); return 1; } bytes = fwrite(dump, 1, len, f); @@ -233,8 +236,10 @@ qede_write_fwdump(const char *dump_file, void *dump, size_t len) } if (fclose(f)) { + if (strerror_r(errno, errmsg, sizeof(errmsg)) != 0) + snprintf(errmsg, sizeof(errmsg), "Unknown error %d", errno); fprintf(stderr, "Can't close file %s: %s\n", - dump_file, strerror(errno)); + dump_file, errmsg); err = 1; } -- 2.33.0