From: Soumyadeep Hore <soumyadeep.hore@intel.com>
To: bruce.richardson@intel.com, aman.deep.singh@intel.com
Cc: dev@dpdk.org, shaiq.wani@intel.com, stable@dpdk.org
Subject: [PATCH v4] net/ice: fix incorrect reading of PHY timestamp
Date: Tue, 5 Nov 2024 10:14:19 +0000 [thread overview]
Message-ID: <20241105101419.888975-1-soumyadeep.hore@intel.com> (raw)
In-Reply-To: <20241104103112.885071-1-soumyadeep.hore@intel.com>
In ICE PMD, previously the ready bitmap checking before reading
PHY timestamp was not present. This caused incorrect Tx
timestamping.
The ready bitmap checking is enabled and PHY timestamp is read once
the ready bitmap gives positive value.
Fixes: 881169950d80 ("net/ice/base: implement initial PTP support for E830")
Cc: stable@dpdk.org
Signed-off-by: Soumyadeep Hore <soumyadeep.hore@intel.com>
---
v4:
- Addressed Bruce comments for do while loop introduction
---
v3:
- Decreased the end time delay from 1 second to 10 microseconds
---
v2:
- Addressed Bruce's comments
---
drivers/net/ice/ice_ethdev.c | 19 ++++++++++++++++++-
1 file changed, 18 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c
index 70298ac330..7e2c6107ff 100644
--- a/drivers/net/ice/ice_ethdev.c
+++ b/drivers/net/ice/ice_ethdev.c
@@ -6597,10 +6597,27 @@ ice_timesync_read_tx_timestamp(struct rte_eth_dev *dev,
struct ice_hw *hw = ICE_DEV_PRIVATE_TO_HW(dev->data->dev_private);
struct ice_adapter *ad =
ICE_DEV_PRIVATE_TO_ADAPTER(dev->data->dev_private);
- uint64_t ts_ns, tstamp;
+ uint64_t ts_ns, tstamp, tstamp_ready = 0;
+ uint64_t end_time;
const uint64_t mask = 0xFFFFFFFF;
int ret;
+ /* Set the end time with a delay of 10 microseconds */
+ end_time = rte_get_timer_cycles() + (rte_get_timer_hz() / 100000);
+
+ do {
+ ret = ice_get_phy_tx_tstamp_ready(hw, ad->ptp_tx_block, &tstamp_ready);
+ if (ret) {
+ PMD_DRV_LOG(ERR, "Failed to get phy ready for timestamp");
+ return -1;
+ }
+
+ if (rte_get_timer_cycles() > end_time) {
+ PMD_DRV_LOG(ERR, "Timeout to get phy ready for timestamp");
+ return -1;
+ }
+ } while ((tstamp_ready & BIT_ULL(0)) == 0);
+
ret = ice_read_phy_tstamp(hw, ad->ptp_tx_block, ad->ptp_tx_index, &tstamp);
if (ret || tstamp == 0) {
PMD_DRV_LOG(ERR, "Failed to read phy timestamp");
--
2.43.0
next prev parent reply other threads:[~2024-11-05 11:19 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-25 10:26 [PATCH v1] " Soumyadeep Hore
2024-10-29 10:37 ` Singh, Aman Deep
2024-10-29 17:09 ` Bruce Richardson
2024-10-30 2:16 ` [PATCH v2] " Soumyadeep Hore
2024-10-30 15:31 ` Bruce Richardson
2024-11-04 10:31 ` [PATCH v3] " Soumyadeep Hore
2024-11-04 12:16 ` Bruce Richardson
2024-11-05 10:14 ` Soumyadeep Hore [this message]
2024-11-05 11:33 ` [PATCH v4] " Bruce Richardson
2024-11-06 8:22 ` [PATCH v5] " Soumyadeep Hore
2024-11-06 10:59 ` Bruce Richardson
2024-11-06 11:36 ` Bruce Richardson
-- strict thread matches above, loose matches on Subject: below --
2024-10-25 5:14 [PATCH v2] " Soumyadeep Hore
2024-10-25 7:50 ` [PATCH v4] " Soumyadeep Hore
2024-10-25 9:02 ` Bruce Richardson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241105101419.888975-1-soumyadeep.hore@intel.com \
--to=soumyadeep.hore@intel.com \
--cc=aman.deep.singh@intel.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=shaiq.wani@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).