From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 099D445C88; Tue, 5 Nov 2024 12:27:31 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D2698402B3; Tue, 5 Nov 2024 12:27:30 +0100 (CET) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.18]) by mails.dpdk.org (Postfix) with ESMTP id 65B2D40151; Tue, 5 Nov 2024 12:27:28 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1730806049; x=1762342049; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=sNNPOgj9tCcZul0OSd0ZNmEOuKsSs/FZfHRpUz1+mpM=; b=jRZd/cfuajHdICJRdKwi561GNCwLtEXKnUgF6Z08J7glIUV8QvRHJV0N rgLBW5n7IjVu08oI1GRKLDi44yPoHEk04ZifF08tMXPZOm86UwNjqAua/ FcQH43RkwTXDpC3PnwghwALlZwMeCgJ0/So7ULjre7T0/NHW6Wsc71MR7 EpD7fDhpBUyrHS7pe/oWdVP776t4+YtFiJR9VekUYIswSUBHoZMy7rQ4z sef4GqVkAN3H+8Q8UiQ3seb7D7k16WroWppmKcILWvgfBTJAoeTcvd+U2 siNyJsk5NfeXSXv59Qdc3+RjzWpPZ1Pfd7V38GWyVV6K/c+njlyGe2Pu8 A==; X-CSE-ConnectionGUID: PxAtAVMDQMa0nmMQAx8+AQ== X-CSE-MsgGUID: ONSEAHzGRRG7MO4xLccfJA== X-IronPort-AV: E=McAfee;i="6700,10204,11222"; a="30718755" X-IronPort-AV: E=Sophos;i="6.11,199,1725346800"; d="scan'208";a="30718755" Received: from fmviesa001.fm.intel.com ([10.60.135.141]) by orvoesa110.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Nov 2024 03:27:27 -0800 X-CSE-ConnectionGUID: z0FU1QFTRQmU4fKKxBlIIg== X-CSE-MsgGUID: SaMJUyaRSpu+ZSRDDiBfgw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.11,260,1725346800"; d="scan'208";a="114768593" Received: from unknown (HELO silpixa00401385.ir.intel.com) ([10.237.214.25]) by fmviesa001.fm.intel.com with ESMTP; 05 Nov 2024 03:27:26 -0800 From: Bruce Richardson To: dev@dpdk.org Cc: Bruce Richardson , stable@dpdk.org, Stephen Hemminger Subject: [PATCH] app/dumpcap: remove unused struct array Date: Tue, 5 Nov 2024 11:27:21 +0000 Message-ID: <20241105112721.373285-1-bruce.richardson@intel.com> X-Mailer: git-send-email 2.43.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org The callbacks(rx_cb) member of struct interface was unused inside dumpcap, but was taking up a lot of memory space, since it was scaled according to RTE_MAX_QUEUES_PER_PORT, which is 1k by default. Save memory by removing the whole array. Fixes: cbb44143be74 ("app/dumpcap: add new packet capture application") Cc: stable@dpdk.org Suggested-by: Stephen Hemminger Signed-off-by: Bruce Richardson --- app/dumpcap/main.c | 1 - 1 file changed, 1 deletion(-) diff --git a/app/dumpcap/main.c b/app/dumpcap/main.c index 4031f48441..3d3c0dbc66 100644 --- a/app/dumpcap/main.c +++ b/app/dumpcap/main.c @@ -96,7 +96,6 @@ struct interface { struct rte_bpf_prm *bpf_prm; char name[RTE_ETH_NAME_MAX_LEN]; - struct rte_rxtx_callback *rx_cb[RTE_MAX_QUEUES_PER_PORT]; const char *ifname; const char *ifdescr; }; -- 2.43.0