From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 823D845C89;
	Wed,  6 Nov 2024 03:02:15 +0100 (CET)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 2596342D3F;
	Wed,  6 Nov 2024 03:02:15 +0100 (CET)
Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182])
 by mails.dpdk.org (Postfix) with ESMTP id 35CA44027E
 for <dev@dpdk.org>; Wed,  6 Nov 2024 03:02:14 +0100 (CET)
Received: by linux.microsoft.com (Postfix, from userid 1213)
 id 2CBC82127D49; Tue,  5 Nov 2024 18:02:13 -0800 (PST)
DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 2CBC82127D49
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;
 s=default; t=1730858533;
 bh=FkY9/gZSrf5V9ZuLVibPHNJZyNaBlqz4UJz3Wocmi1o=;
 h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
 b=jQHoLLUGd4O1fkXVGtXMVT1gp8gtLzYaPZvKiHKGrdLpiDFGOeGebf5OirrosJFlq
 t+Dxq4/5lA32rPa/nQwcK3Ty48AlO86s6939CeVDOE28cjUH0wgViNeOj5cdBYBAwZ
 +jlkimdRgsaY0zCdqRd5yo2B+mt3xat9ez73ZG54=
Date: Tue, 5 Nov 2024 18:02:13 -0800
From: Andre Muezerie <andremue@linux.microsoft.com>
To: David Marchand <david.marchand@redhat.com>
Cc: stephen@networkplumber.org, aman.deep.singh@intel.com,
 anatoly.burakov@intel.com, andrew.rybchenko@oktetlabs.ru,
 bruce.richardson@intel.com, dev@dpdk.org, dmitry.kozliuk@gmail.com,
 dsosnowski@nvidia.com, fanzhang.oss@gmail.com,
 fengchengwen@huawei.com, ferruh.yigit@amd.com, gakhil@marvell.com,
 harry.van.haaren@intel.com, hkalra@marvell.com,
 honnappa.nagarahalli@arm.com, hujiayu.hu@foxmail.com,
 jingjing.wu@intel.com, kevin.laatz@intel.com,
 konstantin.v.ananyev@yandex.ru, matan@nvidia.com,
 mb@smartsharesystems.com, orika@nvidia.com, pallavi.kadam@intel.com,
 reshma.pattan@intel.com, roretzla@linux.microsoft.com,
 sameh.gobriel@intel.com, suanmingm@nvidia.com, thomas@monjalon.net,
 vfialko@marvell.com, viacheslavo@nvidia.com,
 vladimir.medvedkin@intel.com, yipeng1.wang@intel.com,
 Konstantin Ananyev <konstantin.ananyev@huawei.com>
Subject: Re: [PATCH v4 02/19] eal/linux: remove use of VLAs
Message-ID: <20241106020213.GA20995@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net>
References: <1713397319-26135-1-git-send-email-roretzla@linux.microsoft.com>
 <1730776553-31277-1-git-send-email-andremue@linux.microsoft.com>
 <1730776553-31277-3-git-send-email-andremue@linux.microsoft.com>
 <CAJFAV8wKBjG8X4X9NYCHp6o9=reRVEovNKx5D1a4eGDE9aoWyg@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <CAJFAV8wKBjG8X4X9NYCHp6o9=reRVEovNKx5D1a4eGDE9aoWyg@mail.gmail.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

On Tue, Nov 05, 2024 at 09:19:25AM +0100, David Marchand wrote:
> Hello Andre,
> 
> Thanks for taking over this series.
> 
> On Tue, Nov 5, 2024 at 4:18 AM Andre Muezerie
> <andremue@linux.microsoft.com> wrote:
> >
> > From: Konstantin Ananyev <konstantin.ananyev@huawei.com>
> >
> > 1) ./lib/eal/linux/eal_interrupts.c:1073:16
> >     : warning: ISO C90 forbids variable length array ‘events’
> >
> > eal_intr_handle_interrupts() is called by eal_intr_thread_main()
> > so it seems ok to simply alloc space for events from heap and reuse the
> > same buffer through the life of the thread.
> 
> ASan reports this allocation as a leak because nothing releases it
> when terminating the interrupt thread.
> 
> =================================================================
> ==83289==ERROR: LeakSanitizer: detected memory leaks
> 
> Direct leak of 12300 byte(s) in 1 object(s) allocated from:
>     #0 0x55903c9a54b6 in __interceptor_realloc
> (/home/runner/work/dpdk/dpdk/build/app/dpdk-test+0x2744b6) (BuildId:
> e8a4f6c67f5c6afc20efb5f168c0df885d4c6493)
>     #1 0x7f0011ee8873 in eal_intr_thread_main
> /home/runner/work/dpdk/dpdk/build/../lib/eal/linux/eal_interrupts.c:1174:8
>     #2 0x7f0010694ac2 in start_thread nptl/./nptl/pthread_create.c:442:8
> 
> SUMMARY: AddressSanitizer: 12300 byte(s) leaked in 1 allocation(s).
> ------------------------------------------------------------------------------
> 
> It will need some rework.
> 
> 
> -- 
> David Marchand
Thanks David, I'll look into this.