From: Andre Muezerie <andremue@linux.microsoft.com>
To: David Marchand <david.marchand@redhat.com>
Cc: stephen@networkplumber.org, aman.deep.singh@intel.com,
anatoly.burakov@intel.com, andrew.rybchenko@oktetlabs.ru,
bruce.richardson@intel.com, dev@dpdk.org,
dmitry.kozliuk@gmail.com, dsosnowski@nvidia.com,
fanzhang.oss@gmail.com, fengchengwen@huawei.com,
ferruh.yigit@amd.com, gakhil@marvell.com,
harry.van.haaren@intel.com, hkalra@marvell.com,
honnappa.nagarahalli@arm.com, hujiayu.hu@foxmail.com,
jingjing.wu@intel.com, kevin.laatz@intel.com,
konstantin.v.ananyev@yandex.ru, matan@nvidia.com,
mb@smartsharesystems.com, orika@nvidia.com,
pallavi.kadam@intel.com, reshma.pattan@intel.com,
roretzla@linux.microsoft.com, sameh.gobriel@intel.com,
suanmingm@nvidia.com, thomas@monjalon.net, vfialko@marvell.com,
viacheslavo@nvidia.com, vladimir.medvedkin@intel.com,
yipeng1.wang@intel.com
Subject: Re: [PATCH v4 18/19] test: remove use of VLAs for Windows built code in bitset tests
Date: Tue, 5 Nov 2024 18:06:51 -0800 [thread overview]
Message-ID: <20241106020651.GB20995@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> (raw)
In-Reply-To: <CAJFAV8yTL_+YUYO8Rz2_OUgYz1eCU-74=rvDgakmHnLbUat9GA@mail.gmail.com>
On Tue, Nov 05, 2024 at 09:32:36AM +0100, David Marchand wrote:
> On Tue, Nov 5, 2024 at 4:19 AM Andre Muezerie
> <andremue@linux.microsoft.com> wrote:
> >
> > MSVC does not support VLAs, replace VLAs with standard C arrays
> > or alloca(). alloca() is available for all toolchain/platform
> > combinations officially supported by DPDK.
>
> This commitlog does not reflect what is being changed in the patch.
>
> > Signed-off-by: Andre Muezerie <andremue@linux.microsoft.com>
>
> gcc 13 (at least) complains about this patch.
> https://github.com/ovsrobot/dpdk/actions/runs/11677008675/job/32514228727#step:12:3658
>
> I suspect you may have to change some "static" bitset into a
> dynamically allocated one.
>
>
> --
> David Marchand
Thanks David, I'll address this.
next prev parent reply other threads:[~2024-11-06 2:06 UTC|newest]
Thread overview: 127+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-17 23:41 [PATCH 00/16] remove use of VLAs for Windows built code Tyler Retzlaff
2024-04-17 23:41 ` [PATCH 01/16] eal: include header required for alloca Tyler Retzlaff
2024-04-17 23:41 ` [PATCH 02/16] hash: remove use of VLAs for Windows built code Tyler Retzlaff
2024-04-18 6:45 ` Morten Brørup
2024-04-17 23:41 ` [PATCH 03/16] ethdev: " Tyler Retzlaff
2024-04-17 23:41 ` [PATCH 04/16] gro: " Tyler Retzlaff
2024-04-17 23:41 ` [PATCH 05/16] latencystats: " Tyler Retzlaff
2024-04-17 23:41 ` [PATCH 06/16] lpm: " Tyler Retzlaff
2024-04-17 23:41 ` [PATCH 07/16] rcu: " Tyler Retzlaff
2024-04-17 23:41 ` [PATCH 08/16] app/testpmd: " Tyler Retzlaff
2024-04-17 23:41 ` [PATCH 09/16] test: " Tyler Retzlaff
2024-04-17 23:41 ` [PATCH 10/16] common/idpf: " Tyler Retzlaff
2024-04-17 23:41 ` [PATCH 11/16] net/i40e: " Tyler Retzlaff
2024-04-17 23:41 ` [PATCH 12/16] net/ice: " Tyler Retzlaff
2024-04-17 23:41 ` [PATCH 13/16] net/ixgbe: " Tyler Retzlaff
2024-04-17 23:41 ` [PATCH 14/16] common/mlx5: " Tyler Retzlaff
2024-04-17 23:41 ` [PATCH 15/16] net/mlx5: " Tyler Retzlaff
2024-04-17 23:41 ` [PATCH 16/16] build: enable vla warnings on " Tyler Retzlaff
2024-04-18 6:48 ` Morten Brørup
2024-04-18 15:12 ` Tyler Retzlaff
2024-04-18 15:23 ` Bruce Richardson
2024-04-18 19:22 ` Morten Brørup
2024-04-18 6:49 ` [PATCH 00/16] remove use of VLAs for " Morten Brørup
2024-04-18 12:11 ` Konstantin Ananyev
2024-04-18 15:15 ` Tyler Retzlaff
2024-04-18 15:35 ` Konstantin Ananyev
2024-04-18 20:02 ` [PATCH v2 00/19] remove use of VLAs for Windows Tyler Retzlaff
2024-04-18 20:02 ` [PATCH v2 01/19] eal: include header required for alloca Tyler Retzlaff
2024-04-18 20:02 ` [PATCH v2 02/19] eal/linux: remove use of VLAs Tyler Retzlaff
2024-04-18 20:02 ` [PATCH v2 03/19] eal/common: " Tyler Retzlaff
2024-04-18 20:02 ` [PATCH v2 04/19] ethdev: remove use of VLAs for Windows built code Tyler Retzlaff
2024-04-18 20:02 ` [PATCH v2 05/19] hash: " Tyler Retzlaff
2024-04-18 20:02 ` [PATCH v2 06/19] hash/thash: " Tyler Retzlaff
2024-04-18 20:02 ` [PATCH v2 07/19] rcu: " Tyler Retzlaff
2024-04-18 20:02 ` [PATCH v2 08/19] gro: " Tyler Retzlaff
2024-04-18 20:02 ` [PATCH v2 09/19] latencystats: " Tyler Retzlaff
2024-04-18 20:02 ` [PATCH v2 10/19] lpm: " Tyler Retzlaff
2024-04-18 20:02 ` [PATCH v2 11/19] app/testpmd: " Tyler Retzlaff
2024-04-18 20:02 ` [PATCH v2 12/19] test: " Tyler Retzlaff
2024-04-18 20:02 ` [PATCH v2 13/19] common/idpf: " Tyler Retzlaff
2024-04-18 20:02 ` [PATCH v2 14/19] net/i40e: " Tyler Retzlaff
2024-04-18 20:02 ` [PATCH v2 15/19] net/ice: " Tyler Retzlaff
2024-04-18 20:02 ` [PATCH v2 16/19] net/ixgbe: " Tyler Retzlaff
2024-04-18 20:02 ` [PATCH v2 17/19] common/mlx5: " Tyler Retzlaff
2024-04-18 20:02 ` [PATCH v2 18/19] net/mlx5: " Tyler Retzlaff
2024-04-18 20:02 ` [PATCH v2 19/19] build: enable vla warnings on " Tyler Retzlaff
2024-05-06 18:18 ` [PATCH v3 00/19] remove use of VLAs for Windows Tyler Retzlaff
2024-05-06 18:18 ` [PATCH v3 01/19] eal: include header required for alloca Tyler Retzlaff
2024-05-06 18:18 ` [PATCH v3 02/19] eal/linux: remove use of VLAs Tyler Retzlaff
2024-05-06 18:18 ` [PATCH v3 03/19] eal/common: " Tyler Retzlaff
2024-05-07 0:42 ` Stephen Hemminger
2024-05-06 18:18 ` [PATCH v3 04/19] ethdev: remove use of VLAs for Windows built code Tyler Retzlaff
2024-05-06 18:18 ` [PATCH v3 05/19] hash: " Tyler Retzlaff
2024-05-06 18:18 ` [PATCH v3 06/19] hash/thash: " Tyler Retzlaff
2024-05-06 18:18 ` [PATCH v3 07/19] rcu: " Tyler Retzlaff
2024-05-06 18:18 ` [PATCH v3 08/19] gro: " Tyler Retzlaff
2024-05-07 0:47 ` Stephen Hemminger
2024-05-06 18:18 ` [PATCH v3 09/19] latencystats: " Tyler Retzlaff
2024-05-07 0:47 ` Stephen Hemminger
2024-05-06 18:18 ` [PATCH v3 10/19] lpm: " Tyler Retzlaff
2024-05-06 18:18 ` [PATCH v3 11/19] app/testpmd: " Tyler Retzlaff
2024-05-06 18:18 ` [PATCH v3 12/19] test: " Tyler Retzlaff
2024-05-06 18:18 ` [PATCH v3 13/19] common/idpf: " Tyler Retzlaff
2024-05-06 18:18 ` [PATCH v3 14/19] net/i40e: " Tyler Retzlaff
2024-05-06 18:18 ` [PATCH v3 15/19] net/ice: " Tyler Retzlaff
2024-05-06 18:18 ` [PATCH v3 16/19] net/ixgbe: " Tyler Retzlaff
2024-05-06 18:18 ` [PATCH v3 17/19] common/mlx5: " Tyler Retzlaff
2024-05-06 18:18 ` [PATCH v3 18/19] net/mlx5: " Tyler Retzlaff
2024-05-06 18:18 ` [PATCH v3 19/19] build: enable vla warnings on " Tyler Retzlaff
2024-05-07 2:53 ` [PATCH 1/2] lpm: remove unnecessary temporary VLA Stephen Hemminger
2024-05-07 2:53 ` [PATCH 2/2] latencystats: replace use of VLA Stephen Hemminger
2024-07-09 8:06 ` David Marchand
2024-05-07 7:51 ` [PATCH 1/2] lpm: remove unnecessary temporary VLA Bruce Richardson
2024-07-09 8:26 ` [PATCH v3 00/19] remove use of VLAs for Windows David Marchand
2024-10-07 17:15 ` [PATCH 00/16] remove use of VLAs for Windows built code Stephen Hemminger
2024-11-01 18:06 ` Andre Muezerie
2024-11-05 3:15 ` [PATCH v4 00/19] remove use of VLAs for Windows Andre Muezerie
2024-11-05 3:15 ` [PATCH v4 01/19] eal: include header required for alloca Andre Muezerie
2024-11-05 3:15 ` [PATCH v4 02/19] eal/linux: remove use of VLAs Andre Muezerie
2024-11-05 8:19 ` David Marchand
2024-11-06 2:02 ` Andre Muezerie
2024-11-08 13:44 ` Konstantin Ananyev
2024-11-05 3:15 ` [PATCH v4 03/19] eal/common: " Andre Muezerie
2024-11-05 3:15 ` [PATCH v4 04/19] ethdev: remove use of VLAs for Windows built code Andre Muezerie
2024-11-05 3:15 ` [PATCH v4 05/19] hash: " Andre Muezerie
2024-11-05 3:15 ` [PATCH v4 06/19] hash/thash: remove use of VLAs for Windows built Andre Muezerie
2024-11-05 3:15 ` [PATCH v4 07/19] rcu: remove use of VLAs for Windows built code Andre Muezerie
2024-11-05 3:15 ` [PATCH v4 08/19] gro: " Andre Muezerie
2024-11-05 3:15 ` [PATCH v4 09/19] app/testpmd: remove use of VLAs for Windows built Andre Muezerie
2024-11-05 3:15 ` [PATCH v4 10/19] test: remove use of VLAs for Windows built code Andre Muezerie
2024-11-05 3:15 ` [PATCH v4 11/19] common/idpf: " Andre Muezerie
2024-11-05 3:15 ` [PATCH v4 12/19] net/i40e: " Andre Muezerie
2024-11-05 3:15 ` [PATCH v4 13/19] net/ice: " Andre Muezerie
2024-11-05 3:15 ` [PATCH v4 14/19] net/ixgbe: " Andre Muezerie
2024-11-05 3:15 ` [PATCH v4 15/19] common/mlx5: " Andre Muezerie
2024-11-05 3:15 ` [PATCH v4 16/19] net/mlx5: " Andre Muezerie
2024-11-05 3:15 ` [PATCH v4 17/19] build: enable vla warnings on " Andre Muezerie
2024-11-05 3:15 ` [PATCH v4 18/19] test: remove use of VLAs for Windows built code in bitset tests Andre Muezerie
2024-11-05 8:32 ` David Marchand
2024-11-06 2:06 ` Andre Muezerie [this message]
2024-11-05 3:15 ` [PATCH v4 19/19] app/testpmd: remove use of VLAs for Windows built code in shared_rxq_fwd Andre Muezerie
2024-11-05 9:37 ` [PATCH v4 00/19] remove use of VLAs for Windows Konstantin Ananyev
2024-11-08 0:44 ` [PATCH v5 00/20] " Andre Muezerie
2024-11-08 0:44 ` [PATCH v5 01/20] eal: include header required for alloca Andre Muezerie
2024-11-08 0:44 ` [PATCH v5 02/20] eal/linux: remove use of VLAs Andre Muezerie
2024-11-08 0:44 ` [PATCH v5 03/20] eal/common: " Andre Muezerie
2024-11-08 0:44 ` [PATCH v5 04/20] ethdev: remove use of VLAs for Windows built code Andre Muezerie
2024-11-08 0:44 ` [PATCH v5 05/20] hash: " Andre Muezerie
2024-11-08 0:44 ` [PATCH v5 06/20] hash/thash: remove use of VLAs for Windows built Andre Muezerie
2024-11-08 0:44 ` [PATCH v5 07/20] rcu: remove use of VLAs for Windows built code Andre Muezerie
2024-11-08 0:44 ` [PATCH v5 08/20] net/ice: " Andre Muezerie
2024-11-08 8:51 ` Bruce Richardson
2024-11-08 10:18 ` Konstantin Ananyev
2024-11-08 0:44 ` [PATCH v5 09/20] gro: remove use of VLAs Andre Muezerie
2024-11-08 0:44 ` [PATCH v5 10/20] net/ixgbe: " Andre Muezerie
2024-11-08 0:44 ` [PATCH v5 11/20] net/ice: " Andre Muezerie
2024-11-08 0:44 ` [PATCH v5 12/20] app/testpmd: remove use of VLAs for Windows built Andre Muezerie
2024-11-08 0:44 ` [PATCH v5 13/20] test: remove use of VLAs for Windows built code Andre Muezerie
2024-11-08 0:44 ` [PATCH v5 14/20] common/idpf: " Andre Muezerie
2024-11-08 8:47 ` Bruce Richardson
2024-11-08 0:44 ` [PATCH v5 15/20] net/i40e: " Andre Muezerie
2024-11-08 8:45 ` Bruce Richardson
2024-11-08 0:44 ` [PATCH v5 16/20] common/mlx5: " Andre Muezerie
2024-11-08 0:44 ` [PATCH v5 17/20] net/mlx5: " Andre Muezerie
2024-11-08 0:44 ` [PATCH v5 18/20] build: enable vla warnings on " Andre Muezerie
2024-11-08 0:44 ` [PATCH v5 19/20] test: remove use of VLAs for Windows built code in bitset tests Andre Muezerie
2024-11-08 0:44 ` [PATCH v5 20/20] app/testpmd: remove use of VLAs for Windows built code in shared_rxq_fwd Andre Muezerie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241106020651.GB20995@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net \
--to=andremue@linux.microsoft.com \
--cc=aman.deep.singh@intel.com \
--cc=anatoly.burakov@intel.com \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=bruce.richardson@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=dmitry.kozliuk@gmail.com \
--cc=dsosnowski@nvidia.com \
--cc=fanzhang.oss@gmail.com \
--cc=fengchengwen@huawei.com \
--cc=ferruh.yigit@amd.com \
--cc=gakhil@marvell.com \
--cc=harry.van.haaren@intel.com \
--cc=hkalra@marvell.com \
--cc=honnappa.nagarahalli@arm.com \
--cc=hujiayu.hu@foxmail.com \
--cc=jingjing.wu@intel.com \
--cc=kevin.laatz@intel.com \
--cc=konstantin.v.ananyev@yandex.ru \
--cc=matan@nvidia.com \
--cc=mb@smartsharesystems.com \
--cc=orika@nvidia.com \
--cc=pallavi.kadam@intel.com \
--cc=reshma.pattan@intel.com \
--cc=roretzla@linux.microsoft.com \
--cc=sameh.gobriel@intel.com \
--cc=stephen@networkplumber.org \
--cc=suanmingm@nvidia.com \
--cc=thomas@monjalon.net \
--cc=vfialko@marvell.com \
--cc=viacheslavo@nvidia.com \
--cc=vladimir.medvedkin@intel.com \
--cc=yipeng1.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).