From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id CD9AE45C89;
	Wed,  6 Nov 2024 03:06:54 +0100 (CET)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 9B7DA42D3F;
	Wed,  6 Nov 2024 03:06:54 +0100 (CET)
Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182])
 by mails.dpdk.org (Postfix) with ESMTP id 7FF6A4027E
 for <dev@dpdk.org>; Wed,  6 Nov 2024 03:06:52 +0100 (CET)
Received: by linux.microsoft.com (Postfix, from userid 1213)
 id B75FB2127D56; Tue,  5 Nov 2024 18:06:51 -0800 (PST)
DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com B75FB2127D56
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;
 s=default; t=1730858811;
 bh=taKm5dVQuEqmPtEPXGoTy+U5eOJERz1+DG6IFF956Iw=;
 h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
 b=SXD+bselCR/Wv6qYNThDL9+zh7qOKlDHve6AgvzuY/Qjfs49Y9n2cjlrmYne6U8LT
 HsAIR0sWKBXUoMnG/vxhlX3J9K3p9ERZVPNhYlGgR/+uOB7oBcvfWxM3gLORkHmJcQ
 7hMkEWF+wSxUblMht9RyH0jgsZrawmZFA1X+c30k=
Date: Tue, 5 Nov 2024 18:06:51 -0800
From: Andre Muezerie <andremue@linux.microsoft.com>
To: David Marchand <david.marchand@redhat.com>
Cc: stephen@networkplumber.org, aman.deep.singh@intel.com,
 anatoly.burakov@intel.com, andrew.rybchenko@oktetlabs.ru,
 bruce.richardson@intel.com, dev@dpdk.org, dmitry.kozliuk@gmail.com,
 dsosnowski@nvidia.com, fanzhang.oss@gmail.com,
 fengchengwen@huawei.com, ferruh.yigit@amd.com, gakhil@marvell.com,
 harry.van.haaren@intel.com, hkalra@marvell.com,
 honnappa.nagarahalli@arm.com, hujiayu.hu@foxmail.com,
 jingjing.wu@intel.com, kevin.laatz@intel.com,
 konstantin.v.ananyev@yandex.ru, matan@nvidia.com,
 mb@smartsharesystems.com, orika@nvidia.com, pallavi.kadam@intel.com,
 reshma.pattan@intel.com, roretzla@linux.microsoft.com,
 sameh.gobriel@intel.com, suanmingm@nvidia.com, thomas@monjalon.net,
 vfialko@marvell.com, viacheslavo@nvidia.com,
 vladimir.medvedkin@intel.com, yipeng1.wang@intel.com
Subject: Re: [PATCH v4 18/19] test: remove use of VLAs for Windows built code
 in bitset tests
Message-ID: <20241106020651.GB20995@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net>
References: <1713397319-26135-1-git-send-email-roretzla@linux.microsoft.com>
 <1730776553-31277-1-git-send-email-andremue@linux.microsoft.com>
 <1730776553-31277-19-git-send-email-andremue@linux.microsoft.com>
 <CAJFAV8yTL_+YUYO8Rz2_OUgYz1eCU-74=rvDgakmHnLbUat9GA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <CAJFAV8yTL_+YUYO8Rz2_OUgYz1eCU-74=rvDgakmHnLbUat9GA@mail.gmail.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

On Tue, Nov 05, 2024 at 09:32:36AM +0100, David Marchand wrote:
> On Tue, Nov 5, 2024 at 4:19 AM Andre Muezerie
> <andremue@linux.microsoft.com> wrote:
> >
> > MSVC does not support VLAs, replace VLAs with standard C arrays
> > or alloca(). alloca() is available for all toolchain/platform
> > combinations officially supported by DPDK.
> 
> This commitlog does not reflect what is being changed in the patch.
> 
> > Signed-off-by: Andre Muezerie <andremue@linux.microsoft.com>
> 
> gcc 13 (at least) complains about this patch.
> https://github.com/ovsrobot/dpdk/actions/runs/11677008675/job/32514228727#step:12:3658
> 
> I suspect you may have to change some "static" bitset into a
> dynamically allocated one.
> 
> 
> -- 
> David Marchand
Thanks David, I'll address this.