* [PATCH] app/dumpcap: remove unused struct array
@ 2024-11-05 11:27 Bruce Richardson
2024-11-06 18:18 ` Stephen Hemminger
0 siblings, 1 reply; 3+ messages in thread
From: Bruce Richardson @ 2024-11-05 11:27 UTC (permalink / raw)
To: dev; +Cc: Bruce Richardson, stable, Stephen Hemminger
The callbacks(rx_cb) member of struct interface was unused inside
dumpcap, but was taking up a lot of memory space, since it was scaled
according to RTE_MAX_QUEUES_PER_PORT, which is 1k by default. Save
memory by removing the whole array.
Fixes: cbb44143be74 ("app/dumpcap: add new packet capture application")
Cc: stable@dpdk.org
Suggested-by: Stephen Hemminger <stephen@networkplumber.org>
Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
---
app/dumpcap/main.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/app/dumpcap/main.c b/app/dumpcap/main.c
index 4031f48441..3d3c0dbc66 100644
--- a/app/dumpcap/main.c
+++ b/app/dumpcap/main.c
@@ -96,7 +96,6 @@ struct interface {
struct rte_bpf_prm *bpf_prm;
char name[RTE_ETH_NAME_MAX_LEN];
- struct rte_rxtx_callback *rx_cb[RTE_MAX_QUEUES_PER_PORT];
const char *ifname;
const char *ifdescr;
};
--
2.43.0
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] app/dumpcap: remove unused struct array
2024-11-05 11:27 [PATCH] app/dumpcap: remove unused struct array Bruce Richardson
@ 2024-11-06 18:18 ` Stephen Hemminger
2024-11-06 20:35 ` David Marchand
0 siblings, 1 reply; 3+ messages in thread
From: Stephen Hemminger @ 2024-11-06 18:18 UTC (permalink / raw)
To: Bruce Richardson; +Cc: dev, stable
On Tue, 5 Nov 2024 11:27:21 +0000
Bruce Richardson <bruce.richardson@intel.com> wrote:
> The callbacks(rx_cb) member of struct interface was unused inside
> dumpcap, but was taking up a lot of memory space, since it was scaled
> according to RTE_MAX_QUEUES_PER_PORT, which is 1k by default. Save
> memory by removing the whole array.
>
> Fixes: cbb44143be74 ("app/dumpcap: add new packet capture application")
> Cc: stable@dpdk.org
>
> Suggested-by: Stephen Hemminger <stephen@networkplumber.org>
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
Acked-by: Stephen Hemminger <stephen@networkplumber.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] app/dumpcap: remove unused struct array
2024-11-06 18:18 ` Stephen Hemminger
@ 2024-11-06 20:35 ` David Marchand
0 siblings, 0 replies; 3+ messages in thread
From: David Marchand @ 2024-11-06 20:35 UTC (permalink / raw)
To: Bruce Richardson; +Cc: dev, stable, Stephen Hemminger
On Wed, Nov 6, 2024 at 7:18 PM Stephen Hemminger
<stephen@networkplumber.org> wrote:
>
> On Tue, 5 Nov 2024 11:27:21 +0000
> Bruce Richardson <bruce.richardson@intel.com> wrote:
>
> > The callbacks(rx_cb) member of struct interface was unused inside
> > dumpcap, but was taking up a lot of memory space, since it was scaled
> > according to RTE_MAX_QUEUES_PER_PORT, which is 1k by default. Save
> > memory by removing the whole array.
> >
> > Fixes: cbb44143be74 ("app/dumpcap: add new packet capture application")
> > Cc: stable@dpdk.org
> >
> > Suggested-by: Stephen Hemminger <stephen@networkplumber.org>
> > Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> Acked-by: Stephen Hemminger <stephen@networkplumber.org>
Applied, thanks.
--
David Marchand
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-11-06 20:35 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-11-05 11:27 [PATCH] app/dumpcap: remove unused struct array Bruce Richardson
2024-11-06 18:18 ` Stephen Hemminger
2024-11-06 20:35 ` David Marchand
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).