From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0B24845C9D; Wed, 6 Nov 2024 19:18:41 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C93FF42E68; Wed, 6 Nov 2024 19:18:40 +0100 (CET) Received: from mail-pf1-f178.google.com (mail-pf1-f178.google.com [209.85.210.178]) by mails.dpdk.org (Postfix) with ESMTP id 26B1F402BC for ; Wed, 6 Nov 2024 19:18:40 +0100 (CET) Received: by mail-pf1-f178.google.com with SMTP id d2e1a72fcca58-720c2db824eso41700b3a.0 for ; Wed, 06 Nov 2024 10:18:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1730917119; x=1731521919; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=TYzTrJAOq769uP1CIw8QinwSP4WVt3QqEBI/dUdrFRU=; b=rNUzV1wMDCrN2exN8uYaf7T1QHVE1U+5DRfOGaFLMLoIl+q5UCHWh+oZMfmpMWpZ9F 5sry4l6ZBUlt2TMwro5NeUVs+9j4YvXRsnLrfHhVLZ038Rc9WCJR6UzlEz8IZwJYyaS6 bOFnz2VIWJgpJoa3WyeI34rdXmsL4AqhtwyNlriiGvVE7MjIC3Q6c//3FYSI2iNw/wdt axxHvLKEA+feH+3ix5mAlq0RlYnoaZvOU5iqkva4b3svKPJtKc8hxbuSRAoyv+85tq7j O0+lrIbgz/xIrlJhji7JkTWCh/8Q3r/S7qv4sxEkoNRtWLPzTad/Yx9l8IuifZP5434B iYpw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730917119; x=1731521919; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=TYzTrJAOq769uP1CIw8QinwSP4WVt3QqEBI/dUdrFRU=; b=jwQoPuMk6wFoOni0KdD9B0Lz4sa0PMoqvzwgH2/t0K7ICX9pLR4LS+jlPd7w0u5BRt leD+57bwAlZgBuAc8uoA1f9fhfcFrlUezV5LClrVPLPGh1hNa4On/Z9zUNWjWeesYr2h r8YuDutuDu77nYKnEH8/lBUdkvnO1r4xOxLfMXWMIw8cuGhYhfbLIFKzbC9ST1HRJ1nS EgVFMGIl+0jMBfX4YJDLZNLCe2srAFlP0ePo+9J9F/LzJKne/trnC7eHvndS2LQyeJTh RWDfnyDwYBxACOKSGel/XOXKazpnyMo8toJ7PDnbB/zBZmswqP4QI0reMynIDWRmuffv /wDA== X-Gm-Message-State: AOJu0Yy04kJKtWqmgJhCVFZgNPfa2SU7cOOSMsymeSjgaIckxmU7fi+2 c17yw6GYKN9sK/aazrA0OWdhUgVMcGxRNtl9ehvjslL45na+aSSLeU1nOzBwrrM= X-Google-Smtp-Source: AGHT+IGO0Ni1qK36hA9Zd8MZzQi7REa2WOz9E8J2BlXJB01/rT4gGm1GGS2mldzdrfz+zgAULwTo0Q== X-Received: by 2002:a05:6a00:b55:b0:71e:744a:3fbd with SMTP id d2e1a72fcca58-7206306df29mr55361912b3a.20.1730917118875; Wed, 06 Nov 2024 10:18:38 -0800 (PST) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-720bc1b8971sm12396045b3a.12.2024.11.06.10.18.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Nov 2024 10:18:38 -0800 (PST) Date: Wed, 6 Nov 2024 10:18:36 -0800 From: Stephen Hemminger To: Bruce Richardson Cc: dev@dpdk.org, stable@dpdk.org Subject: Re: [PATCH] app/dumpcap: remove unused struct array Message-ID: <20241106101836.0f66c457@hermes.local> In-Reply-To: <20241105112721.373285-1-bruce.richardson@intel.com> References: <20241105112721.373285-1-bruce.richardson@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, 5 Nov 2024 11:27:21 +0000 Bruce Richardson wrote: > The callbacks(rx_cb) member of struct interface was unused inside > dumpcap, but was taking up a lot of memory space, since it was scaled > according to RTE_MAX_QUEUES_PER_PORT, which is 1k by default. Save > memory by removing the whole array. > > Fixes: cbb44143be74 ("app/dumpcap: add new packet capture application") > Cc: stable@dpdk.org > > Suggested-by: Stephen Hemminger > Signed-off-by: Bruce Richardson Acked-by: Stephen Hemminger