* [PATCH] doc: update match with compare result item limitation
@ 2024-11-05 1:47 Suanming Mou
2024-11-05 3:48 ` Bing Zhao
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Suanming Mou @ 2024-11-05 1:47 UTC (permalink / raw)
To: Dariusz Sosnowski, Viacheslav Ovsiienko, Bing Zhao, Ori Kam, Matan Azrad
Cc: dev, stable
In switch mode, when ``repr_matching_en`` flag is enabled in the devarg,
the match with compare result item is not supported to the ``ingress``
rule as an implicit REPRESENTED_PORT need to be added to the matcher.
That REPRESENTED_PORT item conflicts with the single item limitation for
match with compare result item.
Fixes: cb25df7ce9d6 ("net/mlx5: support comparison matching")
Cc: stable@dpdk.org
Signed-off-by: Suanming Mou <suanmingm@nvidia.com>
---
doc/guides/nics/mlx5.rst | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/doc/guides/nics/mlx5.rst b/doc/guides/nics/mlx5.rst
index 7ced6ca8f9..43ae9070ab 100644
--- a/doc/guides/nics/mlx5.rst
+++ b/doc/guides/nics/mlx5.rst
@@ -460,6 +460,11 @@ Limitations
- The field type ``RTE_FLOW_FIELD_VALUE`` must be the base (``b``) field.
- The field type ``RTE_FLOW_FIELD_RANDOM`` can only be compared with
``RTE_FLOW_FIELD_VALUE``.
+ - In switch mode, when ``repr_matching_en`` flag is enabled in the devarg,
+ the match with compare result item is not supported to the ``ingress``
+ rule as an implicit REPRESENTED_PORT need to be added to the matcher.
+ That REPRESENTED_PORT item conflicts with the single item limitation for
+ match with compare result item.
- No Tx metadata go to the E-Switch steering domain for the Flow group 0.
The flows within group 0 and set metadata action are rejected by hardware.
--
2.34.1
^ permalink raw reply [flat|nested] 5+ messages in thread* RE: [PATCH] doc: update match with compare result item limitation
2024-11-05 1:47 [PATCH] doc: update match with compare result item limitation Suanming Mou
@ 2024-11-05 3:48 ` Bing Zhao
2024-11-06 9:01 ` Suanming Mou
2024-11-06 9:34 ` [PATCH v2] " Suanming Mou
2024-11-06 18:29 ` [PATCH] " Stephen Hemminger
2 siblings, 1 reply; 5+ messages in thread
From: Bing Zhao @ 2024-11-05 3:48 UTC (permalink / raw)
To: Suanming Mou, Dariusz Sosnowski, Slava Ovsiienko, Ori Kam, Matan Azrad
Cc: dev, stable
The ` repr_matching_en ` flag is enabled (by default) can be added.
> -----Original Message-----
> From: Suanming Mou <suanmingm@nvidia.com>
> Sent: Tuesday, November 5, 2024 9:48 AM
> To: Dariusz Sosnowski <dsosnowski@nvidia.com>; Slava Ovsiienko
> <viacheslavo@nvidia.com>; Bing Zhao <bingz@nvidia.com>; Ori Kam
> <orika@nvidia.com>; Matan Azrad <matan@nvidia.com>
> Cc: dev@dpdk.org; stable@dpdk.org
> Subject: [PATCH] doc: update match with compare result item limitation
>
> In switch mode, when ``repr_matching_en`` flag is enabled in the devarg,
> the match with compare result item is not supported to the ``ingress``
> rule as an implicit REPRESENTED_PORT need to be added to the matcher.
> That REPRESENTED_PORT item conflicts with the single item limitation for
> match with compare result item.
>
> Fixes: cb25df7ce9d6 ("net/mlx5: support comparison matching")
> Cc: stable@dpdk.org
>
> Signed-off-by: Suanming Mou <suanmingm@nvidia.com>
> ---
> doc/guides/nics/mlx5.rst | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/doc/guides/nics/mlx5.rst b/doc/guides/nics/mlx5.rst index
> 7ced6ca8f9..43ae9070ab 100644
> --- a/doc/guides/nics/mlx5.rst
> +++ b/doc/guides/nics/mlx5.rst
> @@ -460,6 +460,11 @@ Limitations
> - The field type ``RTE_FLOW_FIELD_VALUE`` must be the base (``b``)
> field.
> - The field type ``RTE_FLOW_FIELD_RANDOM`` can only be compared with
> ``RTE_FLOW_FIELD_VALUE``.
> + - In switch mode, when ``repr_matching_en`` flag is enabled in the
> devarg,
> + the match with compare result item is not supported to the
> ``ingress``
> + rule as an implicit REPRESENTED_PORT need to be added to the matcher.
> + That REPRESENTED_PORT item conflicts with the single item limitation
> for
> + match with compare result item.
>
> - No Tx metadata go to the E-Switch steering domain for the Flow group 0.
> The flows within group 0 and set metadata action are rejected by
> hardware.
> --
> 2.34.1
^ permalink raw reply [flat|nested] 5+ messages in thread* RE: [PATCH] doc: update match with compare result item limitation
2024-11-05 3:48 ` Bing Zhao
@ 2024-11-06 9:01 ` Suanming Mou
0 siblings, 0 replies; 5+ messages in thread
From: Suanming Mou @ 2024-11-06 9:01 UTC (permalink / raw)
To: Bing Zhao, Dariusz Sosnowski, Slava Ovsiienko, Ori Kam, Matan Azrad
Cc: dev, stable
> -----Original Message-----
> From: Bing Zhao <bingz@nvidia.com>
> Sent: Tuesday, November 5, 2024 11:48 AM
> To: Suanming Mou <suanmingm@nvidia.com>; Dariusz Sosnowski
> <dsosnowski@nvidia.com>; Slava Ovsiienko <viacheslavo@nvidia.com>; Ori Kam
> <orika@nvidia.com>; Matan Azrad <matan@nvidia.com>
> Cc: dev@dpdk.org; stable@dpdk.org
> Subject: RE: [PATCH] doc: update match with compare result item limitation
>
> The ` repr_matching_en ` flag is enabled (by default) can be added.
OK, let's update a new version.
>
> > -----Original Message-----
> > From: Suanming Mou <suanmingm@nvidia.com>
> > Sent: Tuesday, November 5, 2024 9:48 AM
> > To: Dariusz Sosnowski <dsosnowski@nvidia.com>; Slava Ovsiienko
> > <viacheslavo@nvidia.com>; Bing Zhao <bingz@nvidia.com>; Ori Kam
> > <orika@nvidia.com>; Matan Azrad <matan@nvidia.com>
> > Cc: dev@dpdk.org; stable@dpdk.org
> > Subject: [PATCH] doc: update match with compare result item limitation
> >
> > In switch mode, when ``repr_matching_en`` flag is enabled in the
> > devarg, the match with compare result item is not supported to the
> > ``ingress`` rule as an implicit REPRESENTED_PORT need to be added to the
> matcher.
> > That REPRESENTED_PORT item conflicts with the single item limitation
> > for match with compare result item.
> >
> > Fixes: cb25df7ce9d6 ("net/mlx5: support comparison matching")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Suanming Mou <suanmingm@nvidia.com>
> > ---
> > doc/guides/nics/mlx5.rst | 5 +++++
> > 1 file changed, 5 insertions(+)
> >
> > diff --git a/doc/guides/nics/mlx5.rst b/doc/guides/nics/mlx5.rst index
> > 7ced6ca8f9..43ae9070ab 100644
> > --- a/doc/guides/nics/mlx5.rst
> > +++ b/doc/guides/nics/mlx5.rst
> > @@ -460,6 +460,11 @@ Limitations
> > - The field type ``RTE_FLOW_FIELD_VALUE`` must be the base (``b``)
> > field.
> > - The field type ``RTE_FLOW_FIELD_RANDOM`` can only be compared
> with
> > ``RTE_FLOW_FIELD_VALUE``.
> > + - In switch mode, when ``repr_matching_en`` flag is enabled in the
> > devarg,
> > + the match with compare result item is not supported to the
> > ``ingress``
> > + rule as an implicit REPRESENTED_PORT need to be added to the
> matcher.
> > + That REPRESENTED_PORT item conflicts with the single item
> > + limitation
> > for
> > + match with compare result item.
> >
> > - No Tx metadata go to the E-Switch steering domain for the Flow group 0.
> > The flows within group 0 and set metadata action are rejected by
> > hardware.
> > --
> > 2.34.1
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH v2] doc: update match with compare result item limitation
2024-11-05 1:47 [PATCH] doc: update match with compare result item limitation Suanming Mou
2024-11-05 3:48 ` Bing Zhao
@ 2024-11-06 9:34 ` Suanming Mou
2024-11-06 18:29 ` [PATCH] " Stephen Hemminger
2 siblings, 0 replies; 5+ messages in thread
From: Suanming Mou @ 2024-11-06 9:34 UTC (permalink / raw)
To: Dariusz Sosnowski, Viacheslav Ovsiienko, Bing Zhao, Ori Kam, Matan Azrad
Cc: dev, stable
In switch mode, when ``repr_matching_en`` flag is enabled in the devarg,
the match with compare result item is not supported to the ``ingress``
rule as an implicit REPRESENTED_PORT need to be added to the matcher.
That REPRESENTED_PORT item conflicts with the single item limitation for
match with compare result item.
Fixes: cb25df7ce9d6 ("net/mlx5: support comparison matching")
Cc: stable@dpdk.org
Signed-off-by: Suanming Mou <suanmingm@nvidia.com>
---
v2: Add `repr_matching_en`` enabled by default explanation.
---
doc/guides/nics/mlx5.rst | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/doc/guides/nics/mlx5.rst b/doc/guides/nics/mlx5.rst
index 7ced6ca8f9..64933a0823 100644
--- a/doc/guides/nics/mlx5.rst
+++ b/doc/guides/nics/mlx5.rst
@@ -460,6 +460,11 @@ Limitations
- The field type ``RTE_FLOW_FIELD_VALUE`` must be the base (``b``) field.
- The field type ``RTE_FLOW_FIELD_RANDOM`` can only be compared with
``RTE_FLOW_FIELD_VALUE``.
+ - In switch mode, when ``repr_matching_en`` flag is enabled (by default)
+ in the devarg, the match with compare result item is not supported to
+ the ``ingress`` rule as an implicit REPRESENTED_PORT need to be added to
+ the matcher. That REPRESENTED_PORT item conflicts with the single item
+ limitation for match with compare result item.
- No Tx metadata go to the E-Switch steering domain for the Flow group 0.
The flows within group 0 and set metadata action are rejected by hardware.
--
2.34.1
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] doc: update match with compare result item limitation
2024-11-05 1:47 [PATCH] doc: update match with compare result item limitation Suanming Mou
2024-11-05 3:48 ` Bing Zhao
2024-11-06 9:34 ` [PATCH v2] " Suanming Mou
@ 2024-11-06 18:29 ` Stephen Hemminger
2 siblings, 0 replies; 5+ messages in thread
From: Stephen Hemminger @ 2024-11-06 18:29 UTC (permalink / raw)
To: Suanming Mou
Cc: Dariusz Sosnowski, Viacheslav Ovsiienko, Bing Zhao, Ori Kam,
Matan Azrad, dev, stable
On Tue, 5 Nov 2024 09:47:36 +0800
Suanming Mou <suanmingm@nvidia.com> wrote:
> + - In switch mode, when ``repr_matching_en`` flag is enabled in the devarg,
> + the match with compare result item is not supported to the ``ingress``
> + rule as an implicit REPRESENTED_PORT need to be added to the matcher.
> + That REPRESENTED_PORT item conflicts with the single item limitation for
> + match with compare result item.
These sentences are hard to read, the wording is very awkward.
Have no detailed insight into the mlx5 matching but maybe this wording:
In switch mode, when the ``repr_matching_en`` flag is used then matching
with ingress comparison is not supported because an implicit rule is required
to match the REPRESENTED_PORT. And that implicit rule would conflict with the
ingress compare rule.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2024-11-06 18:29 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-11-05 1:47 [PATCH] doc: update match with compare result item limitation Suanming Mou
2024-11-05 3:48 ` Bing Zhao
2024-11-06 9:01 ` Suanming Mou
2024-11-06 9:34 ` [PATCH v2] " Suanming Mou
2024-11-06 18:29 ` [PATCH] " Stephen Hemminger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).