From: Bruce Richardson <bruce.richardson@intel.com>
To: dev@dpdk.org
Cc: Bruce Richardson <bruce.richardson@intel.com>,
Jerin Jacob <jerinj@marvell.com>
Subject: [PATCH v2 2/2] eventdev: add standard aliases for telemetry commands
Date: Wed, 6 Nov 2024 16:31:06 +0000 [thread overview]
Message-ID: <20241106163106.1114932-3-bruce.richardson@intel.com> (raw)
In-Reply-To: <20241106163106.1114932-1-bruce.richardson@intel.com>
Most other device classes in DPDK which offer telemetry provide a list
of the devices of that class via "/<class>/list", e.g. /ethdev/list,
/ring/list, /mempool/list. However, eventdev provided that list via
"dev_list" command. For consistency, add "list" as an alias for
"dev_list" - after all the "dev" is part of the initial "/eventdev"
prefix part, so should not need repeating.
Similarly for the "dev_info" command, provide an alias as just "info".
Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
---
lib/eventdev/rte_eventdev.c | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/lib/eventdev/rte_eventdev.c b/lib/eventdev/rte_eventdev.c
index 23631ff3f6..d3f1ea092f 100644
--- a/lib/eventdev/rte_eventdev.c
+++ b/lib/eventdev/rte_eventdev.c
@@ -2067,6 +2067,15 @@ RTE_INIT(eventdev_init_telemetry)
"Returns list of available eventdevs. Takes no parameters");
rte_telemetry_register_cmd("/eventdev/dev_info", handle_dev_info,
"Returns basic info about an eventdev. Parameter: DevID");
+
+ /* alias "dev_list" and "dev_info" as just "list" and "info" to match
+ * other categories, such as ethdev, ring, mempool etc.
+ */
+ rte_telemetry_register_cmd("/eventdev/list", handle_dev_list,
+ "Returns list of available eventdevs. Takes no parameters");
+ rte_telemetry_register_cmd("/eventdev/info", handle_dev_info,
+ "Returns basic info about an eventdev. Parameter: DevID");
+
rte_telemetry_register_cmd("/eventdev/port_list", handle_port_list,
"Returns list of available ports. Parameter: DevID");
rte_telemetry_register_cmd("/eventdev/queue_list", handle_queue_list,
--
2.43.0
prev parent reply other threads:[~2024-11-06 16:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-06 16:07 [PATCH] eventdev: add device info telemetry command Bruce Richardson
2024-11-06 16:31 ` [PATCH v2 0/2] small improvements for eventdev telemetry Bruce Richardson
2024-11-06 16:31 ` [PATCH v2 1/2] eventdev: add device info telemetry command Bruce Richardson
2024-11-06 16:31 ` Bruce Richardson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241106163106.1114932-3-bruce.richardson@intel.com \
--to=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=jerinj@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).