From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 65D1945CA4; Thu, 7 Nov 2024 17:30:52 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 58B2343246; Thu, 7 Nov 2024 17:30:52 +0100 (CET) Received: from mail-pl1-f174.google.com (mail-pl1-f174.google.com [209.85.214.174]) by mails.dpdk.org (Postfix) with ESMTP id 91EE143001 for ; Thu, 7 Nov 2024 17:30:51 +0100 (CET) Received: by mail-pl1-f174.google.com with SMTP id d9443c01a7336-207115e3056so12531435ad.2 for ; Thu, 07 Nov 2024 08:30:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1730997051; x=1731601851; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=kaevVSNzid6Tr0nJb+OeSeI5mAhENzE8SUhodWzu0xI=; b=15uQRlRBzlGHD3jM9utLeoxEIzWgW1PR8SrU+XHvbCxV0VT7MqU7X0wELH2Nni4Njs m2eX1f4wClg3/bO8k/ERYG3l5X/rslGDDToUEdq7F/dZn698h4FJL+OAVYywssaZRBix 7YW98ULTnRrXMGU15SrOVG/2y+dra4E5d0T9kLR+dJLPuIafSc5xugW+MXQkGWXv2OIC VLL0urSWE7ldrK1nwtp3TrvGsmGEJvVu3j6P8oFCljuUNoUNZboToGLrNzwutB0ohEO1 ht9bCgszRqUdVq3wN8sFTjYfqrE6ljLsO/WvbWdtfojLCBs0/tHsBM3UqeqHt3OEELLz ZS1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730997051; x=1731601851; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=kaevVSNzid6Tr0nJb+OeSeI5mAhENzE8SUhodWzu0xI=; b=lmLy2rt9ofnWjBpcv9QGbi89tYHfHpCYjBtINFsVN0Q41mhr1h1LN7lPML/JLu9D4Y /lhHOdWxS97/W6oLJ5mQZT4dFMfrSc+BUbFJflLwLlLFkLmUWSoGibvt9pSuFxZQlaY1 F8Mv7/eNwVD45PY+l5AdzuwL27wrC8BH4WLyZRqSCv/gKDHHjAtvcFu4umK22uQYjGkM 0isYJs8/qdY20n86zF6/QvjFsKSYROEkPWq0OzTUBj+g62JqdFHPHXbWI+0oEUEWI3zs nYxpEj5fj25PCVddr0mr2QOEknVty1uppMVy/OdCH0IUyhgiX1HmENIaCPhw7wi8vn3d Md8g== X-Gm-Message-State: AOJu0Yzt6h3DzoLt9AngVSeIpCX3Tg30/ktPNClcxgeGYoJ0B+1hbttL 7fm4jrgL8oYKNal8xugnsVDT5+tfze0U1SBbnRWRbffDt74gz6gx6Tx7I1DO38w= X-Google-Smtp-Source: AGHT+IGwHoxJKaHHIEuR7YFK2nW2IY4isZGuVDhxCq7uMyCRXPvSA72JsixjXi/WcqJItDJgv1/1nw== X-Received: by 2002:a17:902:d2d0:b0:20c:b0c7:7f0d with SMTP id d9443c01a7336-21182334375mr427435ad.25.1730997050803; Thu, 07 Nov 2024 08:30:50 -0800 (PST) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-21177e6abb0sm14162735ad.244.2024.11.07.08.30.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 Nov 2024 08:30:50 -0800 (PST) Date: Thu, 7 Nov 2024 08:21:41 -0800 From: Stephen Hemminger To: Jie Hai Cc: , , , Chunsong Feng , Ferruh Yigit , "Min Hu (Connor)" , Chengwen Feng , Hao Chen , , Subject: Re: [PATCH 1/2] net/hns3: fix error code for repeatedly create counter Message-ID: <20241107082141.526bdcfb@hermes.local> In-Reply-To: <20241107115645.22617-2-haijie1@huawei.com> References: <20241107115645.22617-1-haijie1@huawei.com> <20241107115645.22617-2-haijie1@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, 7 Nov 2024 19:56:44 +0800 Jie Hai wrote: > From: Dengdui Huang > > Return EINVAL instead of ENOSPC when the same counter ID is > used for multiple times to create a counter. > > Fixes: fcba820d9b9e ("net/hns3: support flow director") > Cc: stable@dpdk.org > > Signed-off-by: Dengdui Huang > Signed-off-by: Jie Hai Not sure that actual error number matters that much, but looks good to me. Another alternative might be EEXIST which is the error code used when creat() is called on an existing file. Acked-by: Stephen Hemminger