From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 85EDD45CB4; Fri, 8 Nov 2024 17:00:41 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5F3F143348; Fri, 8 Nov 2024 17:00:41 +0100 (CET) Received: from mail-pf1-f175.google.com (mail-pf1-f175.google.com [209.85.210.175]) by mails.dpdk.org (Postfix) with ESMTP id B99814025C for ; Fri, 8 Nov 2024 17:00:39 +0100 (CET) Received: by mail-pf1-f175.google.com with SMTP id d2e1a72fcca58-71e681bc315so1775372b3a.0 for ; Fri, 08 Nov 2024 08:00:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1731081639; x=1731686439; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=7uBhJcw8sqeOTNQ3g1122ci/5oEqgruSsrK5LGnzrNU=; b=p69Dqt65DBSmJAiUclD2+0jjn10rGoQW1EktDUaPVqMyXQ0ts08ALye0/9e8b31Guk fU+ZEBLO2so0bihpg+5COPg2eJo6hKuwMC9RU/kMQGc4hYI4bq5PUtiMI9YXXDbIMQZ3 Pfdwe5RY79jKKTnF01hhVI+MgMs4mqPWBI5GRdRPAFe2b+qBQ2YD/viyvDzI2HHEZR4s VW022caM9LPYEWePHvMOEBM6F6E0WkH2lwd5t8gwl6j1XUTP6BQMqTM+KdPebCTNnhuw F6N1jH+OY5wlhGH2X0ID6yNsRsfOq1yHPy/VkhF0kl2mLhVIW2CgB0S+bKt3Hfiotx4K 1BSg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1731081639; x=1731686439; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=7uBhJcw8sqeOTNQ3g1122ci/5oEqgruSsrK5LGnzrNU=; b=PYAv3LcXhX0eiswYNrFX4sRkgqXFA4i6aNtDCLfwkun0kH2ym9IT8PnvFdYnySQE1F Ag/Tdd/x6MfGeX+tq4uw25D9fZcvtlOplQM+9HT+ptwChtBMzYtsyelXeYOsZ0o3uZix peiqlP5nU22eR2YMKI073h8A51DIIoGBR3hahFdIm0AGMTxaPQAfW84JJga0mX+k5tOv ANJgH+FjZsUxFae3SZffkjlERoVIPISTcSAmoBdWC1Q6M20iyzNf0I5jdzHx6H8Isl7Z DKTZ8+PnLVkidE6y393gCaBgWT9PMRzqYBDS4tj+dzpNRCunfcUb5tZ+KxzbyMADJm5c wq1A== X-Gm-Message-State: AOJu0Yw36g7Su4x++Y5uKoeyI8C2AB7yESUL+ILycBzVNefrTvkE3KUq kpBVgb5Abmh8lDYCE8PlKaU4RgHFUMttfHGa3ZWp6C3V4JLHLBsofDm3KydNaFWznOZgvZpFq+x J X-Google-Smtp-Source: AGHT+IE5sehGUPZ1vhB8dHonlijmu1hE7HsV8PMA0eLU+yiOBO+1VqCGBhDlT5MzzW3/D9nJ9qoiEQ== X-Received: by 2002:a05:6a00:140f:b0:71e:6fcb:7693 with SMTP id d2e1a72fcca58-724140a4ddfmr5424374b3a.12.1731081637033; Fri, 08 Nov 2024 08:00:37 -0800 (PST) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-724078a8a54sm3828344b3a.58.2024.11.08.08.00.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Nov 2024 08:00:36 -0800 (PST) Date: Fri, 8 Nov 2024 08:00:35 -0800 From: Stephen Hemminger To: Thomas Monjalon Cc: dev@dpdk.org, David Marchand , Mattias =?UTF-8?B?UsO2bm5ibG9t?= , Tyler Retzlaff , Morten =?UTF-8?B?QnLDuHJ1cA==?= , Chengwen Feng , Konstantin Ananyev Subject: Re: [PATCH] eal: fix cleanup on Windows Message-ID: <20241108080035.42c834aa@hermes.local> In-Reply-To: <20241108130822.4073057-1-thomas@monjalon.net> References: <20241108130822.4073057-1-thomas@monjalon.net> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, 8 Nov 2024 14:08:21 +0100 Thomas Monjalon wrote: > The memory allocated with _aligned_malloc() > must be released with _aligned_free() on Windows. > > The POSIX free() was called in eal_lcore_var_cleanup(), > called in rte_eal_cleanup(), and triggered a heap corruption: > exit status 3221226356 or signal 3221226228 SIGinvalid > with MALLOC_PERTURB_=86 > > Fixes: 5bce9bed67ad ("eal: add static per-lcore memory allocation facility") > > Reported-by: David Marchand > Signed-off-by: Thomas Monjalon Is there anyway to use the function attributes to catch this at compile time (for Gcc builds).