From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8822D45CA6; Fri, 8 Nov 2024 12:17:44 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9FA41433B3; Fri, 8 Nov 2024 12:16:05 +0100 (CET) Received: from szxga04-in.huawei.com (szxga04-in.huawei.com [45.249.212.190]) by mails.dpdk.org (Postfix) with ESMTP id B82054337E for ; Fri, 8 Nov 2024 12:15:51 +0100 (CET) Received: from mail.maildlp.com (unknown [172.19.88.214]) by szxga04-in.huawei.com (SkyGuard) with ESMTP id 4XlGYY4k9Gz20spt; Fri, 8 Nov 2024 19:14:41 +0800 (CST) Received: from kwepemf500004.china.huawei.com (unknown [7.202.181.242]) by mail.maildlp.com (Postfix) with ESMTPS id C1F151A016C; Fri, 8 Nov 2024 19:15:50 +0800 (CST) Received: from localhost.localdomain (10.28.79.22) by kwepemf500004.china.huawei.com (7.202.181.242) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Fri, 8 Nov 2024 19:15:50 +0800 From: Jie Hai To: , , , Kai Ji , Arkadiusz Kusztal , Brian Dooley CC: , , , Subject: [PATCH v5 21/25] common/qat: replace strtok with reentrant version Date: Fri, 8 Nov 2024 19:04:00 +0800 Message-ID: <20241108110404.18317-22-haijie1@huawei.com> X-Mailer: git-send-email 2.22.0 In-Reply-To: <20241108110404.18317-1-haijie1@huawei.com> References: <20231113104550.2138654-1-haijie1@huawei.com> <20241108110404.18317-1-haijie1@huawei.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.28.79.22] X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To kwepemf500004.china.huawei.com (7.202.181.242) X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Multiple threads calling the same function may cause condition race issues, which often leads to abnormal behavior and can cause more serious vulnerabilities such as abnormal termination, denial of service, and compromised data integrity. The strtok() is non-reentrant, it is better to replace it with a reentrant version. Fixes: 99ab2806687b ("common/qat: isolate parser arguments configuration") Signed-off-by: Jie Hai --- drivers/common/qat/qat_device.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/common/qat/qat_device.c b/drivers/common/qat/qat_device.c index bca88fd9bded..99153775d883 100644 --- a/drivers/common/qat/qat_device.c +++ b/drivers/common/qat/qat_device.c @@ -4,6 +4,7 @@ #include #include +#include #include #include "qat_device.h" @@ -222,6 +223,7 @@ qat_dev_parse_command_line(struct qat_pci_device *qat_dev, { int len = 0; char *token = NULL; + char *sp = NULL; if (!devargs) return 0; @@ -236,14 +238,14 @@ qat_dev_parse_command_line(struct qat_pci_device *qat_dev, return -1; } strcpy(qat_dev->command_line, devargs->drv_str); - token = strtok(qat_dev->command_line, ","); + token = strtok_r(qat_dev->command_line, ",", &sp); while (token != NULL) { if (!cmdline_validate(token)) { QAT_LOG(ERR, "Incorrect command line argument: %s", token); return -1; } - token = strtok(NULL, ","); + token = strtok_r(NULL, ",", &sp); } /* Copy once againe the entire string, strtok already altered the contents */ strcpy(qat_dev->command_line, devargs->drv_str); -- 2.22.0