From: Stephen Hemminger <stephen@networkplumber.org>
To: Elena Agostini <eagostini@nvidia.com>
Cc: dev@dpdk.org
Subject: Re: [PATCH 0/2] gpudev: annotate memory allocation
Date: Fri, 8 Nov 2024 16:22:51 -0800 [thread overview]
Message-ID: <20241108162251.2bd99775@hermes.local> (raw)
In-Reply-To: <20241017225844.235401-1-stephen@networkplumber.org>
On Thu, 17 Oct 2024 15:58:02 -0700
Stephen Hemminger <stephen@networkplumber.org> wrote:
> Use function attributes to catch misuse of GPU memory
> at compile time.
>
> Stephen Hemminger (2):
> test-gpudev: avoid use-after-free and free-non-heap warnings
> gpudev: add malloc annotations to rte_gpu_mem_alloc
>
> app/test-gpudev/main.c | 10 ++++++++-
> lib/gpudev/rte_gpudev.h | 46 +++++++++++++++++++++--------------------
> 2 files changed, 33 insertions(+), 23 deletions(-)
>
The problem is that include checker can't handle this.
####################################################################################
#### [Begin job log] "ubuntu-22.04-gcc-debug+doc+examples+tests" at step Build and test
####################################################################################
from buildtools/chkincs/chkincs.p/gpudev_driver.c:1:
/home/runner/work/dpdk/dpdk/lib/gpudev/rte_gpudev.h:411:9: error: ‘rte_gpu_mem_free’ is deprecated: Symbol is not yet part of stable ABI [-Werror=deprecated-declarations]
411 | __rte_malloc __rte_dealloc(rte_gpu_mem_free, 2);
| ^~~~~~~~~~~~
/home/runner/work/dpdk/dpdk/lib/gpudev/rte_gpudev.h:380:5: note: declared here
380 | int rte_gpu_mem_free(int16_t dev_id, void *ptr);
| ^~~~~~~~~~~~~~~~
Either include checker needs to be able to handle experimental symbols
or maybe it is time for gpudev to be moved out experimental status for 25.03?
prev parent reply other threads:[~2024-11-09 0:22 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-17 22:58 Stephen Hemminger
2024-10-17 22:58 ` [PATCH 1/2] test-gpudev: avoid use-after-free and free-non-heap warnings Stephen Hemminger
2024-10-17 22:58 ` [PATCH 2/2] gpudev: add malloc annotations to rte_gpu_mem_alloc Stephen Hemminger
2024-10-28 19:01 ` [PATCH v2 0/2] gpudev: annotate memory allocation functions Stephen Hemminger
2024-10-28 19:01 ` [PATCH v2 1/2] test-gpudev: avoid use-after-free and free-non-heap warnings Stephen Hemminger
2024-10-28 19:01 ` [PATCH v2 2/2] gpudev: add malloc annotations to rte_gpu_mem_alloc Stephen Hemminger
2024-11-08 14:36 ` [PATCH v2 0/2] gpudev: annotate memory allocation functions David Marchand
2024-11-09 0:22 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241108162251.2bd99775@hermes.local \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=eagostini@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).