From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7547A45CB7; Sat, 9 Nov 2024 01:22:55 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 464F640268; Sat, 9 Nov 2024 01:22:55 +0100 (CET) Received: from mail-pg1-f172.google.com (mail-pg1-f172.google.com [209.85.215.172]) by mails.dpdk.org (Postfix) with ESMTP id 245C840263 for ; Sat, 9 Nov 2024 01:22:54 +0100 (CET) Received: by mail-pg1-f172.google.com with SMTP id 41be03b00d2f7-7e6d04f74faso2041554a12.1 for ; Fri, 08 Nov 2024 16:22:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1731111773; x=1731716573; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=GVrbB0UJOjlZ6frEA46LUb4PFCt4qMcyudRl2su3JOY=; b=sY+U233pT1YVB7WUD9bYrtoHhwQzTSaEBaWi06b34dmPRmnHFnZtaKIf/6BvzYH6pJ gvITE880VXAth66khPCKZ4tmUg9khPezTZd9CBC9sn9owW6kwl7TPJohlwI+/Hn3MAaj R+9lY3aI60g9j1N+S9kiQYyYmmDHPtWi+oyEugshoFLqow9cUFsNoHIoT7GxGviD/taK 229Emn/eUayRlvgtMpCm7c6jDfDwaExvxECwtoJfhFXks2wlIsKlGasf4+J9Xybr8wiP MRti7rmyM0T0N4WHJ+MSYNj1XhMTp4vNvFH0/L8HrBkxCBnugFOApv3l9VuhAk+1jEx+ UIsA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1731111773; x=1731716573; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=GVrbB0UJOjlZ6frEA46LUb4PFCt4qMcyudRl2su3JOY=; b=Bsmg4z4ivqAxhZyIlvccxMkwwJpT+PyJdOB+9l3IoINxR7hA+xKk4vu1V/FuhF15XZ FV/C0lvGMevZUUzOx4HRlxeTVzXdq1EvP476IsLC7hAECY6jYwjYVQd9zh4JNtUKG7XN 3CpJnHig/Giuw6Bd68ujVwvf8XLd0SRoyXfk5et1CdhMbn06QPVS8RcrqaRTdi9lqKZM aWxNfw7b0vm4bIYOGDZh5bJrA04/N66rRE9PGVROo2E2kQJBm7vDudqxnhbSQMclrG4o jrM/SyWrWpjUZhTkbZ5/wST6cWhRRjQABbfU9jQHbtU6DcSonYVgJPdhIbABKrbwLK1v 4HSA== X-Gm-Message-State: AOJu0Yw5+ETYTNxU/mc6qf42UehvI/2MmhYpR88xuP/DwG+F+YgtpUY3 8HUea/Cv9pWrC1F+EEdUo1mGgNmernaTaOY1TtRAxMp7Iha4cHRgXNVJ8DIqpAC+go+5AsENB2n J X-Google-Smtp-Source: AGHT+IH4yya3gGDJlfXsKTQtK/GGnwDxFJvyVXxaY67qMp0ITquns9iTHaSx4pwUiF3fgyL7lPvlkQ== X-Received: by 2002:a17:90b:2e48:b0:2e2:ada8:2986 with SMTP id 98e67ed59e1d1-2e9b1f8e28emr7243784a91.16.1731111773097; Fri, 08 Nov 2024 16:22:53 -0800 (PST) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-21177e416bdsm36643935ad.154.2024.11.08.16.22.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Nov 2024 16:22:52 -0800 (PST) Date: Fri, 8 Nov 2024 16:22:51 -0800 From: Stephen Hemminger To: Elena Agostini Cc: dev@dpdk.org Subject: Re: [PATCH 0/2] gpudev: annotate memory allocation Message-ID: <20241108162251.2bd99775@hermes.local> In-Reply-To: <20241017225844.235401-1-stephen@networkplumber.org> References: <20241017225844.235401-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, 17 Oct 2024 15:58:02 -0700 Stephen Hemminger wrote: > Use function attributes to catch misuse of GPU memory > at compile time. >=20 > Stephen Hemminger (2): > test-gpudev: avoid use-after-free and free-non-heap warnings > gpudev: add malloc annotations to rte_gpu_mem_alloc >=20 > app/test-gpudev/main.c | 10 ++++++++- > lib/gpudev/rte_gpudev.h | 46 +++++++++++++++++++++-------------------- > 2 files changed, 33 insertions(+), 23 deletions(-) >=20 The problem is that include checker can't handle this. ###########################################################################= ######### #### [Begin job log] "ubuntu-22.04-gcc-debug+doc+examples+tests" at step Bu= ild and test ###########################################################################= ######### from buildtools/chkincs/chkincs.p/gpudev_driver.c:1: /home/runner/work/dpdk/dpdk/lib/gpudev/rte_gpudev.h:411:9: error: =E2=80=98= rte_gpu_mem_free=E2=80=99 is deprecated: Symbol is not yet part of stable A= BI [-Werror=3Ddeprecated-declarations] 411 | __rte_malloc __rte_dealloc(rte_gpu_mem_free, 2); | ^~~~~~~~~~~~ /home/runner/work/dpdk/dpdk/lib/gpudev/rte_gpudev.h:380:5: note: declared h= ere 380 | int rte_gpu_mem_free(int16_t dev_id, void *ptr); | ^~~~~~~~~~~~~~~~ Either include checker needs to be able to handle experimental symbols or maybe it is time for gpudev to be moved out experimental status for 25.0= 3?