Re: [PATCH v10 0/6] power: refactor power management library

[Stephen Hemminger <stephen@networkplumber.org>]

On Sun, 10 Nov 2024 19:35:55 +0100
Thomas Monjalon <thomas@monjalon.net> wrote:

> 28/10/2024 20:55, Sivaprasad Tummala:
> > This patchset refactors the power management library, addressing both
> > core and uncore power management. The primary changes involve the
> > creation of dedicated directories for each driver within
> > 'drivers/power/core/*' and 'drivers/power/uncore/*'.
> > 
> > This refactor significantly improves code organization, enhances
> > clarity, and boosts maintainability. It lays the foundation for more
> > focused development on individual drivers and facilitates seamless
> > integration of future enhancements, particularly the AMD uncore driver.
> > 
> > Furthermore, this effort aims to streamline code maintenance by
> > consolidating common functions for cpufreq and cppc across various
> > core drivers, thus reducing code duplication.
> > 
> > Sivaprasad Tummala (6):
> >   power: refactor core power management library
> >   power: refactor uncore power management library
> >   test/power: removed function pointer validations
> >   drivers/power: uncore support for AMD EPYC processors
> >   maintainers: update for drivers/power
> >   power: rename library sources for cpu frequency management  
> 
> I'm a bit sad there is not more reviews.
> 
> I've moved the pointers check removal first,
> renamed intel_pstate files (not the functions),
> fixed few things like __cplusplus, include guards,
> sorting and maintainers file.
> 
> Applied
> 
> 

I think this broke the build. The next unrelated change in CI is failing.
Fixing the initialization in mlx5 patch failed.

-------------------------------BEGIN LOGS----------------------------
####################################################################################
#### [Begin job log] "ubuntu-22.04-gcc-stdatomic" at step Build and test
####################################################################################
Message: drivers/event/skeleton: Defining dependency "event_skeleton"
Message: drivers/event/sw: Defining dependency "event_sw"
Message: drivers/event/octeontx: Defining dependency "event_octeontx"
Run-time dependency flexran_sdk_ldpc_decoder_5gnr found: NO (tried pkgconfig and cmake)
Message: drivers/baseband/acc: Defining dependency "baseband_acc"
Message: drivers/baseband/fpga_5gnr_fec: Defining dependency "baseband_fpga_5gnr_fec"
Message: drivers/baseband/fpga_lte_fec: Defining dependency "baseband_fpga_lte_fec"
Message: drivers/baseband/la12xx: Defining dependency "baseband_la12xx"
Message: drivers/baseband/null: Defining dependency "baseband_null"
Run-time dependency flexran_sdk_turbo found: NO (tried pkgconfig and cmake)
Run-time dependency flexran_sdk_ldpc_decoder_5gnr found: NO (tried pkgconfig and cmake)
Message: drivers/baseband/turbo_sw: Defining dependency "baseband_turbo_sw"
Has header "cuda.h" : NO 
Message: drivers/power/acpi: Defining dependency "power_acpi"
Message: drivers/power/amd_pstate: Defining dependency "power_amd_pstate"
Library e_smi64 found: NO
Message: drivers/power/cppc: Defining dependency "power_cppc"
Message: drivers/power/intel_pstate: Defining dependency "power_intel_pstate"
Message: drivers/power/intel_uncore: Defining dependency "power_intel_uncore"
Message: drivers/power/kvm_vm: Defining dependency "power_kvm_vm"

drivers/meson.build:132:8: ERROR: Include dir power/pstate does not exist.

A full log can be found at /home/runner/work/dpdk/dpdk/build/meson-logs/meson-log.txt
##[error]Process completed with exit code 1.
####################################################################################
#### [End job log] "ubuntu-22.04-gcc-stdatomic" at step Build and test
####################################################################################