From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 079A245C7A; Sun, 10 Nov 2024 20:29:25 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9331B4027C; Sun, 10 Nov 2024 20:29:24 +0100 (CET) Received: from mail-pg1-f171.google.com (mail-pg1-f171.google.com [209.85.215.171]) by mails.dpdk.org (Postfix) with ESMTP id EEAD940151 for ; Sun, 10 Nov 2024 20:29:22 +0100 (CET) Received: by mail-pg1-f171.google.com with SMTP id 41be03b00d2f7-7ed9c16f687so2627481a12.0 for ; Sun, 10 Nov 2024 11:29:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1731266962; x=1731871762; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=ulOTFNR4TMSjkEQxpDmor3hlEXaUilwKN72bL0a/ZsQ=; b=JQcdesyiQHPWyqzAa7GfEMfL5bSD0I70jBcp6MrfStyVruuHyoNbXhzDB1H7TGDPMx PlfC7WWSA/bF63YPQhNBxJnyO3mmw+pZeXjsBZenwLVKa4PrhXg72fFGuD9zWprlvQ84 OaJESNv6AFzJcqIqLbgGDuwmd9bXf+3rAPZwxQ9etNzHIFUgAUk80D1ChqbnxkjIkFZm KskL/VCbvMfNGi2kEqafJJpsBbv39mHvNrhmwe3fNkWlFPb8zE8RNPU2gQEVIIDZVwsz lXWpAsoTKBiqzluJHGKhgrkfySUTAYvTOQ9+VGyWe0As797Wt/XFCZoprC2wnCXIblsK 3cyA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1731266962; x=1731871762; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ulOTFNR4TMSjkEQxpDmor3hlEXaUilwKN72bL0a/ZsQ=; b=KtS0diHYQr09oTu2W/VCByqvmQrslr93rC4nDRa5TwFnX6YN5bUxb7Lmwppm8EAKKt xwcIyOCuei2trIgkP7TjyHGOhYF3TIYLGuvczmoKr0Q1hMI4yIm04moymDiQvvMAam9H 8XvSZCbp5UhvuaEj4e9Gbje8yON3urbhG87IVfvzUnBJM/zJkoqtQ9oVlU7hcS91B/99 zBasIGNyzr4Fr1EM5RZnWte9I4Sivu5w4+foiwQLRBsyixtukc1lRY5rKigIt5J5ZcrD jlBJ6e1bFFOAJ3H2/IJ70/ppq6bcEcDUoH1wNZuSnZipZsS6BbKvXISgJBRTPPQIB2cj 4gsw== X-Forwarded-Encrypted: i=1; AJvYcCVIytXfL1RIBwxfXcQ3/NCZDXcD0S0CJTiYMGfa8c2C+LQQ6RoI9lxH5s84aGaUWfbqKZw=@dpdk.org X-Gm-Message-State: AOJu0Yy649LZ8MpQWBmqbRoRCczrytFMaUFjeiizSznG7lbsDUzzvOZu yAY9lSJfHfkXi+vJaV/kkpDX9dCJF6AqsR9RbGAcjAXv63bLVYxBf9hChkM/Nqs= X-Google-Smtp-Source: AGHT+IEmgxAfAiZDn2gsYSPPUajF51jus1vg1v78yqn/Jn6MBxq71IIwrUBkn0W1xp9ScdNQ7mC6kQ== X-Received: by 2002:a17:90b:1649:b0:2e2:bad3:e393 with SMTP id 98e67ed59e1d1-2e9b165642amr12894062a91.3.1731266961974; Sun, 10 Nov 2024 11:29:21 -0800 (PST) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2e99a541c95sm10200422a91.17.2024.11.10.11.29.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 10 Nov 2024 11:29:21 -0800 (PST) Date: Sun, 10 Nov 2024 11:29:19 -0800 From: Stephen Hemminger To: Thomas Monjalon Cc: Sivaprasad Tummala , david.hunt@intel.com, anatoly.burakov@intel.com, jerinj@marvell.com, radu.nicolau@intel.com, gakhil@marvell.com, cristian.dumitrescu@intel.com, lihuisong@huawei.com, ferruh.yigit@amd.com, konstantin.ananyev@huawei.com, dev@dpdk.org Subject: Re: [PATCH v10 0/6] power: refactor power management library Message-ID: <20241110112919.2afabde5@hermes.local> In-Reply-To: <5996777.Isy0gbHreE@thomas> References: <20241023051139.1066426-1-sivaprasad.tummala@amd.com> <20241028195556.450033-1-sivaprasad.tummala@amd.com> <5996777.Isy0gbHreE@thomas> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Sun, 10 Nov 2024 19:35:55 +0100 Thomas Monjalon wrote: > 28/10/2024 20:55, Sivaprasad Tummala: > > This patchset refactors the power management library, addressing both > > core and uncore power management. The primary changes involve the > > creation of dedicated directories for each driver within > > 'drivers/power/core/*' and 'drivers/power/uncore/*'. > > > > This refactor significantly improves code organization, enhances > > clarity, and boosts maintainability. It lays the foundation for more > > focused development on individual drivers and facilitates seamless > > integration of future enhancements, particularly the AMD uncore driver. > > > > Furthermore, this effort aims to streamline code maintenance by > > consolidating common functions for cpufreq and cppc across various > > core drivers, thus reducing code duplication. > > > > Sivaprasad Tummala (6): > > power: refactor core power management library > > power: refactor uncore power management library > > test/power: removed function pointer validations > > drivers/power: uncore support for AMD EPYC processors > > maintainers: update for drivers/power > > power: rename library sources for cpu frequency management > > I'm a bit sad there is not more reviews. > > I've moved the pointers check removal first, > renamed intel_pstate files (not the functions), > fixed few things like __cplusplus, include guards, > sorting and maintainers file. > > Applied > > I think this broke the build. The next unrelated change in CI is failing. Fixing the initialization in mlx5 patch failed. -------------------------------BEGIN LOGS---------------------------- #################################################################################### #### [Begin job log] "ubuntu-22.04-gcc-stdatomic" at step Build and test #################################################################################### Message: drivers/event/skeleton: Defining dependency "event_skeleton" Message: drivers/event/sw: Defining dependency "event_sw" Message: drivers/event/octeontx: Defining dependency "event_octeontx" Run-time dependency flexran_sdk_ldpc_decoder_5gnr found: NO (tried pkgconfig and cmake) Message: drivers/baseband/acc: Defining dependency "baseband_acc" Message: drivers/baseband/fpga_5gnr_fec: Defining dependency "baseband_fpga_5gnr_fec" Message: drivers/baseband/fpga_lte_fec: Defining dependency "baseband_fpga_lte_fec" Message: drivers/baseband/la12xx: Defining dependency "baseband_la12xx" Message: drivers/baseband/null: Defining dependency "baseband_null" Run-time dependency flexran_sdk_turbo found: NO (tried pkgconfig and cmake) Run-time dependency flexran_sdk_ldpc_decoder_5gnr found: NO (tried pkgconfig and cmake) Message: drivers/baseband/turbo_sw: Defining dependency "baseband_turbo_sw" Has header "cuda.h" : NO Message: drivers/power/acpi: Defining dependency "power_acpi" Message: drivers/power/amd_pstate: Defining dependency "power_amd_pstate" Library e_smi64 found: NO Message: drivers/power/cppc: Defining dependency "power_cppc" Message: drivers/power/intel_pstate: Defining dependency "power_intel_pstate" Message: drivers/power/intel_uncore: Defining dependency "power_intel_uncore" Message: drivers/power/kvm_vm: Defining dependency "power_kvm_vm" drivers/meson.build:132:8: ERROR: Include dir power/pstate does not exist. A full log can be found at /home/runner/work/dpdk/dpdk/build/meson-logs/meson-log.txt ##[error]Process completed with exit code 1. #################################################################################### #### [End job log] "ubuntu-22.04-gcc-stdatomic" at step Build and test ####################################################################################