[PATCH 0/2] Build with Gcc 15 fixes

[PATCH 0/2] Build with Gcc 15 fixes

[Stephen Hemminger]

Ferruh had fixed most of these, but a couple more crept in.
A couple more Gcc 15 fixes

Stephen Hemminger (2):
  net/dpaa2: fix build with Gcc 15
  net/mlx5: fix build with Gcc 15

 drivers/net/dpaa2/dpaa2_flow.c | 2 +-
 drivers/net/mlx5/mlx5_flow.c   | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

-- 
2.45.2

[PATCH 1/2] net/dpaa2: fix build with Gcc 15

[Stephen Hemminger]

Compiler no longer allows initializing byte array with string.
warning: initializer-string for array of ‘unsigned char’ is too long
	 [-Wunterminated-string-initialization]
  169 |         .vni = "\xff\xff\xff",
      |                ^~~~~~~~~~~~~~

Fixes: 39c8044ffb7b ("net/dpaa2: support VXLAN flow matching")
Cc: jun.yang@nxp.com

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
 drivers/net/dpaa2/dpaa2_flow.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/dpaa2/dpaa2_flow.c b/drivers/net/dpaa2/dpaa2_flow.c
index cfbcb29df1..de850ae0cf 100644
--- a/drivers/net/dpaa2/dpaa2_flow.c
+++ b/drivers/net/dpaa2/dpaa2_flow.c
@@ -166,7 +166,7 @@ static const struct rte_flow_item_gre dpaa2_flow_item_gre_mask = {
 
 static const struct rte_flow_item_vxlan dpaa2_flow_item_vxlan_mask = {
 	.flags = 0xff,
-	.vni = "\xff\xff\xff",
+	.vni = { 0xff, 0xff, 0xff },
 };
 
 static const struct rte_flow_item_ecpri dpaa2_flow_item_ecpri_mask = {
-- 
2.45.2

Re: [PATCH 1/2] net/dpaa2: fix build with Gcc 15

[Ferruh Yigit]

On 11/10/2024 6:41 PM, Stephen Hemminger wrote:
> Compiler no longer allows initializing byte array with string.
> warning: initializer-string for array of ‘unsigned char’ is too long
> 	 [-Wunterminated-string-initialization]
>   169 |         .vni = "\xff\xff\xff",
>       |                ^~~~~~~~~~~~~~
> 
> Fixes: 39c8044ffb7b ("net/dpaa2: support VXLAN flow matching")
> Cc: jun.yang@nxp.com
> 
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
>

Acked-by: Ferruh Yigit <ferruh.yigit@amd.com>

Applied to dpdk-next-net/main, thanks.

[PATCH 2/2] net/mlx5: fix build with Gcc 15

[Stephen Hemminger]

Fixes warnings from Gcc 15 about using string for initialization.
../drivers/net/mlx5/mlx5_flow.c: In function ‘mlx5_legacy_dmac_flow_create’:
../drivers/net/mlx5/mlx5_flow.c:8568:44: warning: initializer-string for array of ‘unsigned char’ is too long [-Wunterminated-string-initialization]
 8568 |                 .hdr.dst_addr.addr_bytes = "\xff\xff\xff\xff\xff\xff",
      |                                            ^~~~~~~~~~~~~~~~~~~~~~~~~~
../drivers/net/mlx5/mlx5_flow.c: In function ‘mlx5_legacy_dmac_vlan_flow_create’:
../drivers/net/mlx5/mlx5_flow.c:8583:44: warning: initializer-string for array of ‘unsigned char’ is too long [-Wunterminated-string-initialization]
 8583 |                 .hdr.dst_addr.addr_bytes = "\xff\xff\xff\xff\xff\xff",
      |                                            ^~~~~~~~~~~~~~~~~~~~~~~~~~

Fixes: cf99567fe566 ("net/mlx5: add legacy unicast flow rules management")
Cc: dsosnowski@nvidia.com

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
 drivers/net/mlx5/mlx5_flow.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c
index 9c43201e05..f8cfa661ec 100644
--- a/drivers/net/mlx5/mlx5_flow.c
+++ b/drivers/net/mlx5/mlx5_flow.c
@@ -8565,7 +8565,7 @@ mlx5_legacy_dmac_flow_create(struct rte_eth_dev *dev, const struct rte_ether_add
 		.hdr.dst_addr = *addr,
 	};
 	struct rte_flow_item_eth unicast_mask = {
-		.hdr.dst_addr.addr_bytes = "\xff\xff\xff\xff\xff\xff",
+		.hdr.dst_addr.addr_bytes = { 0xff, 0xff, 0xff, 0xff, 0xff, 0xff },
 	};
 
 	return mlx5_ctrl_flow(dev, &unicast, &unicast_mask);
@@ -8580,7 +8580,7 @@ mlx5_legacy_dmac_vlan_flow_create(struct rte_eth_dev *dev,
 		.hdr.dst_addr = *addr,
 	};
 	struct rte_flow_item_eth unicast_mask = {
-		.hdr.dst_addr.addr_bytes = "\xff\xff\xff\xff\xff\xff",
+		.hdr.dst_addr.addr_bytes = { 0xff, 0xff, 0xff, 0xff, 0xff, 0xff },
 	};
 	struct rte_flow_item_vlan vlan_spec = {
 		.hdr.vlan_tci = rte_cpu_to_be_16(vid),
-- 
2.45.2

Re: [PATCH 2/2] net/mlx5: fix build with Gcc 15

[Ferruh Yigit]

On 11/10/2024 6:41 PM, Stephen Hemminger wrote:
> Fixes warnings from Gcc 15 about using string for initialization.
> ../drivers/net/mlx5/mlx5_flow.c: In function ‘mlx5_legacy_dmac_flow_create’:
> ../drivers/net/mlx5/mlx5_flow.c:8568:44: warning: initializer-string for array of ‘unsigned char’ is too long [-Wunterminated-string-initialization]
>  8568 |                 .hdr.dst_addr.addr_bytes = "\xff\xff\xff\xff\xff\xff",
>       |                                            ^~~~~~~~~~~~~~~~~~~~~~~~~~
> ../drivers/net/mlx5/mlx5_flow.c: In function ‘mlx5_legacy_dmac_vlan_flow_create’:
> ../drivers/net/mlx5/mlx5_flow.c:8583:44: warning: initializer-string for array of ‘unsigned char’ is too long [-Wunterminated-string-initialization]
>  8583 |                 .hdr.dst_addr.addr_bytes = "\xff\xff\xff\xff\xff\xff",
>       |                                            ^~~~~~~~~~~~~~~~~~~~~~~~~~
> 
> Fixes: cf99567fe566 ("net/mlx5: add legacy unicast flow rules management")
> Cc: dsosnowski@nvidia.com
> 
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
>

Dariusz already sent a fix before, will get it:
https://patches.dpdk.org/project/dpdk/patch/20241108160724.730989-1-dsosnowski@nvidia.com/

RE: [PATCH 0/2] Build with Gcc 15 fixes

[Morten Brørup]

For the series,
Reviewed-by: Morten Brørup <mb@smartsharesystems.com>