* [PATCH] bus/fslmc: fix bus scan return failure value
@ 2024-11-11 10:26 Hemant Agrawal
2024-11-11 11:00 ` Thomas Monjalon
0 siblings, 1 reply; 2+ messages in thread
From: Hemant Agrawal @ 2024-11-11 10:26 UTC (permalink / raw)
To: dev, thomas, stephen; +Cc: Hemant Agrawal
fslmc bus will not be available on non DPAA2 platform.
Do not return error on scan failure.
Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>
---
drivers/bus/fslmc/fslmc_bus.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/bus/fslmc/fslmc_bus.c b/drivers/bus/fslmc/fslmc_bus.c
index 17b3b6156c..68ad2b801e 100644
--- a/drivers/bus/fslmc/fslmc_bus.c
+++ b/drivers/bus/fslmc/fslmc_bus.c
@@ -243,8 +243,6 @@ rte_fslmc_parse(const char *name, void *addr)
uint8_t sep_exists = 0;
int ret = -1;
- DPAA2_BUS_DEBUG("Parsing dev=(%s)", name);
-
/* There are multiple ways this can be called, with bus:dev, name=dev
* or just dev. In all cases, the 'addr' is actually a string.
*/
@@ -329,7 +327,8 @@ rte_fslmc_scan(void)
group_name = getenv("DPRC");
if (!group_name) {
DPAA2_BUS_DEBUG("DPAA2: DPRC not available");
- return -EINVAL;
+ ret = -EINVAL;
+ goto scan_fail;
}
ret = fslmc_get_container_group(group_name, &groupid);
--
2.25.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] bus/fslmc: fix bus scan return failure value
2024-11-11 10:26 [PATCH] bus/fslmc: fix bus scan return failure value Hemant Agrawal
@ 2024-11-11 11:00 ` Thomas Monjalon
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Monjalon @ 2024-11-11 11:00 UTC (permalink / raw)
To: Hemant Agrawal; +Cc: dev, stephen
11/11/2024 11:26, Hemant Agrawal:
> fslmc bus will not be available on non DPAA2 platform.
> Do not return error on scan failure.
>
> Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>
Fixes: 57cb02edf122 ("bus/fslmc: enhance MC VFIO multi-process support")
Applied, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-11-11 11:00 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-11-11 10:26 [PATCH] bus/fslmc: fix bus scan return failure value Hemant Agrawal
2024-11-11 11:00 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).