From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 91DF345C9B; Wed, 13 Nov 2024 00:09:36 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 71800402BC; Wed, 13 Nov 2024 00:09:36 +0100 (CET) Received: from mail-pf1-f176.google.com (mail-pf1-f176.google.com [209.85.210.176]) by mails.dpdk.org (Postfix) with ESMTP id 362CA40265 for ; Wed, 13 Nov 2024 00:09:35 +0100 (CET) Received: by mail-pf1-f176.google.com with SMTP id d2e1a72fcca58-71e467c3996so5116955b3a.2 for ; Tue, 12 Nov 2024 15:09:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1731452974; x=1732057774; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=U352K6RXuS5sRk8Acl17x00HydUGBNTaX2JEdOfMeFk=; b=j048XKPhKkqUfU23yDh4TnFVtP7lLWyDydCPL3ish8AFUnLIOv3cybhqpvn0vUIX51 F/Uz5qwc3KuXuiB8ycIbIfWyrkp9bRD8dLn6d817bIN+a1B6b1HrWkJ+QzUFZn8hKL9L 62fpzX6t2rLZiC325xP5JY9JNHZ8PjJHcfSx2Gd4WksesqAapVG8oZuE6ngf96F6IC2S 7otrWNd9S24+DWXBNlANKdaIcB7oM8/jX+8CLiEjjKAg4NXgkdIhsjKHiGQbIFp9zowi bFZxs2u01MUU02DOTJR/Hy00uoNLQlSxWUW6vN0javwXWDf+MbnhzyOGeEuvuhmhqomJ QYLA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1731452974; x=1732057774; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=U352K6RXuS5sRk8Acl17x00HydUGBNTaX2JEdOfMeFk=; b=Zj/5fHH8Uc0iO5LzZAFoG5McRcV/asPpsMo5HpNiZvm7ZX9UL6zaIfWMI1WoibRXaZ UxgKrKTGYEd9ip09x2nBjLVRWfvYh9UfhVV4VP9HVp3wYmsieZ2EqZj8nzDkJsfi0uRa XbFsySlx6NXsvoSLHvz4y4Oe7G+y5X5grdFTt2xLGskifxkVCiydnGXhKW8eSNPZkAXh tJekjs+n6DY6yfVQnPJGXvTn9yIXzlPeRwnQ+rbVHNJwQZkOrg4HoowhzyOliY1VCDsx nJUDpG9xJYiZWip0axnZd5LGi9kyG7k0kx17BCF8RLOptI4sJ3f6ACbXsKz0DQY9zKmy ktRA== X-Forwarded-Encrypted: i=1; AJvYcCVdz68E4Xo2VS2Bi2AD1ecPB5WlYNFdVX8xYEEPb1S+ZHNH227Cu5dPdjrkCCluBqLyE6Y=@dpdk.org X-Gm-Message-State: AOJu0YyRqbEpkn1J8ZBBqac31kqMvj6EdpFNyh+F+22VqfLGC+iSOPbz ZpTt2b2Eq/dWhGZD1o1EbcOUgZIIxkjOEAJQ5kMwBcuwpo+4cVdoT6uX1juRibs= X-Google-Smtp-Source: AGHT+IHr1/eMgVkqHgkvhzFsdsr+ZHHFCzMp/kPkOWLLKmu4Fnnvg16yk2sWQJpb9pINzM1cspZWVg== X-Received: by 2002:a05:6a00:803:b0:717:9154:b5d6 with SMTP id d2e1a72fcca58-7241338b585mr24106794b3a.22.1731452974283; Tue, 12 Nov 2024 15:09:34 -0800 (PST) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-72407a1a87bsm11626987b3a.158.2024.11.12.15.09.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Nov 2024 15:09:34 -0800 (PST) Date: Tue, 12 Nov 2024 15:09:32 -0800 From: Stephen Hemminger To: Tomasz Duszynski Cc: Jerin Jacob , "Sunil Kumar Kori" , Tyler Retzlaff , , , , , , , , , Subject: Re: [PATCH v15 4/4] eal: add PMU support to tracing library Message-ID: <20241112150932.619e417d@hermes.local> In-Reply-To: <20241025085414.3412068-5-tduszynski@marvell.com> References: <20241011094944.3586051-1-tduszynski@marvell.com> <20241025085414.3412068-1-tduszynski@marvell.com> <20241025085414.3412068-5-tduszynski@marvell.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, 25 Oct 2024 10:54:14 +0200 Tomasz Duszynski wrote: > In order to profile app one needs to store significant amount of samples > somewhere for an analysis later on. Since trace library supports > storing data in a CTF format lets take advantage of that and add a > dedicated PMU tracepoint. >=20 > Signed-off-by: Tomasz Duszynski > --- > app/test/test_trace_perf.c | 10 ++++ > doc/guides/prog_guide/profile_app.rst | 5 ++ > doc/guides/prog_guide/trace_lib.rst | 32 +++++++++++ > lib/eal/common/eal_common_trace.c | 5 +- > lib/eal/common/eal_common_trace_pmu.c | 38 ++++++++++++++ > lib/eal/common/eal_common_trace_points.c | 5 ++ > lib/eal/common/eal_trace.h | 4 ++ > lib/eal/common/meson.build | 1 + > lib/eal/include/rte_eal_trace.h | 11 ++++ > lib/eal/version.map | 1 + > lib/pmu/rte_pmu.c | 67 +++++++++++++++++++++++- > lib/pmu/rte_pmu.h | 24 +++++++-- > lib/pmu/version.map | 1 + > 13 files changed, 198 insertions(+), 6 deletions(-) > create mode 100644 lib/eal/common/eal_common_trace_pmu.c There is an issue with calling a rte_experimental function. -------------------------------BEGIN LOGS---------------------------- ###########################################################################= ######### #### [Begin job log] "ubuntu-22.04-gcc-debug+doc+examples+tests" at step Bu= ild and test ###########################################################################= ######### [3384/6468] Compiling C object buildtools/chkincs/chkincs.p/meson-generated= _rte_pmu.c.o FAILED: buildtools/chkincs/chkincs.p/meson-generated_rte_pmu.c.o=20 ccache gcc -Ibuildtools/chkincs/chkincs.p -Ibuildtools/chkincs -I../buildto= ols/chkincs -Iexamples/l3fwd -I../examples/l3fwd -I../examples/common -Idri= vers/bus/vdev -I../drivers/bus/vdev -I. -I.. -Iconfig -I../config -Ilib/eal= /include -I../lib/eal/include -Ilib/eal/linux/include -I../lib/eal/linux/in= clude -Ilib/eal/x86/include -I../lib/eal/x86/include -Ilib/eal/common -I../= lib/eal/common -Ilib/eal -I../lib/eal -Ilib/kvargs -I../lib/kvargs -Ilib/lo= g -I../lib/log -Ilib/metrics -I../lib/metrics -Ilib/telemetry -I../lib/tele= metry -Ilib/pmu -I../lib/pmu -Idrivers/bus/pci -I../drivers/bus/pci -I../dr= ivers/bus/pci/linux -Ilib/pci -I../lib/pci -Idrivers/bus/vmbus -I../drivers= /bus/vmbus -I../drivers/bus/vmbus/linux -Ilib/argparse -I../lib/argparse -I= lib/ptr_compress -I../lib/ptr_compress -Ilib/ring -I../lib/ring -Ilib/rcu -= I../lib/rcu -Ilib/mempool -I../lib/mempool -Ilib/mbuf -I../lib/mbuf -Ilib/n= et -I../lib/net -Ilib/meter -I../lib/meter -Ilib/ethdev -I../lib/ethdev -Il= ib/cmdline -I../lib/cmdline -Ilib/hash -I../lib/hash -Ilib/timer -I../lib/t= imer -Ilib/acl -I../lib/acl -Ilib/bbdev -I../lib/bbdev -Ilib/bitratestats -= I../lib/bitratestats -Ilib/bpf -I../lib/bpf -Ilib/cfgfile -I../lib/cfgfile = -Ilib/compressdev -I../lib/compressdev -Ilib/cryptodev -I../lib/cryptodev -= Ilib/distributor -I../lib/distributor -Ilib/dmadev -I../lib/dmadev -Ilib/ef= d -I../lib/efd -Ilib/eventdev -I../lib/eventdev -Ilib/dispatcher -I../lib/d= ispatcher -Ilib/gpudev -I../lib/gpudev -Ilib/gro -I../lib/gro -Ilib/gso -I.= ./lib/gso -Ilib/ip_frag -I../lib/ip_frag -Ilib/jobstats -I../lib/jobstats -= Ilib/latencystats -I../lib/latencystats -Ilib/lpm -I../lib/lpm -Ilib/member= -I../lib/member -Ilib/pcapng -I../lib/pcapng -Ilib/power -I../lib/power -I= lib/rawdev -I../lib/rawdev -Ilib/regexdev -I../lib/regexdev -Ilib/mldev -I.= ./lib/mldev -Ilib/rib -I../lib/rib -Ilib/reorder -I../lib/reorder -Ilib/sch= ed -I../lib/sched -Ilib/security -I../lib/security -Ilib/stack -I../lib/sta= ck -Ilib/vhost -I../lib/vhost -Ilib/ipsec -I../lib/ipsec -Ilib/pdcp -I../li= b/pdcp -Ilib/fib -I../lib/fib -Ilib/port -I../lib/port -Ilib/pdump -I../lib= /pdump -Ilib/table -I../lib/table -Ilib/pipeline -I../lib/pipeline -Ilib/gr= aph -I../lib/graph -Ilib/node -I../lib/node -fdiagnostics-color=3Dalways -p= ipe -D_FILE_OFFSET_BITS=3D64 -Wall -Winvalid-pch -Wextra -Werror -std=3Dc11= -g -include rte_config.h -Wcast-qual -Wdeprecated -Wformat -Wformat-nonlit= eral -Wformat-security -Wmissing-declarations -Wmissing-prototypes -Wnested= -externs -Wold-style-definition -Wpointer-arith -Wsign-compare -Wstrict-pro= totypes -Wundef -Wwrite-strings -Wno-address-of-packed-member -Wno-packed-n= ot-aligned -Wno-missing-field-initializers -D_GNU_SOURCE -march=3Dcorei7 -m= rtm -MD -MQ buildtools/chkincs/chkincs.p/meson-generated_rte_pmu.c.o -MF bu= ildtools/chkincs/chkincs.p/meson-generated_rte_pmu.c.o.d -o buildtools/chki= ncs/chkincs.p/meson-generated_rte_pmu.c.o -c buildtools/chkincs/chkincs.p/r= te_pmu.c In file included from buildtools/chkincs/chkincs.p/rte_pmu.c:1: /home/runner/work/dpdk/dpdk/lib/pmu/rte_pmu.h: In function =E2=80=98rte_pmu= _read=E2=80=99: /home/runner/work/dpdk/dpdk/lib/pmu/rte_pmu.h:214:17: error: =E2=80=98__rte= _pmu_enable_group=E2=80=99 is deprecated: Symbol is not yet part of stable = ABI [-Werror=3Ddeprecated-declarations] 214 | ret =3D __rte_pmu_enable_group(group); | ^~~ /home/runner/work/dpdk/dpdk/lib/pmu/rte_pmu.h:132:1: note: declared here 132 | __rte_pmu_enable_group(struct rte_pmu_event_group *group); | ^~~~~~~~~~~~~~~~~~~~~~ /home/runner/work/dpdk/dpdk/lib/pmu/rte_pmu.h:222:9: error: =E2=80=98__rte_= pmu_read_userpage=E2=80=99 is deprecated: Symbol is not yet part of stable = ABI [-Werror=3Ddeprecated-declarations] 222 | return __rte_pmu_read_userpage(group->mmap_pages[index]); | ^~~~~~ /home/runner/work/dpdk/dpdk/lib/pmu/rte_pmu.h:86:1: note: declared here 86 | __rte_pmu_read_userpage(struct perf_event_mmap_page *pc) | ^~~~~~~~~~~~~~~~~~~~~~~ cc1: all warnings being treated as errors [3385/6468] Compiling C object buildtools/chkincs/chkincs.p/meson-generated= _rte_byteorder.c.o [3386/6468] Compiling C object buildtools/chkincs/chkincs.p/meson-generated= _rte_atomic.c.o [3387/6468] Compiling C object buildtools/chkincs/chkincs.p/meson-generated= _rte_rtm.c.o [3388/6468] Compiling C object buildtools/chkincs/chkincs.p/meson-generated= _rte_memcpy.c.o [3389/6468] Compiling C object app/dpdk-test.p/test_test_memcpy_perf.c.o ninja: build stopped: subcommand failed. ##[error]Process completed with exit code 1.