From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A1AE345C7A; Tue, 12 Nov 2024 18:46:31 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C99114060F; Tue, 12 Nov 2024 18:46:28 +0100 (CET) Received: from mail-pf1-f178.google.com (mail-pf1-f178.google.com [209.85.210.178]) by mails.dpdk.org (Postfix) with ESMTP id 0A49B40144 for ; Tue, 12 Nov 2024 18:46:25 +0100 (CET) Received: by mail-pf1-f178.google.com with SMTP id d2e1a72fcca58-724455f40a0so1311440b3a.0 for ; Tue, 12 Nov 2024 09:46:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1731433585; x=1732038385; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=lusHcHOwydUriP2pBeI9+1i/AgKnXz6R7X8oX7ODWCw=; b=Sc2Oz4+DEhNMuDu2wx5fj3yXUUcT8jIuQvUypfljbuuZPl54A1Yz2oaUtgY0F/NSpa VjY1+bNs4vEUWxqImPJW3+xXzh7fElWhBYq/7IO1LfXgXr0deorXsjhBsMTKVNKxpyp2 65lHKJcEo0Au9hYenDhyvB2tuJmBrcPtrYWXfxkKLbogXOGcFCWc46moZeCGyV5Vno3y xgIJklFzAccI/+iIcPFFmb4z3B3OmSZNfdWb1MkFGAakSCDfOohTAVOoEYgaUb6xQEHV h5wqfyOx/y4JnNQs2yXpXc5yTudSx+iz6nIGR1a13TsbMIxWB/wsZGKv1RIbl/WQQWOg uIDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1731433585; x=1732038385; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=lusHcHOwydUriP2pBeI9+1i/AgKnXz6R7X8oX7ODWCw=; b=N6BK8+EUnAW0FJDdWREqfHJD59mvIYGkA9kpq4FqC64V4kRcgaV/9Gg1TY26+vCvv3 E09MArEaPulinjFnIRboNlpt4pluCs4mJOOprY+00VSnguUXrftMQKQaq7shWxrUgFaV VFenGZ99RBk1wma8w0tWlBnKS8BO4zJ6TIEFtPc63VLB/Hkcvszv+Wy0wsWDkXNCMz4D UzZo8O+QqAfaInhDC2MFOo6P+Zj2cRdgxe1uO4SRiYpClC3mb8OcWpYnzXHITdt/tjaM JSYkUzOiZe3p6ArdmdlXIxahVcwSTfoB2ys77qDuKMXjzqV7XDMglmaw2SHI4VrvCmXj nOhQ== X-Gm-Message-State: AOJu0YyPxtZxMpnHgGNQ92gPv3o9RLagNbp/xam5C5N4DASO+W8kPEIW 8uRI/eUMFhFIbIG3Kt1E9mW+QouXE4QprXj5E9eX9WCeX1qrnY0LKk2U7x3qvABqwl3rYTFHKWR nSEA= X-Google-Smtp-Source: AGHT+IE7xppC84mmvKlame0T1QvPkOMwNNBvnFRS1nt6yZmgtAzGvyTdOiJUOsl+C9pTTeEYBLJG5w== X-Received: by 2002:a05:6a00:3a07:b0:71e:7b8a:5953 with SMTP id d2e1a72fcca58-7241338bdecmr24436501b3a.24.1731433585025; Tue, 12 Nov 2024 09:46:25 -0800 (PST) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-72407863dd8sm11846758b3a.26.2024.11.12.09.46.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Nov 2024 09:46:24 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Julien Aube , Harish Patil Subject: [PATCH 1/4] net/bnx2x: remove dead conditional Date: Tue, 12 Nov 2024 09:43:53 -0800 Message-ID: <20241112174613.326565-2-stephen@networkplumber.org> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20241112174613.326565-1-stephen@networkplumber.org> References: <20241112174613.326565-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org The second if test here is impossible because it contradicts previous line. Coverity issue: 384428 Fixes: 540a211084a7 ("bnx2x: driver core") Signed-off-by: Stephen Hemminger --- drivers/net/bnx2x/bnx2x_stats.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/net/bnx2x/bnx2x_stats.c b/drivers/net/bnx2x/bnx2x_stats.c index d473c5e7ec..8adbe7e381 100644 --- a/drivers/net/bnx2x/bnx2x_stats.c +++ b/drivers/net/bnx2x/bnx2x_stats.c @@ -73,9 +73,6 @@ bnx2x_storm_stats_post(struct bnx2x_softc *sc) int rc; if (!sc->stats_pending) { - if (sc->stats_pending) - return; - sc->fw_stats_req->hdr.drv_stats_counter = htole16(sc->stats_counter++); -- 2.45.2