From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2910945CFA; Wed, 13 Nov 2024 20:39:13 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AC745406B8; Wed, 13 Nov 2024 20:39:12 +0100 (CET) Received: from mail-pl1-f170.google.com (mail-pl1-f170.google.com [209.85.214.170]) by mails.dpdk.org (Postfix) with ESMTP id 88246406B8 for ; Wed, 13 Nov 2024 20:39:10 +0100 (CET) Received: by mail-pl1-f170.google.com with SMTP id d9443c01a7336-20cdb889222so73347545ad.3 for ; Wed, 13 Nov 2024 11:39:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1731526749; x=1732131549; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=DOHAiz+imKxo2ZEeuyhdpmUyAsEr91ZghYzMcD5lfXI=; b=kwUk43626KIn0jJI2h/250QgfmL5jzJiG5qPVZ17XCpbN6ejhoIIGD58T1G2PXE7vA gVIdMDrLLX1yXEEhXYwYxxBWyILwfRdgFBNH8E26neg1q25QNUjIfqMsrI8OYJNzdTeU qGrlf9AhxOs8mMSXqhB6bCRpQQXQcaXLPqV5zrck9zLUxcYr1dx/Su5ZrNs1UccHu/p8 eHNC6iRE2646MlNsrLQytqNkJmXnvmGlhMYVgJbbuKgU69JynOK0UBuPRebiGnYrh7Sw 1NrdpUCRBX8noyw5zpLIJpX46XxXdU7lpC9/QJIHQGDGWZTgj2syG3IjSJRJVAjya1Iv EVsw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1731526749; x=1732131549; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=DOHAiz+imKxo2ZEeuyhdpmUyAsEr91ZghYzMcD5lfXI=; b=FzP9yaExoQdH2bLO+1aY2fS7u7GcS4sSovYXs8iIZqvqa/jkDWoUTmnESHPVtInmZl 83z9KdubN/H1HLsWo16cu93Ag0f3Xe7ab6SnlL/MmGTddt16i93fp4JSMcMjrUG1EUMI dwS3gn27AcdFNwnlZrh4uOKzZgckAY+JH2Eu8z9JyEbH+qeFKkF/3e4YDRa7ZmWxg5Nz QabL3uPJRjt0XHtLTf1p4zDAg0fiBeMdBU930xUkkS8wP/qZUIz3jihAnuD2BTbnHfJd +TBT/JwdYgENTnNqOyKHa7mF9D+t8FGx3W0FTdAqZ4giULinmgw814653c/4y7HpQ1Vd rdmQ== X-Gm-Message-State: AOJu0YyahhVU4VLUrqiDVId6CUuIk9ss9gZzSADk86+EKmgB9yZQMC6G fQmJ8tmBJNTOx9ySoIH/4ZC6yxz4tXFmQDzhKIAFtTydtcMzRvjsh687vrYpSKk= X-Google-Smtp-Source: AGHT+IG/ZpUYopQIOBGpdt+Qnd4zeBhMqHLsjTBeNlRYAb17hLl84a4fnBIujX68TcoQp1+NL32UbQ== X-Received: by 2002:a17:902:f7c3:b0:20c:f261:2516 with SMTP id d9443c01a7336-211b5bcc4f2mr39091025ad.8.1731526749560; Wed, 13 Nov 2024 11:39:09 -0800 (PST) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-21177e49bafsm113069695ad.140.2024.11.13.11.39.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Nov 2024 11:39:09 -0800 (PST) Date: Wed, 13 Nov 2024 11:39:07 -0800 From: Stephen Hemminger To: Gagandeep Singh Cc: dev@dpdk.org Subject: Re: [v2 3/3] examples/l3fwd: enhance valid ports checking Message-ID: <20241113113907.62b4cafe@hermes.local> In-Reply-To: <20240806034120.3165295-4-g.singh@nxp.com> References: <20240715101458.645014-1-g.singh@nxp.com> <20240806034120.3165295-1-g.singh@nxp.com> <20240806034120.3165295-4-g.singh@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, 6 Aug 2024 09:11:20 +0530 Gagandeep Singh wrote: > The current port ID validation logic in the routes add code has > two issues: > > - It can pass if port ID in route is 31+. > - It silently skips rules with disabled or invalid > port IDs > > This patch is: > - Improving the enabled port IDs check logic. > - Introducing a user option, "exit_on_failure", to control > the behavior when attempting to add rules for disabled or > invalid port IDs (either exit or skip) > - Creating a port ID validation function for use across > various setup functions > > Signed-off-by: Gagandeep Singh Patch looks fine, but other changes in the intervening time have caused conflicts with this patch. Needs to be rebased.