From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CDF5845CF9; Wed, 13 Nov 2024 19:58:03 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BA82D41140; Wed, 13 Nov 2024 19:57:39 +0100 (CET) Received: from mail-pf1-f176.google.com (mail-pf1-f176.google.com [209.85.210.176]) by mails.dpdk.org (Postfix) with ESMTP id 32BEB40E4F for ; Wed, 13 Nov 2024 19:57:35 +0100 (CET) Received: by mail-pf1-f176.google.com with SMTP id d2e1a72fcca58-720b2d8bcd3so5994912b3a.2 for ; Wed, 13 Nov 2024 10:57:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1731524254; x=1732129054; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=IzMrfQ1uQqOrLfACKv9cfd36bC5HKr+gi0POyVHNIlU=; b=Xq507k5Xi8PwHKJNBsZOZy1VT+ZOL++HF1kTM0WIAB+s6WHHRTnBjirDyHIg0TZv98 2bubNjMyfRTc2P47SRUCSkf+LzZXjalWFEpUaSIO5CI8TZ48+c8S+oxhCyxaJBxCKnKV Z0c1tmS9ZpqkaiWoRbE7dxQ535wr/vnjRyBTVykK/e/2w/AeHdtuJWhn0REoms1c/W3c 2oUXh/S+kt+NN5QLbp+BwYOSxPLrcTD0goOPfWtkt1bTPb6DRZ3PE7C1X+nQPSFzkHZ8 Dlp4KrJL2RjdEDXrLsDOohB1wd5fFDymnAwCmWLo9bq21jBkTHkWqKRBEidXcYVTPoYb oKeg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1731524254; x=1732129054; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=IzMrfQ1uQqOrLfACKv9cfd36bC5HKr+gi0POyVHNIlU=; b=pzMkoUKemKO0+vuJtFx5onvqUVpR6DqCGHacDH2UDik9fZ9EO0jwcmEDOb0H31M5HD MHxofZTiwzRxQ5ocu3c5fe30Hl4vnxsfBVU6/B9yqPaRcvbxgaEayjrRBDxbsNycY/jF Y/QQxsb756CO8y34kHRHP78urPSE8/d0B4cf6cU00TWPJ16sXnyLSq5dg1UDOIxdI8RT kVWyCOx2dAx22/CKmVgHzKfs3/K1EY+e3X8wvbe9/AGgo4X7FP/X2PFwJg0CBHHemwQ6 Si5rhJ6gfC9hf0ztW54n1aOcNPxvDqoLJER5SpOr9T1mCNgBmMfC1/6c1PrBvydP5ycf cNYw== X-Gm-Message-State: AOJu0Yz0XNFR8U78FGMOduWhCZ5zbyMDQI9ebQ30XhsanUfDkJu4raZh qvtvYfLU/d3+xcNrip4pucl6zIk5iNH34QNbN9DrQXTFR3Cv9ubzA/ZWZMfIAxLXJrMHT92fsxV a X-Google-Smtp-Source: AGHT+IHSOEMd7J39iIC5HMCw5np2t/d+kQ3GWcKh1awmGqLaJv37VROnTfKI6VgteCFqcB9u/Om2Lw== X-Received: by 2002:a17:90b:4b4f:b0:2e1:e19f:609b with SMTP id 98e67ed59e1d1-2e9b177fc81mr28384305a91.24.1731524254443; Wed, 13 Nov 2024 10:57:34 -0800 (PST) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2e9f3e977d7sm1817935a91.8.2024.11.13.10.57.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Nov 2024 10:57:34 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger Subject: [RFC 5/5] test: remove unneeded memset Date: Wed, 13 Nov 2024 10:56:04 -0800 Message-ID: <20241113185720.28706-6-stephen@networkplumber.org> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20241113185720.28706-1-stephen@networkplumber.org> References: <20241113185720.28706-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Since tmp is not used later in the function, this memset is unnecessary. Even though this is harmless, it causes tools that look for security issues around memset to flag this a bug. Signed-off-by: Stephen Hemminger --- app/test/test_cmdline_cirbuf.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/app/test/test_cmdline_cirbuf.c b/app/test/test_cmdline_cirbuf.c index 8ac326cb02..1be357abf6 100644 --- a/app/test/test_cmdline_cirbuf.c +++ b/app/test/test_cmdline_cirbuf.c @@ -281,8 +281,6 @@ test_cirbuf_string_add_del_reverse(void) printf("Error: buffer should have been empty!\n"); return -1; } - /* clear tmp buffer */ - memset(tmp, 0, sizeof(tmp)); /* * reinitialize circular buffer -- 2.45.2