From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B8B4045CFB; Thu, 14 Nov 2024 01:37:12 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 23C4F41143; Thu, 14 Nov 2024 01:37:05 +0100 (CET) Received: from mail-pj1-f44.google.com (mail-pj1-f44.google.com [209.85.216.44]) by mails.dpdk.org (Postfix) with ESMTP id EFC2D40611 for ; Thu, 14 Nov 2024 01:37:01 +0100 (CET) Received: by mail-pj1-f44.google.com with SMTP id 98e67ed59e1d1-2e2bb1efe78so8936a91.1 for ; Wed, 13 Nov 2024 16:37:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1731544621; x=1732149421; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=7sTb5jrkBGCtBHrCn+rJI1PhLz5i3ECuFLwKNA9qeYA=; b=dEylHD6XDFnmE8enwvvjuSxFyWpPDHbXmHVBIf1u0RXuoghKU248IRAzbfjxFL3hPU Ef/FoyKI2toq8yM5/N2nvpWf1SXVIt0Zj4f7HbamQa2Qqr+IhWbAR3BjoPUGMTD69M7T WA1relYtgNLuLlyQZqFno5LlghvkePUYMyUql716Xo+hXeTfXv9tpw77RSggemiSt8sf KWG3KxuZCLVcsKw2k3fLfi4rpVMISNhrKLEhb7xJ4Zc/7cqDP2+wh0Sejmpi0EQvpWzB GN2jaBim5FVmOqQqJwFX9QAWnf9rJkIcSf2YDUbu33W6SAM98R73diykdn3Uk5JPaAsR RiZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1731544621; x=1732149421; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=7sTb5jrkBGCtBHrCn+rJI1PhLz5i3ECuFLwKNA9qeYA=; b=TnQEDFZX9GzWvW4zFhB9wBjzn7w6FVqQdfUf/fKMbnj4/1PZKt0UWt9ELPncUsGcXn BO/UODXNYhLVm4lQduTVmCJzp6P2fh1I/5ssEfL1YwC3S8VS4r0nsvFSHOh7s3i9cr0n LrqaUEekCO+hEJqofiIvjiSl+R4Umtuvc8jLqfq+IYUpt/1JjsDA9nNoIfLKvLXSXmee 3eXH0S1ccm8eme9VaVZHWPEyagklqQwAhWdDRFx6FVpPaqgNNbTopORPNWqMHDFw3CsT CPdaGoMssGjI4Uhr8gB+2u0U0p1TB7eow80YuxNwPr2XXCcohijqwDLGt1QRI7XMx/By lg/g== X-Gm-Message-State: AOJu0Yyvz51H6UjD8WgtRIIAJB8lKPxFujMyqOcMLHwT/Aqvc69eMTna K+UuipocCzjK7BjpIAh4rp81L2OYp+uRrQi2Afrth7h7tBYbEUMfAvdKV12FiO0Aiex2RgAvjIK w X-Google-Smtp-Source: AGHT+IErm0xCFj5G82yhQ1dJbSVLvnzp6wcsswWcMQ6HTIw7WToMsM8zG95QVZsJFpViy/yQQTiMzA== X-Received: by 2002:a17:90b:4d0f:b0:2d8:9fbe:6727 with SMTP id 98e67ed59e1d1-2e9fe615165mr2051003a91.4.1731544621065; Wed, 13 Nov 2024 16:37:01 -0800 (PST) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2ea024bdb0csm146886a91.39.2024.11.13.16.37.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Nov 2024 16:37:00 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , thomas@monjalon.net, Hemant Agrawal , Sachin Saxena Subject: [PATCH 2/2] common/dpaax: do not disable fallthrough warnings Date: Wed, 13 Nov 2024 16:36:14 -0800 Message-ID: <20241114003648.331795-3-stephen@networkplumber.org> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20241114003648.331795-1-stephen@networkplumber.org> References: <20241114003648.331795-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Fallthrough warnings catch real bugs and should not be disabled. There are warnings in this driver in current build. The commit that added the disable is old, and the problematic code appears to have been already removed. Fixes: 2ab9a9483196 ("crypto/dpaa2_sec: fix build with GCC 7") Cc: thomas@monjalon.net Signed-off-by: Stephen Hemminger --- drivers/common/dpaax/caamflib/rta/operation_cmd.h | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/common/dpaax/caamflib/rta/operation_cmd.h b/drivers/common/dpaax/caamflib/rta/operation_cmd.h index fe1ac37ee8..563735eb88 100644 --- a/drivers/common/dpaax/caamflib/rta/operation_cmd.h +++ b/drivers/common/dpaax/caamflib/rta/operation_cmd.h @@ -7,10 +7,6 @@ #ifndef __RTA_OPERATION_CMD_H__ #define __RTA_OPERATION_CMD_H__ -#if defined(RTE_TOOLCHAIN_GCC) && (GCC_VERSION >= 70000) -#pragma GCC diagnostic ignored "-Wimplicit-fallthrough" -#endif - extern enum rta_sec_era rta_sec_era; static inline int -- 2.45.2