From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 73BD345CFC; Thu, 14 Nov 2024 03:38:01 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9A96E427C0; Thu, 14 Nov 2024 03:37:54 +0100 (CET) Received: from mail-oa1-f45.google.com (mail-oa1-f45.google.com [209.85.160.45]) by mails.dpdk.org (Postfix) with ESMTP id 70A6A427A3 for ; Thu, 14 Nov 2024 03:37:51 +0100 (CET) Received: by mail-oa1-f45.google.com with SMTP id 586e51a60fabf-295d27f9fc9so87240fac.0 for ; Wed, 13 Nov 2024 18:37:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1731551870; x=1732156670; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=czdff7aaeagxvVWtV/V8L5ENmVGkpd7qahkHslii834=; b=oZLUBbMZ8jL/wUTPBcBVsB6eHV2/570v/RJ1bj/8pU02NeCk433dJIedvrX2Vcywei qWQ1SEK0CKno1GRkHMwL2Th8pa5VmdFnW5M1tair/N9kX/VM4mjjksVZWzh6Yri8LEWs S8g5EZDuIxQkmv7r28Wh7Phur8m2qq1bL9Ps8Lj7nDcxSHdkTAuTbsxBGr+u9wAkovOg ShgsGahmY+JtFyviJd4uDHydhNaTs9m5qcOJN7nN0O4GbQkmB8P9DxaZCZm+AoYQzzG8 0QvdO9uAI3CaSgh2+MqST6z2dCRHyvpul4vM7/gLdw+4PB4Y3toNTfeAh62knBhhDcLi UIDA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1731551870; x=1732156670; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=czdff7aaeagxvVWtV/V8L5ENmVGkpd7qahkHslii834=; b=fW4HhkCS9HpcK8hZXR85GEVvCT0olXLPtNH9f2OKUTGzX92lVVXFpE6shv2mnAlufn S0+PcqxH/sB2y30GeMDL4N7lZtCuZhTTJUlaOdYoD/ADVScRpbVvfRe+Cfye5hY9Z1wC Hz5OeS3lHwTmYfFaeoODyVbi++rDUTkdv/yJ9WKQBI6ZIsht3upYDkXfHT36C/oDlcMq KywsFYYGTubT+Qjkj2bvNHj9P0w7d6eWyhKJDbfDPxlOM4dAO05v+I4XQ6Lw6Hj0OePZ i61Vi+iL0Yo4ao2YfwoF3DLgiVjCnzRQ2+/mpqtz9prYv7xY334+LuV/DcYtDejPegV3 B6IQ== X-Gm-Message-State: AOJu0YxxFcQd8iehXHsk8jPpcjPH4FFdQeT/H8eK4wz2+y08rMLMq47p 0ewkypX45wa9LkrEpxxZjS1+VQJ5kVkuZdaNwoBnExZ29vKtYVBWULpr4jADAScXuqpNPhU4gPd H X-Google-Smtp-Source: AGHT+IFr+5RMmgY8FIX7WjTIgfVCRm0ky2WrbEJq78ufaEpxxtOZUFj1q8Tck/kSAtcZEWHgoD+xjw== X-Received: by 2002:a05:6870:1e87:b0:259:8cb3:db2e with SMTP id 586e51a60fabf-29610685515mr490392fac.39.1731551870500; Wed, 13 Nov 2024 18:37:50 -0800 (PST) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7246a5d2bb5sm150976b3a.29.2024.11.13.18.37.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Nov 2024 18:37:50 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Anatoly Burakov , Tyler Retzlaff Subject: [PATCH v3 02/11] eal: add new secure free function Date: Wed, 13 Nov 2024 18:35:51 -0800 Message-ID: <20241114023738.141821-3-stephen@networkplumber.org> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20241114023738.141821-1-stephen@networkplumber.org> References: <20241114011129.451243-1-stephen@networkplumber.org> <20241114023738.141821-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Although internally rte_free does poison the buffer in most cases, it is useful to have function that explicitly does this to avoid any security issues. Signed-off-by: Stephen Hemminger --- lib/eal/common/rte_malloc.c | 30 ++++++++++++++++++++++++------ lib/eal/include/rte_malloc.h | 18 ++++++++++++++++++ lib/eal/version.map | 3 +++ 3 files changed, 45 insertions(+), 6 deletions(-) diff --git a/lib/eal/common/rte_malloc.c b/lib/eal/common/rte_malloc.c index 3eed4d4be6..c9e0f4724f 100644 --- a/lib/eal/common/rte_malloc.c +++ b/lib/eal/common/rte_malloc.c @@ -15,6 +15,7 @@ #include #include #include +#include #include @@ -27,27 +28,44 @@ /* Free the memory space back to heap */ -static void -mem_free(void *addr, const bool trace_ena) +static inline void +mem_free(void *addr, const bool trace_ena, bool zero) { + struct malloc_elem *elem; + if (trace_ena) rte_eal_trace_mem_free(addr); - if (addr == NULL) return; - if (malloc_heap_free(malloc_elem_from_data(addr)) < 0) + if (addr == NULL) + return; + + elem = malloc_elem_from_data(addr); + if (zero) { + size_t data_len = elem->size - MALLOC_ELEM_OVERHEAD; + + rte_memset_sensitive(addr, 0, data_len); + } + + if (malloc_heap_free(elem) < 0) EAL_LOG(ERR, "Error: Invalid memory"); } void rte_free(void *addr) { - mem_free(addr, true); + mem_free(addr, true, false); +} + +void +rte_free_sensitive(void *addr) +{ + mem_free(addr, true, true); } void eal_free_no_trace(void *addr) { - mem_free(addr, false); + mem_free(addr, false, false); } static void * diff --git a/lib/eal/include/rte_malloc.h b/lib/eal/include/rte_malloc.h index c8836de67c..d472ebb7db 100644 --- a/lib/eal/include/rte_malloc.h +++ b/lib/eal/include/rte_malloc.h @@ -51,6 +51,24 @@ struct rte_malloc_socket_stats { void rte_free(void *ptr); + +/** + * Frees the memory space pointed to by the provided pointer + * and guarantees it will be zero'd before reuse. + * + * This pointer must have been returned by a previous call to + * rte_malloc(), rte_zmalloc(), rte_calloc() or rte_realloc(). The behaviour of + * rte_free() is undefined if the pointer does not match this requirement. + * + * If the pointer is NULL, the function does nothing. + * + * @param ptr + * The pointer to memory to be freed. + */ +__rte_experimental +void +rte_free_sensitive(void *ptr); + /** * This function allocates memory from the huge-page area of memory. The memory * is not cleared. In NUMA systems, the memory allocated resides on the same diff --git a/lib/eal/version.map b/lib/eal/version.map index a20c713eb1..fa67ff44d5 100644 --- a/lib/eal/version.map +++ b/lib/eal/version.map @@ -398,6 +398,9 @@ EXPERIMENTAL { # added in 24.11 rte_bitset_to_str; rte_lcore_var_alloc; + + # added in 25.03 + rte_free_sensitive; }; INTERNAL { -- 2.45.2