From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DA0A445D06; Thu, 14 Nov 2024 17:31:27 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B18944025D; Thu, 14 Nov 2024 17:31:27 +0100 (CET) Received: from mail-pf1-f171.google.com (mail-pf1-f171.google.com [209.85.210.171]) by mails.dpdk.org (Postfix) with ESMTP id 8DE174021F for ; Thu, 14 Nov 2024 17:31:26 +0100 (CET) Received: by mail-pf1-f171.google.com with SMTP id d2e1a72fcca58-7242f559a9fso800346b3a.1 for ; Thu, 14 Nov 2024 08:31:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1731601885; x=1732206685; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=5SYtBQ9k3Fo0JwANstxoMStumJMIf8MN3zjQg4oLVBk=; b=L1fUJWFOzUMSPx90zQqMwP06p1g0RqiIYXEetGs7CVbV9810eemcDfDlg3f7KyN1Mc SL5xj0B0xDghdCUG1q6hl4/EPatAxy1JoTjVlR06Q37uYCMriXcCdM1SXycWdvdmn4Oc QDjWgP/80WEetqu23G79yINNU+/vPUgae1UEAADn/rTfJMSFjlG8mxIrbaE5m5a2lyLs /vWkb7t7vV0yNIPCJXeaCApns0YgkTtQlmZLT7ONn4tnQVe7Q6lo9PUnvc1+h3Hl0Pw3 8tz/cQ1jKrBSR7NXbatRWxL7+2fdNyJafam0eHHl2vtKjVegixrqwdcnrhzI5B37GI5f 7P0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1731601885; x=1732206685; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=5SYtBQ9k3Fo0JwANstxoMStumJMIf8MN3zjQg4oLVBk=; b=Pl0qom44odobD5djnGskZHDh73Et+rtpLQRL2AsiqtFO4wdDC9kFWNxW7jVPuqGFJ7 51PaDEKsPhDX8AaBq7GvoULTmk0QV01wM1rTbl6X5kvwGAGkSNe3Epb3go9gHLuhIdON nuvvUVcbYDFGi36XczViuk2F5RmXGuoOKZTBM0IZSNRuo3VNfZTM4MoVHltdpCy1KPFe ANUnK2u6A/xqS5igQTVS+fjKg4WuictNC0uR8f2z5CoYcL1c6R6wmlP44Ke4pPivN32P Dktik2z8wqgntiy+6qbNzQnbGnNbxZRwYaBnHMNyF6MdJcJD7+bGRPQkH07zuuP5MUvY SMwQ== X-Gm-Message-State: AOJu0YwNjZOb4dSJVqNLnGxqw6h6e8d+HNVaUGcKo+zXE2e59imhcd1/ 282HCboXAoaDfSEWz4h9JiAomQFt01K/EeDSiiKNKwiVUS2s6xc40aSyaQqr4U0= X-Google-Smtp-Source: AGHT+IEsLhG8qiB4I7yuPEhEpm5avp4mlQBjyURfExZyPwPz6Dr6xI1V/7hHiHkHdU9/Ey3+7AWAIQ== X-Received: by 2002:a05:6a00:2388:b0:714:2069:d90e with SMTP id d2e1a72fcca58-724133966b8mr30103741b3a.26.1731601885527; Thu, 14 Nov 2024 08:31:25 -0800 (PST) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7246a9a89b5sm1481619b3a.103.2024.11.14.08.31.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Nov 2024 08:31:25 -0800 (PST) Date: Thu, 14 Nov 2024 08:31:22 -0800 From: Stephen Hemminger To: Dengdui Huang Cc: , , , , , , , , , , Subject: Re: [PATCH v6 00/14] use rte_strerror() for rte_errno Message-ID: <20241114083122.661dcb4b@hermes.local> In-Reply-To: <20241114114000.1677350-1-huangdengdui@huawei.com> References: <20231114082539.1858594-1-huangdengdui@huawei.com> <20241114114000.1677350-1-huangdengdui@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, 14 Nov 2024 19:39:46 +0800 Dengdui Huang wrote: > Whether strerror() needs to be replaced needs further discussion, > but rte_error should not be used by strerror() because rte_errno > may be an RTE-specific error code. > > This patchset use rte_strerror() instead of strerror() for rte_errno. > > Also, I tried to add it to checkpatch, but rte_errno can be used as an argument to any function > and the checkpatch script should not return an error, so I didn't do that. > > Dengdui Huang (14): > eal: fix use rte errno for libc function > eal: use rte strerror > pdump: use rte strerror > bus/vdev: use rte strerror > common/mlx5: use rte strerror > net/af_xdp: use rte strerror > net/bonding: use rte strerror > net/failsafe: use rte strerror > net/memif: use rte strerror > net/mlx4: use rte strerror > net/mlx5: use rte strerror > net/tap: use rte strerror > app/dumpcap: use rte strerror > test: use rte strerror > > app/dumpcap/main.c | 2 +- > app/test/test_bpf.c | 10 +++++----- > drivers/bus/vdev/vdev.c | 2 +- > drivers/common/mlx5/linux/mlx5_nl.c | 10 +++++----- > drivers/common/mlx5/mlx5_common.c | 6 +++--- > drivers/net/af_xdp/rte_eth_af_xdp.c | 2 +- > drivers/net/bonding/rte_eth_bond_flow.c | 4 ++-- > drivers/net/failsafe/failsafe.c | 2 +- > drivers/net/failsafe/failsafe_eal.c | 2 +- > drivers/net/failsafe/failsafe_flow.c | 4 ++-- > drivers/net/memif/rte_eth_memif.c | 2 +- > drivers/net/mlx4/mlx4.c | 2 +- > drivers/net/mlx4/mlx4_ethdev.c | 18 +++++++++--------- > drivers/net/mlx4/mlx4_rxq.c | 4 ++-- > drivers/net/mlx4/mlx4_txq.c | 10 +++++----- > drivers/net/mlx5/hws/mlx5dr_matcher.c | 2 +- > drivers/net/mlx5/linux/mlx5_ethdev_os.c | 22 +++++++++++----------- > drivers/net/mlx5/linux/mlx5_os.c | 16 ++++++++-------- > drivers/net/mlx5/mlx5.c | 8 ++++---- > drivers/net/mlx5/mlx5_mac.c | 2 +- > drivers/net/mlx5/mlx5_rxmode.c | 8 ++++---- > drivers/net/mlx5/mlx5_stats.c | 2 +- > drivers/net/mlx5/mlx5_testpmd.c | 10 +++++----- > drivers/net/mlx5/mlx5_trigger.c | 12 ++++++------ > drivers/net/mlx5/mlx5_vlan.c | 2 +- > drivers/net/mlx5/windows/mlx5_ethdev_os.c | 2 +- > drivers/net/mlx5/windows/mlx5_os.c | 10 +++++----- > drivers/net/tap/rte_eth_tap.c | 4 ++-- > lib/eal/linux/eal_dev.c | 2 +- > lib/eal/unix/eal_unix_memory.c | 2 +- > lib/pdump/rte_pdump.c | 2 +- > 31 files changed, 93 insertions(+), 93 deletions(-) > Looks good thanks. Series-Acked-by: Stephen Hemminger