From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A18E445D06; Thu, 14 Nov 2024 17:38:20 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9F8D94025D; Thu, 14 Nov 2024 17:38:19 +0100 (CET) Received: from mail-pl1-f181.google.com (mail-pl1-f181.google.com [209.85.214.181]) by mails.dpdk.org (Postfix) with ESMTP id F02A24021F for ; Thu, 14 Nov 2024 17:38:17 +0100 (CET) Received: by mail-pl1-f181.google.com with SMTP id d9443c01a7336-20c714cd9c8so9434245ad.0 for ; Thu, 14 Nov 2024 08:38:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1731602297; x=1732207097; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=qvi2By9P1ctbNTsVab3ITlaauTWorb5cdVvQgOVIvmU=; b=aeK+bffSb2bqYzcvhKtddkiXixDUelrUA2ub4htUlMmAkftswZ+x/iuyfp84xRks9g Mdal45RieQ/iMp//WikjU/s5SJAl7IMdWCivM9OLgaOJ+7QWLu0TuJzc/sQRwqMzp9m3 lJebsjbNyoPpd7wE6MNfrMVfadW5jHYv+aqeMXBZ7NkLE1o8JKs71Wqgt1b/DN0xr+h9 J9VgSB7/62X9zARxNoV14loyYC6Nt6YynPZLoh2LHdaUZHkgQ1H/HVeWFiVBlqH1Ea30 iXEDRHcmNdakFsBYNMmdE09uRV2M7OdzqhMgdQ0wwLtrCkF+BhI6KIC4aC1+/+gSZg6w +KOw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1731602297; x=1732207097; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=qvi2By9P1ctbNTsVab3ITlaauTWorb5cdVvQgOVIvmU=; b=GSx20M7Sda/cQjzMKdWqUZyAWUKjifAvXqwFoFyLDk9CiuiWoQcceWIFKAWjCvdIPk XeK1ZKzsABsJoot7+g+5CsGIeidJiQITekgz6rtFz1029Hv9Tx/3jdCaBaDMkFyM7wxh Tww6hpXifAN+3djFGAqolt8AzRbkrXZNghPQNny+IW1KfiHilTyBH7qipvZSzu8lSinH 8Fc8s50INX5P6qxeIpr1Wd5CMSyaN1JYblYuMUfSShFpayF9SzBmGtz9m5KiiLRLd48e uRtxo9dAGnSnE2cTQJ+sTHqu7EcnxCWkUwmDVejRhCYPKCg5TNcBIX1C/EB6ROR5c8jm zZeg== X-Forwarded-Encrypted: i=1; AJvYcCWiu5gxs6jwvNiI3sZBjgI9TAjwhpOPsvQf4BMk6wp7khyHj3VGnqel3F9/zQ4sgzMKoHU=@dpdk.org X-Gm-Message-State: AOJu0YztyqxuP1IWPCeQBleHEFdqJJbaDnN6WgW7GreQT4ZtjsaXPQGs eySfkBUPquYXH9Y07TeIqKI6JBmAmqxXQF9QaeiSrNgNBJvTSFX3z4pywTFsZLc= X-Google-Smtp-Source: AGHT+IHTXpW9M1nLLVbASGOwhkFsaAhpJeresNjt/LsHUUyHqGugW8Bty+7GGsTxti9/aF7hw7k7jA== X-Received: by 2002:a17:902:d4c9:b0:206:a87c:2864 with SMTP id d9443c01a7336-211c5092133mr32591355ad.42.1731602296996; Thu, 14 Nov 2024 08:38:16 -0800 (PST) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-211c7c2d0fcsm12756845ad.21.2024.11.14.08.38.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Nov 2024 08:38:16 -0800 (PST) Date: Thu, 14 Nov 2024 08:38:14 -0800 From: Stephen Hemminger To: Harman Kalra Cc: Nithin Dabilpuram , Kiran Kumar K , Sunil Kumar Kori , Satha Rao , Subject: Re: [PATCH 2/2] common/cnxk: add mailbox debug trace Message-ID: <20241114083814.0b5aa1eb@hermes.local> In-Reply-To: <20241104130800.164085-2-hkalra@marvell.com> References: <20241104130800.164085-1-hkalra@marvell.com> <20241104130800.164085-2-hkalra@marvell.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, 4 Nov 2024 18:38:00 +0530 Harman Kalra wrote: > Implementing mailbox debug trace points to trace function calls. > > Signed-off-by: Harman Kalra Missing use of RTE_ATOMIC() to flag atomic variables. -----------------------Summary of failed steps----------------------- "ubuntu-22.04-clang-stdatomic" failed at step Build and test ----------------------End summary of failed steps-------------------- -------------------------------BEGIN LOGS---------------------------- #################################################################################### #### [Begin job log] "ubuntu-22.04-clang-stdatomic" at step Build and test #################################################################################### atomic_store_explicit(ptr, val, memorder) ^ ~~~ /usr/lib/llvm-14/lib/clang/14.0.0/include/stdatomic.h:127:31: note: expanded from macro 'atomic_store_explicit' #define atomic_store_explicit __c11_atomic_store ^ ../drivers/common/cnxk/roc_dev.c:551:2: error: address argument to atomic operation must be a pointer to _Atomic type ('uint16_t *' (aka 'unsigned short *') invalid) plt_atomic_store_explicit(&mdev->msgs_acked, msgs_acked, plt_memory_order_release); ^ ~~~~~~~~~~~~~~~~~ ../drivers/common/cnxk/roc_platform.h:215:35: note: expanded from macro 'plt_atomic_store_explicit' #define plt_atomic_store_explicit rte_atomic_store_explicit ^ ../lib/eal/include/rte_stdatomic.h:72:2: note: expanded from macro 'rte_atomic_store_explicit' atomic_store_explicit(ptr, val, memorder) ^ ~~~ /usr/lib/llvm-14/lib/clang/14.0.0/include/stdatomic.h:127:31: note: expanded from macro 'atomic_store_explicit' #define atomic_store_explicit __c11_atomic_store ^ 2 errors generated. [749/3145] Compiling C object drivers/libtmp_rte_common_cnxk.a.p/common_cnxk_roc_cpt.c.o [750/3145] Compiling C object drivers/libtmp_rte_common_cnxk.a.p/common_cnxk_roc_cpt_debug.c.o [751/3145] Compiling C object drivers/libtmp_rte_common_cnxk.a.p/common_cnxk_roc_dpi.c.o [752/3145] Compiling C object drivers/libtmp_rte_common_cnxk.a.p/common_cnxk_roc_eswitch.c.o [753/3145] Compiling C object lib/librte_pipeline.a.p/pipeline_rte_table_action.c.o ninja: build stopped: subcommand failed. ##[error]Process completed with exit code 1. #################################################################################### #### [End job log] "ubuntu-22.04-clang-stdatomic" at step Build and test ##############################################################################