From: Huichao Cai <chcchc88@163.com>
To: jerinj@marvell.com, kirankumark@marvell.com,
ndabilpuram@marvell.com, yanzhirun_163@163.com
Cc: dev@dpdk.org
Subject: [PATCH v4 2/2] graph: add alignment to the member of rte_node
Date: Thu, 14 Nov 2024 16:45:19 +0800 [thread overview]
Message-ID: <20241114084519.5128-2-chcchc88@163.com> (raw)
In-Reply-To: <20241114084519.5128-1-chcchc88@163.com>
The members dispatch and xstat_off of the structure rte_node
can be min cache aligned to make room for future expansion and to
make sure have better performance. Add corresponding comments.
Due to the modification of the alignment of some members of the
rte_node structure, update file release_24_11.rst.
Signed-off-by: Huichao Cai <chcchc88@163.com>
---
doc/guides/rel_notes/release_24_11.rst | 3 +++
lib/graph/rte_graph_worker_common.h | 7 ++++++-
2 files changed, 9 insertions(+), 1 deletion(-)
diff --git a/doc/guides/rel_notes/release_24_11.rst b/doc/guides/rel_notes/release_24_11.rst
index 592116b979..6903b1d0f0 100644
--- a/doc/guides/rel_notes/release_24_11.rst
+++ b/doc/guides/rel_notes/release_24_11.rst
@@ -425,6 +425,9 @@ ABI Changes
* graph: added ``graph`` field to the ``dispatch`` structure in the ``rte_node`` structure.
+* graph: The members ``dispatch`` and ``xstat_off`` of the structure ``rte_node`` have been
+ marked as RTE_CACHE_LINE_MIN_SIZE bytes aligned.
+
Known Issues
------------
diff --git a/lib/graph/rte_graph_worker_common.h b/lib/graph/rte_graph_worker_common.h
index 4c2432b47f..d36abec08b 100644
--- a/lib/graph/rte_graph_worker_common.h
+++ b/lib/graph/rte_graph_worker_common.h
@@ -104,16 +104,21 @@ struct __rte_cache_aligned rte_node {
/** Original process function when pcap is enabled. */
rte_node_process_t original_process;
+ /** Fast path area cache line 1. */
union {
/* Fast schedule area for mcore dispatch model */
- struct {
+ alignas(RTE_CACHE_LINE_MIN_SIZE) struct {
unsigned int lcore_id; /**< Node running lcore. */
uint64_t total_sched_objs; /**< Number of objects scheduled. */
uint64_t total_sched_fail; /**< Number of scheduled failure. */
struct rte_graph *graph; /**< Graph corresponding to lcore_id. */
} dispatch;
};
+
+ /** Fast path area cache line 2. */
+ alignas(RTE_CACHE_LINE_MIN_SIZE)
rte_graph_off_t xstat_off; /**< Offset to xstat counters. */
+
/* Fast path area */
__extension__ struct __rte_cache_aligned {
#define RTE_NODE_CTX_SZ 16
--
2.27.0
next prev parent reply other threads:[~2024-11-14 8:45 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-07 8:04 [PATCH] graph: optimize graph search when scheduling nodes Huichao cai
2024-11-07 9:37 ` [EXTERNAL] " Jerin Jacob
2024-11-08 1:39 ` Huichao Cai
2024-11-08 12:22 ` Jerin Jacob
2024-11-08 13:38 ` David Marchand
2024-11-11 5:38 ` Jerin Jacob
2024-11-12 8:51 ` David Marchand
2024-11-12 9:35 ` Jerin Jacob
2024-11-12 12:57 ` Huichao Cai
2024-11-13 9:22 ` Huichao Cai
2024-11-14 7:09 ` Jerin Jacob
2024-11-11 4:03 ` [PATCH v2] graph: mcore: optimize graph search Huichao Cai
2024-11-11 5:46 ` [EXTERNAL] " Jerin Jacob
2024-11-13 9:19 ` Huichao Cai
2024-11-13 7:35 ` [PATCH v3 1/2] " Huichao Cai
2024-11-13 7:35 ` [PATCH v3 2/2] graph: add alignment to the member of rte_node Huichao Cai
2024-11-14 7:14 ` [EXTERNAL] " Jerin Jacob
2024-11-14 8:45 ` [PATCH v4 1/2] graph: mcore: optimize graph search Huichao Cai
2024-11-14 8:45 ` Huichao Cai [this message]
2024-11-14 10:05 ` [EXTERNAL] [PATCH v4 2/2] graph: add alignment to the member of rte_node Jerin Jacob
2024-11-14 12:06 ` Huichao Cai
2024-11-14 13:04 ` Jerin Jacob
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241114084519.5128-2-chcchc88@163.com \
--to=chcchc88@163.com \
--cc=dev@dpdk.org \
--cc=jerinj@marvell.com \
--cc=kirankumark@marvell.com \
--cc=ndabilpuram@marvell.com \
--cc=yanzhirun_163@163.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).