From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id A8CE145D07;
	Thu, 14 Nov 2024 18:07:54 +0100 (CET)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 956E84025D;
	Thu, 14 Nov 2024 18:07:54 +0100 (CET)
Received: from mail-pj1-f44.google.com (mail-pj1-f44.google.com
 [209.85.216.44]) by mails.dpdk.org (Postfix) with ESMTP id 0E53E4021F
 for <dev@dpdk.org>; Thu, 14 Nov 2024 18:07:53 +0100 (CET)
Received: by mail-pj1-f44.google.com with SMTP id
 98e67ed59e1d1-2ea0f91d381so398418a91.1
 for <dev@dpdk.org>; Thu, 14 Nov 2024 09:07:52 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1731604072;
 x=1732208872; darn=dpdk.org; 
 h=content-transfer-encoding:mime-version:references:in-reply-to
 :message-id:subject:cc:to:from:date:from:to:cc:subject:date
 :message-id:reply-to;
 bh=tCkCqwK9sy6nuc9A5T7cQEolfhJ8qdyXWCifUTO3jd0=;
 b=FdbaPE89yC5+YANzdnJiNQK2GRSQr3nBZG7Gy5xkdyxFQjoBtJBV3/Jd9R8V1Ffds+
 Kp74wSa+ltpm0Y97eqMDcFV5zuKAu13s3qOAvqCin+mTE2MFoYxprUdiYTedOT4XtQZk
 TrjLwagSG5CQZj7MlRIJYN376KXOevVck3V27sCYt884n9aygQ3/je1m0CDXPe76IT9J
 KI26PhvunqqmQFnySfMKGRcdtHu1RVtnOpfmeREKNmhfWmllAsR/oY/tH8BKFpyOtV7h
 hPmSmpnLvUO/TCjl7aBOdwbSepo6AA/MUE09pMts6ZIG+cmob8qc2BoJNM4W7CWXS9Hk
 tlXg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1731604072; x=1732208872;
 h=content-transfer-encoding:mime-version:references:in-reply-to
 :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc
 :subject:date:message-id:reply-to;
 bh=tCkCqwK9sy6nuc9A5T7cQEolfhJ8qdyXWCifUTO3jd0=;
 b=ATeRxeULaPfzphybsq6tMvMGZV8g59A4r48mxM+W1b3i/IwPEH3oMhVRJYD853ToAy
 XLLfNbHcJtY20R8s7cgOoz4+tpGCapQvrc860BSfFd295+1+qUbXSn0ke2QFINO+DwwY
 FyLw6yAoPYBThCjD+xB/eMHKACiZJka0u0cFGDoyh3SEejfsCpos01x0E61tj6kJXsPu
 OZ5aSNfzkwkHbwOr2UucnpCCzxHEQZO9lSeBVQPKtJFxA9tvkOXAhdvKtrL/D6ZvDY6m
 fyw3LyoWW60lc652LjPQATcm9/wrVdF700xCwPS7JrunVlQ4UFbnfQVK/EiQ8nd0AFhj
 SPQg==
X-Forwarded-Encrypted: i=1;
 AJvYcCWIHOyWXLb3GzYHUIcf0m11mPcGxj3xiZGT5OfW6C9IqRaVsL7slPfQQm42YBQdvHRGIbA=@dpdk.org
X-Gm-Message-State: AOJu0Yym2s7KuihmBvdp9mxTykEbEARAGE2GXB8hSDBQWObmfxBf1egw
 aNVvmvAQpSp12BYdWBGATqwepygC8IIz2Hn0Bj230gM7M4sbqYTct/DQ6elA/y8=
X-Google-Smtp-Source: AGHT+IGIlE1BC6mv0oFgA1+Am81yJueKNJqbyGlKRNm71Pe2CcM9vxm7QEX18MIX42CwEXq9nR/d4g==
X-Received: by 2002:a17:90a:e7c6:b0:2e2:d3e9:eb33 with SMTP id
 98e67ed59e1d1-2ea0637083fmr3079273a91.11.1731604071594; 
 Thu, 14 Nov 2024 09:07:51 -0800 (PST)
Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226])
 by smtp.gmail.com with ESMTPSA id
 98e67ed59e1d1-2ea06ef6a7esm1414573a91.4.2024.11.14.09.07.51
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Thu, 14 Nov 2024 09:07:51 -0800 (PST)
Date: Thu, 14 Nov 2024 09:07:48 -0800
From: Stephen Hemminger <stephen@networkplumber.org>
To: <kirankumark@marvell.com>
Cc: Jerin Jacob <jerinj@marvell.com>, Nithin Dabilpuram
 <ndabilpuram@marvell.com>, Zhirun Yan <yanzhirun_163@163.com>,
 <dev@dpdk.org>, <rjarry@redhat.com>, <chcchc88@163.com>
Subject: Re: [PATCH v4 2/3] graph: add support for node free API
Message-ID: <20241114090748.0c847525@hermes.local>
In-Reply-To: <20241114090806.3266673-2-kirankumark@marvell.com>
References: <20241114070432.3152188-1-kirankumark@marvell.com>
 <20241114090806.3266673-1-kirankumark@marvell.com>
 <20241114090806.3266673-2-kirankumark@marvell.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

On Thu, 14 Nov 2024 14:38:05 +0530
<kirankumark@marvell.com> wrote:

>  
> +uint8_t
> +graph_is_node_active_in_graph(struct node *node)

For true/false functions bool type is preferred.
It prevents cases where function accidentally returns 2.