From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2C9B845D07; Thu, 14 Nov 2024 18:37:43 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1449B4025D; Thu, 14 Nov 2024 18:37:43 +0100 (CET) Received: from mail-pl1-f182.google.com (mail-pl1-f182.google.com [209.85.214.182]) by mails.dpdk.org (Postfix) with ESMTP id 28C2F4021F for ; Thu, 14 Nov 2024 18:37:41 +0100 (CET) Received: by mail-pl1-f182.google.com with SMTP id d9443c01a7336-2118dfe6042so7669935ad.2 for ; Thu, 14 Nov 2024 09:37:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1731605860; x=1732210660; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=+w2EBi4qZFdiJeVVBMIAbzsoFO9j4TsAqo1qisbXeP8=; b=vtlZaZc2gsasOtt+C0fAPVl86M4IYt+R8fdS4ROB/K430BlSIg995fP0TUuKDoq0aI eIqpP4dxkbHGMbCR8FsvVCiSkYLctsYYIHpn/bS1FLfZg7LU9ppo87SF9SIAJPiwr9hf 6NS6GdNL6Phqf8r9bmsGdDZyWZy9akRvk6+Re4Wpkap4z3dDvxQ4+veni2Oavq0sCoNd XH0UfpPZnaEQvAZMcVBvNLIC/0gIzJV20zHlncT4eYs+OntokLd3cAb9agwD5YjlzwSb SxUg1/ayAkrl6Pm6oj0SkiSDPvZWmtkWy28ufVZckMUSAE6uUqWAZt63ZckruIhV4+fg pQQQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1731605860; x=1732210660; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=+w2EBi4qZFdiJeVVBMIAbzsoFO9j4TsAqo1qisbXeP8=; b=CxF0WGFOMDr0UMHi6ENpfQJsbN/BrSaxCBwF5xg8dBIzDogiBhRn4f1vATeETZTEF1 7P0rmCFB5F03fZz3KdJoHN2B02mlF91MGQboiJZPRi0E/Ec5WQVEcas4GKVG5a3uA92t g5Z+o2ndltuNIxdNam52UB65rq56mxv08GwCF3Dqcuz+8sR037xfXZOlrDifXO4ePnT0 o4zzIa8g5/YDb8n0gOtUbRskRh8kD4j8z3ZSvuMfqpfIJJFecT6+5aKjK1J4bYB4uoYV cSBxFwlNuxM7CpegBThayq7aceOegEZz1xfU9brvpUL806gWjbW0h8WeetVTCjSO3tNz 1qrg== X-Forwarded-Encrypted: i=1; AJvYcCXcozdP8fRYOdo/ia+L7IBXrxS0qcya0QydPwmjfpmxhLEyoxhtOnY9HEUpvwIakGZP2s4=@dpdk.org X-Gm-Message-State: AOJu0YxoPST5B0NrSPRdu+6tgI0a2UK/Kc1A8kD21qOmJmPhwHV2Jb4c LLpKaWEFt9ThbaRcBtJrTVGS+gTk6Cw92s41J2vcKU/2TQcGfVvVk+NCiHNsyM8= X-Google-Smtp-Source: AGHT+IE4ieJenwztOaXLmFingRr4Xo8fRBVpf7E9eYlvzYaD+U4i/5l6PKkpSSsPb88mPHVJ9DE6jg== X-Received: by 2002:a17:902:da91:b0:20f:ab2e:14f9 with SMTP id d9443c01a7336-211aba51f36mr113970655ad.55.1731605860161; Thu, 14 Nov 2024 09:37:40 -0800 (PST) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-211c7ce900dsm13289295ad.143.2024.11.14.09.37.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Nov 2024 09:37:39 -0800 (PST) Date: Thu, 14 Nov 2024 09:09:00 -0800 From: Stephen Hemminger To: Cc: Jerin Jacob , Nithin Dabilpuram , Zhirun Yan , , , Subject: Re: [PATCH v4 3/3] test/graph: fix graph autotest second run test failure Message-ID: <20241114090849.02c3d953@hermes.local> In-Reply-To: <20241114090806.3266673-3-kirankumark@marvell.com> References: <20241114070432.3152188-1-kirankumark@marvell.com> <20241114090806.3266673-1-kirankumark@marvell.com> <20241114090806.3266673-3-kirankumark@marvell.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, 14 Nov 2024 14:38:06 +0530 wrote: > From: Kiran Kumar K > > The graph autotest second run test is failing due to the > node name is already present in the node list. Adding changes > to free nodes at the time of test cleanup. > > Fixes: 6b89650418fe ("test/graph: add functional tests") > > Signed-off-by: Kiran Kumar K > --- > app/test/test_graph.c | 96 ++++++++++++++++++++++++++++++++++++++++--- > 1 file changed, 90 insertions(+), 6 deletions(-) > > diff --git a/app/test/test_graph.c b/app/test/test_graph.c > index 2840a25b13..e712dbebf7 100644 > --- a/app/test/test_graph.c > +++ b/app/test/test_graph.c > @@ -68,6 +68,8 @@ static void *mbuf_p[MAX_NODES + 1][MBUFF_SIZE]; > static rte_graph_t graph_id; > static uint64_t obj_stats[MAX_NODES + 1]; > static uint64_t fn_calls[MAX_NODES + 1]; > +static uint32_t dummy_nodes_id[MAX_NODES]; > +static int dummy_nodes_id_count; Why is dummy_nodes_id_count signed? Can it ever be negative? If not better to use unsigned or uint32_t