From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id AE17645D07; Thu, 14 Nov 2024 18:13:59 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C385542ECB; Thu, 14 Nov 2024 18:13:55 +0100 (CET) Received: from mail-pl1-f179.google.com (mail-pl1-f179.google.com [209.85.214.179]) by mails.dpdk.org (Postfix) with ESMTP id B1D1F4021F for ; Thu, 14 Nov 2024 18:13:53 +0100 (CET) Received: by mail-pl1-f179.google.com with SMTP id d9443c01a7336-20ca388d242so9594955ad.2 for ; Thu, 14 Nov 2024 09:13:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1731604433; x=1732209233; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=5ZF28Yo45eOlOhHSirg9rs/4DXHKqd/VDdPpAwn24C0=; b=pNmsx4iCOypF909FvNHQ2Zm91zghYfs4GjIjcYBnjNs2dB2ycc/OKNLZLtf4s6/8bF JHtz3MjGgegvaha8+cCj/9Paz10T8erVioCzsF/WBfqb5EYLg+87im0XafC+Snryi9bU p6tHEpORD0DixNkgqhtZEp0AaPtW2c8muhqLy+NxnICvYK8RcQ2FnmR8esGIxPSfWbNk 5dmOVNs4ooqfPOox55+QKOWGf0ZqP+opA0TGmDKrTF0frGJPf/aQRoPts7ZxMHwIvXjm rYHu1kCiEjmiVu0jIizKAocp0Cmp/w5Yz8/j9pyWQ3tkrvDvBFCbdT4plm1KUwkXD6W9 tqAw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1731604433; x=1732209233; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=5ZF28Yo45eOlOhHSirg9rs/4DXHKqd/VDdPpAwn24C0=; b=EknvSbH8vlv61Q2KOvObJQNb/8k10YCy2LWLsml8DRPXANxk5OxK4Q3HQ+ob4UOL7o nH8zlXl6cybLTzbSDR08+UFGU70jAWPw/e06asqtG3rkT6MFbYFh1sqPQbz+wS0kmwsF QTNRfhWeZsa2vgfmeqOydSXpUOZVHGo3PYSF5VF6Cid03FLyHYvn1j5vfZ2gVQAU7Ldr iUDwnkwkn5jIcg+YeB9YvJmGRFWUHxp2kRus5qIlVIfgo9T8yqluqqczE7+v4+T/IbJy 9C/GCa6MZigurHe88TwpFhRhlDZtgzI5IskLsDxs+VkIQmk0lgz3FrOqaMIxUeOKiq73 fV0Q== X-Gm-Message-State: AOJu0YwZKa4PdwjDMcWoKVZ9c3sNlgFquioScOrKMSaLM07NGJko0jum 2Snl7VE87QXeqnrTjPM8kohcuzblmx2bwogdAaKmhkpmcDPgxzKNfgpG2gffkxIzW/s008wjfOy ZgPo= X-Google-Smtp-Source: AGHT+IFowaxkvdvy0Gg8ORjUKLyUpFjkZR+An+9DvK+gx4QAeef344ukUfDf6Vk6vo5qqL3E73XX+w== X-Received: by 2002:a17:902:ce0e:b0:20b:7e1e:7337 with SMTP id d9443c01a7336-211c4fb5103mr31528495ad.13.1731604432940; Thu, 14 Nov 2024 09:13:52 -0800 (PST) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-211c7d1ee20sm13047865ad.216.2024.11.14.09.13.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Nov 2024 09:13:52 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , thomas@monjalon.net, Hemant Agrawal , Sachin Saxena Subject: [PATCH v2 1/2] common/dpaax: do not disable fallthrough warnings Date: Thu, 14 Nov 2024 09:11:54 -0800 Message-ID: <20241114171342.19767-2-stephen@networkplumber.org> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20241114171342.19767-1-stephen@networkplumber.org> References: <20241114003648.331795-1-stephen@networkplumber.org> <20241114171342.19767-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Fallthrough warnings catch real bugs and should not be disabled. There are warnings in this driver in current build. The commit that added the disable is old, and the problematic code appears to have been already removed. Fixes: 2ab9a9483196 ("crypto/dpaa2_sec: fix build with GCC 7") Cc: thomas@monjalon.net Signed-off-by: Stephen Hemminger Acked-by: Hemant Agrawal --- drivers/common/dpaax/caamflib/rta/operation_cmd.h | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/common/dpaax/caamflib/rta/operation_cmd.h b/drivers/common/dpaax/caamflib/rta/operation_cmd.h index fe1ac37ee8..563735eb88 100644 --- a/drivers/common/dpaax/caamflib/rta/operation_cmd.h +++ b/drivers/common/dpaax/caamflib/rta/operation_cmd.h @@ -7,10 +7,6 @@ #ifndef __RTA_OPERATION_CMD_H__ #define __RTA_OPERATION_CMD_H__ -#if defined(RTE_TOOLCHAIN_GCC) && (GCC_VERSION >= 70000) -#pragma GCC diagnostic ignored "-Wimplicit-fallthrough" -#endif - extern enum rta_sec_era rta_sec_era; static inline int -- 2.45.2