From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2DAE745D07; Thu, 14 Nov 2024 19:45:56 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 30FB342F03; Thu, 14 Nov 2024 19:45:15 +0100 (CET) Received: from mail-pj1-f44.google.com (mail-pj1-f44.google.com [209.85.216.44]) by mails.dpdk.org (Postfix) with ESMTP id 7CFA242EE8 for ; Thu, 14 Nov 2024 19:45:09 +0100 (CET) Received: by mail-pj1-f44.google.com with SMTP id 98e67ed59e1d1-2e2bd347124so816988a91.1 for ; Thu, 14 Nov 2024 10:45:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1731609909; x=1732214709; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=6QEjjxY/v8YRYfo8xYBCfjBkZmBLfn8Gzc4bxyvAQAU=; b=sf4VK2oaw5asKy9BMbAf4JpzcTgxP3uKnTpeiWn9okclKbIUd3UN1XnirEDZvXEwpI mJVWxenoRPWTQvpMIkAEm6juDZSp84kOMXbpYEkQnPN5hs7wO7CU2LxLGcbDsxPowOen dNuVHkuej7wz6W8/PPT7rngid6Aj7H5GWTHbDDxCzw+cSN/Bm50KZ8liGb2rjdq4xjSp VuLvOvcETgohW5Ydvl9vFkJkSzRENtvREtRTgq5qiR0TQ9vIg0AAS3qdZHxgTc9izu7j oR5JF7Ud1l7CicxR0zCVaKKjdZqQOPoUI19Euglqk00Ypy5vpUfmfMfZ7y8WoZVrBI4j YhSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1731609909; x=1732214709; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=6QEjjxY/v8YRYfo8xYBCfjBkZmBLfn8Gzc4bxyvAQAU=; b=dfgxyaGB6aGUvWVQj+rHBTi3xtEIUCW7/9SV+OEzc+TG8RVLex2yBkKyCBeKGoFj++ XQnkrTKkDRZRff4gunew8ngnUv8Hx/HIYLF5ipJ1iDNoeH40bwF6ie0pUEdEvKGmW0Yj s09UbVvNmbhtpysPlFrQgR4V5C3YR1AfyRIskVPPsQEABPWpEDguipHevSiNGRKBSR0R fKIVr4OJLGfk2a8SDQ9EFixsXVyXvQpN/DHT+Z3y3ZF7CFptj6oZ2UjWig9NBSInEHBT Ke/KykRU3pYA7SvvBSKcsK103f4D3aWhlweq6GKSbboIOLF+eW46f5WuF4GEIGXGDHXG lELA== X-Gm-Message-State: AOJu0YwGxN48J/ax6ouSJhxfFv3MKy/GHs5FpnmDMugHoKOfcCAvSiu0 hKbspw+zL1kKcCiNTJKHX1Cx7JIVvB5KFs/PJqRxJgDzgwIfCIYS1WopeSNTXyJLqI+kStBV1bs kS9Q= X-Google-Smtp-Source: AGHT+IHwzwZFgo4Hsujcgo8QiZZtbN0hvjmJGMk6mD/EBBBBsorGCLLOtcXZcOdVwSIJBiQ+lKAtOw== X-Received: by 2002:a17:90b:2511:b0:2ea:11a2:f15 with SMTP id 98e67ed59e1d1-2ea11a2123fmr1678202a91.15.1731609908682; Thu, 14 Nov 2024 10:45:08 -0800 (PST) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2ea06ef71a6sm1517611a91.8.2024.11.14.10.45.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Nov 2024 10:45:08 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Bruce Richardson Subject: [PATCH v4 08/12] test: remove unneeded memset Date: Thu, 14 Nov 2024 10:43:30 -0800 Message-ID: <20241114184452.31854-9-stephen@networkplumber.org> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20241114184452.31854-1-stephen@networkplumber.org> References: <20241114011129.451243-1-stephen@networkplumber.org> <20241114184452.31854-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Since tmp is not used later in the function, this memset is unnecessary. Even though this is harmless, it causes tools that look for security issues around memset to flag this a bug. Signed-off-by: Stephen Hemminger Acked-by: Bruce Richardson --- app/test/test_cmdline_cirbuf.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/app/test/test_cmdline_cirbuf.c b/app/test/test_cmdline_cirbuf.c index 8ac326cb02..1be357abf6 100644 --- a/app/test/test_cmdline_cirbuf.c +++ b/app/test/test_cmdline_cirbuf.c @@ -281,8 +281,6 @@ test_cirbuf_string_add_del_reverse(void) printf("Error: buffer should have been empty!\n"); return -1; } - /* clear tmp buffer */ - memset(tmp, 0, sizeof(tmp)); /* * reinitialize circular buffer -- 2.45.2