From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 54B9945CC3; Thu, 14 Nov 2024 20:26:28 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E12DC42EEB; Thu, 14 Nov 2024 20:26:20 +0100 (CET) Received: from mail-pf1-f172.google.com (mail-pf1-f172.google.com [209.85.210.172]) by mails.dpdk.org (Postfix) with ESMTP id 2565B42ED0 for ; Thu, 14 Nov 2024 20:26:17 +0100 (CET) Received: by mail-pf1-f172.google.com with SMTP id d2e1a72fcca58-720be27db27so839241b3a.2 for ; Thu, 14 Nov 2024 11:26:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1731612376; x=1732217176; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=7DdZaXIun8eKC7Xc1tS/1drNMQCXbn81we0F5N/eFRs=; b=toKNMRDie8ck4bAeSIjI+sadr1ZQOAw2akte2xxyLzSxL4vWHgqtumP1bkP8OzSFkl Iy7zx3TX74FEwoOsXPb+TyMX25Edf6o8wkzOk4AlfhS2jD8YevOP3ERgesbR4Ll1/fjT OEmSN9AOVc/X1JZZ89DEDPcMDzE3xScJ3YF2boxjm9ktmv2iCmEWidFZFkdCBfkzYWe/ qcipNA8duBNeg4X0hrR0lF/3RO+4Q63EqYVlYpeYsWi/minO/iX9k3oxswmtZlcOl+QE LfR3tb8Pp5dYFrKNeE6mMdDMFasfieZw/oo9AA95TbbdKEbyoGJPJ8MtkJh8MwgMRrtH xoAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1731612376; x=1732217176; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=7DdZaXIun8eKC7Xc1tS/1drNMQCXbn81we0F5N/eFRs=; b=XD0kFZgdyHEuLcwZ+BXXv5i5xyybfKukyKBEMv/XyC0RI8k2H/C/vsj6YVp/WJ/3nf Sf0IIcVLyou2dg3O06bnNAbw/ehqNV5o9m+8xCCk6hkYmA1DAdvyx7RXxzduGAd22G3I COZOKM3bwYvyLc46OVyI1SqxVRXrN3FaMNeO8aulDChBw04CO+1T9W9LhDl8tlO6YQe1 UkB8wmadqAA3nZ74ATENG60KfkGMvIrddaaUuGNdhzQUdkXwntIURdHbMnV0opOdX9t+ QnI+4aqkBpB+h+iM+oJjJh9doARNdqXYcoIlhx3m7jxp5psNc+aGIH3gIXCciwJR7pNF 2bJg== X-Gm-Message-State: AOJu0YyLDencXip/4gZDijpAqDbq8fgYgdtzi6T3t+WnWdda+oz1hoUp VboSIpX3yDqv/w9kNzF+pJVSnJwEOf8aKjSa5s9/e38yvwF3+KvEzJKXqmrrVPNgjBlxYA5UaJm KTOM= X-Google-Smtp-Source: AGHT+IGtuYtfM3jKTDnZoa9rL7KcPriEkypogyYzEPiuWk7G/QZR0n3Ng4/tEqYsqlgRGI30OSGjNQ== X-Received: by 2002:a05:6a00:b82:b0:724:6b02:61b8 with SMTP id d2e1a72fcca58-72476b9680dmr38891b3a.7.1731612376307; Thu, 14 Nov 2024 11:26:16 -0800 (PST) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-7f8b37f3466sm1461632a12.35.2024.11.14.11.26.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Nov 2024 11:26:15 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , declan.doherty@intel.com, stable@dpdk.org, Chas Williams , "Min Hu (Connor)" , Pablo de Lara Subject: [PATCH v2 02/10] app/test: fix typo in address compare Date: Thu, 14 Nov 2024 11:25:00 -0800 Message-ID: <20241114192603.41145-3-stephen@networkplumber.org> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20241114192603.41145-1-stephen@networkplumber.org> References: <20241114001403.147609-1-stephen@networkplumber.org> <20241114192603.41145-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org The first argument of 'memcmp' function was equal to the second argument. Therefore ASSERT would always be true. Link: https://pvs-studio.com/en/blog/posts/cpp/1179/ Fixes: 92073ef961ee ("bond: unit tests") Cc: declan.doherty@intel.com Cc: stable@dpdk.org Signed-off-by: Stephen Hemminger --- app/test/test_link_bonding.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/test/test_link_bonding.c b/app/test/test_link_bonding.c index 805613d7dd..b752a5ecbf 100644 --- a/app/test/test_link_bonding.c +++ b/app/test/test_link_bonding.c @@ -792,7 +792,7 @@ test_set_primary_member(void) &read_mac_addr), "Failed to get mac address (port %d)", test_params->bonding_port_id); - TEST_ASSERT_SUCCESS(memcmp(&read_mac_addr, &read_mac_addr, + TEST_ASSERT_SUCCESS(memcmp(expected_mac_addr, &read_mac_addr, sizeof(read_mac_addr)), "bonding port mac address not set to that of primary port\n"); -- 2.45.2