From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6045145D13; Fri, 15 Nov 2024 17:18:26 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E9C9D42FEB; Fri, 15 Nov 2024 17:18:25 +0100 (CET) Received: from mail-pf1-f175.google.com (mail-pf1-f175.google.com [209.85.210.175]) by mails.dpdk.org (Postfix) with ESMTP id E59D042F95 for ; Fri, 15 Nov 2024 17:18:23 +0100 (CET) Received: by mail-pf1-f175.google.com with SMTP id d2e1a72fcca58-7240d93fffdso797138b3a.2 for ; Fri, 15 Nov 2024 08:18:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1731687503; x=1732292303; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=pkNVchQiolwdFxbofPFsUWccsVpHz2GAYR784pO/Fao=; b=z4iVKEX9ME8HBBAFON1w2TPYyol8F+PIoXCq+9ARqbh8/9jnyJffRJ4/toUkCAs2x4 ZPlOPKT0+WuAqQdpByr7aADo7t5LVUCpp2zOh8Bb6EifYsA0sHEFNPhTmQa3v4EBQxVf R9MU44h0GeoyO+mN6gSxNe1CkDGxujhsz3A+KAnXIWF1AHYjUuzi0ubsXpwvppbJ/cKI lD29/f68Qe25P5+5vCBY/UqleDDvhR4Ww3xeUHFFrUB6H4bf1Q9g/8mmJPN9ZRrzMSex 6FPZ9gHBNUz/hMlDS/FkOvrlwkAFQbfvXE+/wk+QQpSi2Ut3nMqdmt9p203cm8Mq1NlO J0lA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1731687503; x=1732292303; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=pkNVchQiolwdFxbofPFsUWccsVpHz2GAYR784pO/Fao=; b=pTBEvTnm0/Iiv3LtO585CNSBu/b6/L55slbxRDSX27L9lwUcgSg1XrxxUAp6UeQEQA o87YzsYYfl3Vm4gy2QO7sTsea3MMrfV5bRlr97Smn2tnjFYpXRUl7hOo18NQ2YOQOdON 5gHm7Jgp7Zp/iHjfsWGzDS98YU0jDEpcnsHsiqDx1YVG4uqqcatzkqLSi4TkeRhxz3Wl Iwo/AvZ/MCNJa1ZnInCyRtMR2SkhOVf0KUlU/yZA1qTuvSWLVWVRQxO7+NgkMgqbAd3k kakIImrZQhFcfWAkG3mR/wiRrBVeEC89cL+JBBhs7djk9yN/iOy391sjtnNY4vFEK3AC 5p9A== X-Gm-Message-State: AOJu0YwckPUVmwUUqI4SjfpVxWFDvpSh6nIpik0fF9UISsU4El82Wv4K LapLWy3YfnpRNNObcreYFXMTS9oXTz+zhJ41B2KLlnhDWWUBp0viylDBZv9dkPk= X-Google-Smtp-Source: AGHT+IH9V8NUKjmvX9jRFTjY4XTeXuWB25dhaMLwzrGvmIdObxT7SBpAt+b6eh5K1GR2y3Sg7d0t5Q== X-Received: by 2002:a05:6a00:98d:b0:71e:4414:eb21 with SMTP id d2e1a72fcca58-72476cc96f4mr3586714b3a.17.1731687502991; Fri, 15 Nov 2024 08:18:22 -0800 (PST) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-724771fffd7sm1529488b3a.171.2024.11.15.08.18.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Nov 2024 08:18:22 -0800 (PST) Date: Fri, 15 Nov 2024 08:18:20 -0800 From: Stephen Hemminger To: Andre Muezerie Cc: dev@dpdk.org, honnappa.nagarahalli@arm.com, doug.foster@arm.com, david.marchand@redhat.com Subject: Re: [PATCH v3] rcu: shift 64-bit constant to avoid implicit 32 to 64 bit conversion Message-ID: <20241115081820.10c423f8@hermes.local> In-Reply-To: <1731684330-5735-1-git-send-email-andremue@linux.microsoft.com> References: <1731448959-18046-1-git-send-email-andremue@linux.microsoft.com> <1731684330-5735-1-git-send-email-andremue@linux.microsoft.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, 15 Nov 2024 07:25:30 -0800 Andre Muezerie wrote: > From reading the code this is also a bugfix: > (1 << id), where id = thread_id & 0x3f, was wrong when thread_id > 0x1f. Since this seems to be a common anti-pattern in DPDK, I wonder if coccinelle is smart enough to be able to make a script for these?