DPDK patches and discussions
 help / color / mirror / Atom feed
From: Stephen Hemminger <stephen@networkplumber.org>
To: Congjie Zhou <zcjie0802@qq.com>
Cc: dev@dpdk.org, anatoly.burakov@intel.com
Subject: Re: [PATCH v2] eal/linux: fix fbarray name with multiple secondary processes
Date: Fri, 15 Nov 2024 12:09:20 -0800	[thread overview]
Message-ID: <20241115120920.6ae82b8e@hermes.local> (raw)
In-Reply-To: <tencent_0B9C25BDE8192439C88141D4EFDC0BEB8D07@qq.com>

On Fri, 15 Nov 2024 15:50:08 +0800
Congjie Zhou <zcjie0802@qq.com> wrote:

> diff --git a/lib/eal/linux/eal_memalloc.c b/lib/eal/linux/eal_memalloc.c
> index e354efc..367d401 100644
> --- a/lib/eal/linux/eal_memalloc.c
> +++ b/lib/eal/linux/eal_memalloc.c
> @@ -16,6 +16,7 @@
>  #include <fcntl.h>
>  #include <signal.h>
>  #include <setjmp.h>
> +#include <inttypes.h>
>  #ifdef F_ADD_SEALS /* if file sealing is supported, so is memfd */
>  #include <linux/memfd.h>
>  #define MEMFD_SUPPORTED
> @@ -1447,8 +1448,8 @@ secondary_msl_create_walk(const struct rte_memseg_list *msl,
>  	local_msl = &local_memsegs[msl_idx];
>  
>  	/* create distinct fbarrays for each secondary */
> -	snprintf(name, RTE_FBARRAY_NAME_LEN, "%s_%i",
> -		primary_msl->memseg_arr.name, getpid());
> +	snprintf(name, RTE_FBARRAY_NAME_LEN, "%s_%i_%"PRIx64,
> +		primary_msl->memseg_arr.name, getpid(), rte_get_tsc_cycles());
>  
>  	ret = rte_fbarray_init(&local_msl->memseg_arr, name,
>  		primary_msl->memseg_arr.len,


Need to include <rte_cycles.h> to get the prototype rte_get_tsc_cycles()

      parent reply	other threads:[~2024-11-15 20:09 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-14  8:37 [PATCH] eal/linux: redefine the name for rte_fbarray_init() Congjie Zhou
2024-11-14 16:24 ` Stephen Hemminger
2024-11-14 17:06   ` Stephen Hemminger
2024-11-15  2:26     ` Zhou congjie
2024-11-15  5:32       ` Stephen Hemminger
2024-11-15  1:57   ` Zhou congjie
2024-11-15  2:00   ` Zhou congjie
2024-11-15  7:50 ` [PATCH v2] eal/linux: fix fbarray name with multiple secondary processes Congjie Zhou
2024-11-15 16:38   ` Stephen Hemminger
2024-11-15 20:09   ` Stephen Hemminger [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241115120920.6ae82b8e@hermes.local \
    --to=stephen@networkplumber.org \
    --cc=anatoly.burakov@intel.com \
    --cc=dev@dpdk.org \
    --cc=zcjie0802@qq.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).