From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id EB8B745D16; Fri, 15 Nov 2024 21:09:23 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D7D2743274; Fri, 15 Nov 2024 21:09:23 +0100 (CET) Received: from mail-pf1-f176.google.com (mail-pf1-f176.google.com [209.85.210.176]) by mails.dpdk.org (Postfix) with ESMTP id 3E3F14300D for ; Fri, 15 Nov 2024 21:09:23 +0100 (CET) Received: by mail-pf1-f176.google.com with SMTP id d2e1a72fcca58-71e592d7f6eso17787b3a.3 for ; Fri, 15 Nov 2024 12:09:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1731701362; x=1732306162; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=MAmNDSAdCzctwkQRaRlN46qHNJ/+khErF3Pas2gwZn0=; b=nQWXamOezjCCxvs84QDlxbWETYdrLfJzC6CsSh2F7kL4SszbEi3MGhW+3mOgyjtr3f fCqYI2x61FE6ay+eqf4AxF10a4c6jKSevCOHo4FbBHkk2KqK2/tO8UsV0WpIENKJi/kw BtvOjUqh78lPIDFXTj372g754da4qMGUJtsdVWfQOkS1MEevh336BUkW+rDUO8UkfHdF CW/a4cDtaLwC4EYIn4VLPZkcDQ4JNUX+TF6LvzFMyCuZptDl5vlgQDYF0JCsoJUAx3Gt 3b8B0pc2NsPms9bPmrOt3NrE9CaHIMJvi98ZMR3ZYrf5APcGbIcd246jICIuIjlntR86 j+rw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1731701362; x=1732306162; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=MAmNDSAdCzctwkQRaRlN46qHNJ/+khErF3Pas2gwZn0=; b=PO2O+dMf5F+KZHGh6htGi7N9ukQEgh7JICkbnc01YhHn+rcAY8/lh6UiQSb7XsETnA t8o2ObZp7JBaJF5l7w8nME5u0S+r37H/sob0Ki70jpFlZzVskcrTp0pZkP4QRvhNeVDJ tq4vmuMLTrlQfe4xP2Oq0tAiC8Om0y4SXCdrgCyGiSaxJAelyq09VDM4P4ShLxQN7mL2 j6x4EMY2ELCAuTcJVzdMVbtdJIKFI+AFCQ1tJDIHiitY2egeQsoykd7P9ZGVD0oFa6BW 21eHPeAS29KgvVZHiptSFNcz2hfyyPrPuTXi36xcKA8JHmBnMaBWNdaY6ML35ayVQaYV 3Hiw== X-Gm-Message-State: AOJu0YzZJfPMCAEWmdwVvGmabCYnY/PKC5gaeht1UDps+APzDQ1eZjIz atXaJWjwFlJCtFLfxWBND4dByp9jPXL/wBf0rJLIyeA5iYGLOsSXtaTp7TE3dem2mMJncTgvui9 7 X-Google-Smtp-Source: AGHT+IG1zcfvyaRTn4L+R+b23IHkqsLhmcQFrsyfhsw1sCkUnTEvsXn794Z19F4ZnKmB/bbYxu8vVw== X-Received: by 2002:a05:6a00:21cf:b0:71e:6eb:786e with SMTP id d2e1a72fcca58-72476bb87b0mr5746010b3a.13.1731701362215; Fri, 15 Nov 2024 12:09:22 -0800 (PST) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-724771e640esm1757925b3a.156.2024.11.15.12.09.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Nov 2024 12:09:22 -0800 (PST) Date: Fri, 15 Nov 2024 12:09:20 -0800 From: Stephen Hemminger To: Congjie Zhou Cc: dev@dpdk.org, anatoly.burakov@intel.com Subject: Re: [PATCH v2] eal/linux: fix fbarray name with multiple secondary processes Message-ID: <20241115120920.6ae82b8e@hermes.local> In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, 15 Nov 2024 15:50:08 +0800 Congjie Zhou wrote: > diff --git a/lib/eal/linux/eal_memalloc.c b/lib/eal/linux/eal_memalloc.c > index e354efc..367d401 100644 > --- a/lib/eal/linux/eal_memalloc.c > +++ b/lib/eal/linux/eal_memalloc.c > @@ -16,6 +16,7 @@ > #include > #include > #include > +#include > #ifdef F_ADD_SEALS /* if file sealing is supported, so is memfd */ > #include > #define MEMFD_SUPPORTED > @@ -1447,8 +1448,8 @@ secondary_msl_create_walk(const struct rte_memseg_list *msl, > local_msl = &local_memsegs[msl_idx]; > > /* create distinct fbarrays for each secondary */ > - snprintf(name, RTE_FBARRAY_NAME_LEN, "%s_%i", > - primary_msl->memseg_arr.name, getpid()); > + snprintf(name, RTE_FBARRAY_NAME_LEN, "%s_%i_%"PRIx64, > + primary_msl->memseg_arr.name, getpid(), rte_get_tsc_cycles()); > > ret = rte_fbarray_init(&local_msl->memseg_arr, name, > primary_msl->memseg_arr.len, Need to include to get the prototype rte_get_tsc_cycles()