From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B9BE845D16; Fri, 15 Nov 2024 21:08:15 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5525143291; Fri, 15 Nov 2024 21:08:07 +0100 (CET) Received: from mail-pg1-f175.google.com (mail-pg1-f175.google.com [209.85.215.175]) by mails.dpdk.org (Postfix) with ESMTP id C125E402C4 for ; Fri, 15 Nov 2024 21:08:03 +0100 (CET) Received: by mail-pg1-f175.google.com with SMTP id 41be03b00d2f7-7e9e38dd5f1so1747430a12.0 for ; Fri, 15 Nov 2024 12:08:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1731701283; x=1732306083; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=7DdZaXIun8eKC7Xc1tS/1drNMQCXbn81we0F5N/eFRs=; b=vkxAclKr6FJZtfLZkU8iXGVuJTIAFWsZRhI3uN+RZNAo7N4nrTR9y2t7rWqMRkgcpi TVBPz4qVbGzfNDc52U+6whbQqW3B7C0mofMWuXuF0UijiY0vo0bUoiENZXE7lQvfvcv4 Rau8HcIW+E/hmv9ggr0+b1UL68OFboDMrTDI+OBDKBdNgVaw5WU1bcHLs10vGHGOz2PQ plFqEg5FtZdA9DXqN9uTHzQoPSWCtHPLNXhMPI+RNNg6QB6QK38ASpxpfd2YjUeMwvUb F0YV0WFaabNC7mVJGhKtBs51TEVp33f2eRfHC7aUSgJTaGE+7v1pGLlQMRsq3kcMsmC4 wbjg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1731701283; x=1732306083; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=7DdZaXIun8eKC7Xc1tS/1drNMQCXbn81we0F5N/eFRs=; b=ki/WrvuCn7T1+Ad9f12QHSy7r9B/OYfS0sXh5nBU6PD58o+RUX8sLmlDfC8YuEGiUD tPj7CIuUC285DCvjD9DwpQGzjuWZCpf7Vc0WmTLPZxicPDmo1wgq42PA1AtDgJptLmdc F0v2ej1yN3JSuQL+mCnZLS9p+e8CPIUm0Nip8VIzofTa7BodX1vGyTzeHGwJNcJde3VM jBmDIwYK8QdYHhOxLygl7VhPS3D55rrk2cXyuCLn+LX+litaSnR3VC3L0sU8iGEV1e7S p5BpquZozfv847yvsl/PsrJI789BL9hwCdcBn3ZQcHHJfBFzN1t0qQ9ZWw21KLw5deXl RlSw== X-Gm-Message-State: AOJu0Yw1xblwdfvYASH9YuOM3JH1T7A/7H3aDWJ00Nq92BrQ0oXo+Tnb DwdbL+RqjTDxQVce4yKaGJ+XLatrJFJVSEDB39JwyYYx4F49y4v0Y3uEW6IGzUIhm3BF3rm2KYa w X-Google-Smtp-Source: AGHT+IHmwC3tNOEn3rV45Bxn2gBR5nU4x4XIR1jt2U9eXL34uChH/sn2aZcrbnCMQddsZc1C+xiTVA== X-Received: by 2002:a05:6a20:12ca:b0:1db:eff0:6ae7 with SMTP id adf61e73a8af0-1dc90bae872mr4422089637.33.1731701282966; Fri, 15 Nov 2024 12:08:02 -0800 (PST) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-724771e11f0sm1759686b3a.131.2024.11.15.12.08.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Nov 2024 12:08:02 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , declan.doherty@intel.com, stable@dpdk.org, Chas Williams , "Min Hu (Connor)" , Pablo de Lara Subject: [PATCH v3 02/10] app/test: fix typo in address compare Date: Fri, 15 Nov 2024 12:06:46 -0800 Message-ID: <20241115200751.17141-3-stephen@networkplumber.org> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20241115200751.17141-1-stephen@networkplumber.org> References: <20241114001403.147609-1-stephen@networkplumber.org> <20241115200751.17141-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org The first argument of 'memcmp' function was equal to the second argument. Therefore ASSERT would always be true. Link: https://pvs-studio.com/en/blog/posts/cpp/1179/ Fixes: 92073ef961ee ("bond: unit tests") Cc: declan.doherty@intel.com Cc: stable@dpdk.org Signed-off-by: Stephen Hemminger --- app/test/test_link_bonding.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/test/test_link_bonding.c b/app/test/test_link_bonding.c index 805613d7dd..b752a5ecbf 100644 --- a/app/test/test_link_bonding.c +++ b/app/test/test_link_bonding.c @@ -792,7 +792,7 @@ test_set_primary_member(void) &read_mac_addr), "Failed to get mac address (port %d)", test_params->bonding_port_id); - TEST_ASSERT_SUCCESS(memcmp(&read_mac_addr, &read_mac_addr, + TEST_ASSERT_SUCCESS(memcmp(expected_mac_addr, &read_mac_addr, sizeof(read_mac_addr)), "bonding port mac address not set to that of primary port\n"); -- 2.45.2