From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0F28B45CD8; Mon, 18 Nov 2024 19:22:17 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3E24C427A4; Mon, 18 Nov 2024 19:22:07 +0100 (CET) Received: from mail-pf1-f177.google.com (mail-pf1-f177.google.com [209.85.210.177]) by mails.dpdk.org (Postfix) with ESMTP id 6628141104 for ; Mon, 18 Nov 2024 19:22:05 +0100 (CET) Received: by mail-pf1-f177.google.com with SMTP id d2e1a72fcca58-71e49ad46b1so113099b3a.1 for ; Mon, 18 Nov 2024 10:22:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1731954124; x=1732558924; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=MhKczu3psgFhp00mj+aRRxI4AfpIT53of3BrkNx6V1k=; b=QWic48LBRns0STHORbIjTDMN1UI3pBj283kIPzSHtTpy4mAFdgVBy749XYjaryLsKF ERN873E1wzQmPvzuc5WzA3fs3SgBdSD5WBOyS8fXG+Uok5wX36Xn9tN/EiGXjcG/0So2 pnAxGxvEDwTvNVFgUU6a/LOsRAkgsVzTs0Jh9U9VZdY92yGKoWSrqDcktkTtBlNKrhMp MviIS+gyaT+nI9OkrUqa5zc9Ow/hHrdJFpLkpc3+7x1HQagvLMkW53+bQkpcA8WGmVyo vlIb4OTze8scdGUiM9R8xnxUHwyBpP6ootqVqEm1kQ2LRgUjKqKsLEOglvPK5SXxKTJH NaJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1731954124; x=1732558924; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=MhKczu3psgFhp00mj+aRRxI4AfpIT53of3BrkNx6V1k=; b=O+J9DmfhLhb96R6mPryMNJpvKUwtNVp3q4rn2+XtlM3N5qyYZSv713OuB1/WlDn+zm kl28+9cAQ9h3IE1lCj//p72tO7RWTaQZZjPeztwRJ4xT3RLO6bwtrHPo9tmVL+SS2eeS HJwlmlvfwJ8W6nw4UNSn5LSKvYrkmgNQqHJ3xJbDqhkOwkbI4zP++ZV1Fwgtydmf7QHz 1YLQh8Pvb0MKDG8P+4rXKoYISDPx/MrOsWow1YmOJ3YfexOSdTsJlGNdkLoGsyd3bIOA hZnrmbwl2RYulyj4TAxWL6LSkyBjXjWWyyLhrP0tTIHkqbXUP4Ti2fQIueEcKRna3hmF vx3A== X-Gm-Message-State: AOJu0YwSd+MJjwvwtrjzyeUCKvNUcFf2M4EUnJCb7dfYqu8pHEdcHds4 Qa3zu+QBOA3jWaXSAWbB+jUB//GS8YGlPlK6zDPdYbwi2/Teg3bFFPTG+6yw1KrfKytcblRV/VL q X-Google-Smtp-Source: AGHT+IHfdz9WGsDUW2ohe1qOM9YVdcrPw2/4nzM3GGjwt/AVBZFNLV1zC2uHwszPeWybqAsqYHQHZQ== X-Received: by 2002:a17:90b:380e:b0:2ea:356f:51b3 with SMTP id 98e67ed59e1d1-2ea356f5543mr12050627a91.9.1731954124587; Mon, 18 Nov 2024 10:22:04 -0800 (PST) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2ea61869bb2sm2916724a91.12.2024.11.18.10.22.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 Nov 2024 10:22:04 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger Subject: [PATCH v2 02/19] net/cpfl: avoid calling log (printf) with null Date: Mon, 18 Nov 2024 10:20:43 -0800 Message-ID: <20241118182153.87042-3-stephen@networkplumber.org> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20241118182153.87042-1-stephen@networkplumber.org> References: <20241115060738.313190-1-stephen@networkplumber.org> <20241118182153.87042-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org The log message would always refer to str variable which is NULL here. Looks like author intended to print original parameter. Link: https://pvs-studio.com/en/blog/posts/cpp/1183/ Signed-off-by: Stephen Hemminger --- drivers/net/cpfl/cpfl_ethdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/cpfl/cpfl_ethdev.c b/drivers/net/cpfl/cpfl_ethdev.c index 6f6707a0bd..1817221652 100644 --- a/drivers/net/cpfl/cpfl_ethdev.c +++ b/drivers/net/cpfl/cpfl_ethdev.c @@ -1580,7 +1580,7 @@ parse_repr(const char *key __rte_unused, const char *value, void *args) RTE_DIM(eth_da->representor_ports)); done: if (str == NULL) { - PMD_DRV_LOG(ERR, "wrong representor format: %s", str); + PMD_DRV_LOG(ERR, "wrong representor format: %s", value); return -1; } -- 2.45.2