From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5A1FF45D44; Tue, 19 Nov 2024 17:59:57 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 312764029B; Tue, 19 Nov 2024 17:59:57 +0100 (CET) Received: from mail-pl1-f178.google.com (mail-pl1-f178.google.com [209.85.214.178]) by mails.dpdk.org (Postfix) with ESMTP id E06474028B for ; Tue, 19 Nov 2024 17:59:55 +0100 (CET) Received: by mail-pl1-f178.google.com with SMTP id d9443c01a7336-20cdda5cfb6so41779225ad.3 for ; Tue, 19 Nov 2024 08:59:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1732035595; x=1732640395; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=+wYGY9ouege1ewp1Wy9nOtakqL6u03996mYdf8VPIcc=; b=xA3y7Iqqk8yd+IJh87MrBfB/jVaM2irV2Wkq8d3rcJUmcV4/zr+hrDCG9Lh8qnRoTs JuBMxbon9Mz0eGpABaKsFaARxRkUGXBYsfWZeR7Jz6xVwT0NoKnm5lO4b0R3GD0pS/C3 uMj7tCyvRaK9YTF6FfAOrfZ6GKJDaO3Fwi8czzU8V1msPAQ33z1ad/TW2ENo8lMLUlU7 O2vKpKh8FseNK+pcvOG+CWbKP3nsF2Pxc3gRfIOeBNjFHdQmX56c8ZyBhMTz/zBqB3e3 b9U4x8WravF1gOSx1Rc6pjzoWrKsLqJ3hn3vxRdBDf1cZRslYEe/JetSm1d0hXKTUNQ4 3rvg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1732035595; x=1732640395; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=+wYGY9ouege1ewp1Wy9nOtakqL6u03996mYdf8VPIcc=; b=NzZfAdGRqY8llEXtfZg20usbx+UxAwcqYTlcb/aS543Lco86Utv5IIJGgce5S2iQQU WWNJylqo7GMydWrUmWN7smtN910avnHpIT05dzE+e/JHKJXtRmA2uF4jAHj2SZCFgYqr 2puC6jl8Q3omtl47+fbj+EFlQZr3hrQteTgymHEAhHYDdC3Vu0QufyqXxRiRypbVka6o W6Pn6UwkoJ2ZBxGOsPdBYVKfGNZZAHtsTzW2uoMtWe35bLnJxgYbWO6ITIkRpd514Ath CJjnrD//oJGyCD4J7PXITq5GEM45vlBKXMzh36GA7+yL5NvetDDf14yt3sqPK7gSL0Ax I6HA== X-Forwarded-Encrypted: i=1; AJvYcCUxhSF10ECQH8Vr+th9YxzWKvc4U+JBF9t6qLTVxJ5IBbiImaInEbl2SJhJuFMlfa/qRHQ=@dpdk.org X-Gm-Message-State: AOJu0YxIPKlpZBCd1vRAkVuHZLJEr4MXqNpvpFMVFCfhPKwIayk8q4IZ dhFcJgESyou72LIYrjDSmMpxL7ouwiRo9vqEEZviuYCkkpeqo/vgmLNphVi4/rw= X-Google-Smtp-Source: AGHT+IH0YRZhyCOYMwajeoc6Nndg4Y9km7xlAYiTiDUXN+z1LYT/p0QMZEAi+RKPd2dclIAntUkpFg== X-Received: by 2002:a17:902:cec6:b0:20c:5e86:9b53 with SMTP id d9443c01a7336-211d0d5ec21mr235653535ad.3.1732035594627; Tue, 19 Nov 2024 08:59:54 -0800 (PST) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-211d0f344cfsm74836405ad.120.2024.11.19.08.59.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 Nov 2024 08:59:54 -0800 (PST) Date: Tue, 19 Nov 2024 08:59:51 -0800 From: Stephen Hemminger To: Mattias =?UTF-8?B?UsO2bm5ibG9t?= Cc: Andre Muezerie , dev@dpdk.org Subject: Re: [PATCH v7 19/21] test: remove use of VLAs for Windows built code in bitset tests Message-ID: <20241119085951.01e04f2f@hermes.local> In-Reply-To: References: <1713397319-26135-1-git-send-email-roretzla@linux.microsoft.com> <1731376933-19275-1-git-send-email-andremue@linux.microsoft.com> <1731376933-19275-20-git-send-email-andremue@linux.microsoft.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, 19 Nov 2024 11:16:04 +0100 Mattias R=C3=B6nnblom wrote: > On 2024-11-12 03:02, Andre Muezerie wrote: > > 1) MSVC does not support VLAs. Use standard fixed C arrays of > > maximum size required instead. > >=20 > > 2) ../usr/lib/gcc/x86_64-redhat-linux/13/include/emmintrin.h:742:8: > > error: array subscript 9 is outside array bounds of 'uint64_t[16]' > > {aka 'long unsigned int[16]'} [-Werror=3Darray-bounds=3D] > > 3695 742 | *__P =3D __B; > >=20 > > Compile with -Wno-array-bounds to avoid false positives when > > using gcc version 11 or newer (gcc compiler bug/limitation). > >=20 > > Signed-off-by: Andre Muezerie > > --- > > app/test/meson.build | 5 +++ > > app/test/test_bitset.c | 55 +++++++++++++++++++-------------- > > app/test/test_lcore_var_perf.c | 2 +- > > app/test/test_reassembly_perf.c | 4 +-- > > 4 files changed, 39 insertions(+), 27 deletions(-) > >=20 > > diff --git a/app/test/meson.build b/app/test/meson.build > > index 40f22a54d5..e7419a611b 100644 > > --- a/app/test/meson.build > > +++ b/app/test/meson.build > > @@ -249,6 +249,11 @@ foreach d:optional_deps > > endif > > endforeach > > =20 > > +# Bugzilla ID: 678 =20 >=20 > Mention which bugzilla. >=20 > > +if (toolchain =3D=3D 'gcc' and cc.version().version_compare('>=3D11.0.= 0')) > > + cflags +=3D '-Wno-array-bounds' > > +endif > > + Do not turn off warnings globally, better to reduce this down to minimum scope with pragma instead.