From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2450B45D45; Tue, 19 Nov 2024 19:27:10 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1119D40289; Tue, 19 Nov 2024 19:27:10 +0100 (CET) Received: from mail-lf1-f53.google.com (mail-lf1-f53.google.com [209.85.167.53]) by mails.dpdk.org (Postfix) with ESMTP id 43AAB40274 for ; Tue, 19 Nov 2024 19:27:08 +0100 (CET) Received: by mail-lf1-f53.google.com with SMTP id 2adb3069b0e04-539f84907caso1735064e87.3 for ; Tue, 19 Nov 2024 10:27:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1732040828; x=1732645628; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=qg5/jmR3PwyE1UV9ZfqeCt6aGYebiwil8OGHZJEpGWw=; b=TGJbiJeSehAU+kxuxGQruXMSVJAD1qtq8m+1RH7d6kG2bf0EvM1DktmTXgbVNteSZr XC/5mzGGpYL/ZAxPrOlpcL0fiRw1sebtTfbVfIYy8bWLKDFxKtBFlVDs0IdSq6lkqGCs /dTMsE1lir3+6lP1XBDE7khzmyz0gtv74ApxW741Eedf2BMEko9EiG2X04UzewPDJ7bM NrX2qycWSLV4EVTlJ8OqpMg6l2xxo83vWdQpwDvaEVUOllFKJnqM9gCaZPlLs322kpTn glKqai8Vqy7WGkR/Ae8DlSHWvxX5reywy2UfMoUkbmcpSF52906jIAQGaH8PwTl3nWQI XmkA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1732040828; x=1732645628; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=qg5/jmR3PwyE1UV9ZfqeCt6aGYebiwil8OGHZJEpGWw=; b=wZZrziJsZP4ZPjSjy/gBNvYwIW8JldU4En/Hzh99rhvYdaKfKoH18w8WTdOe1rcQyW eysHR/G1m3RI4ohQaRebcJrCEBI84JoPwXFG3M6fkPuPdDwRWW7l+CPGo8VzJMt0Sw83 P4C/2BPWyCT9lqm1ffQ3/FZK0WubKMW7WTOUFre7LEgwgQ9N4VuuwhF6rdnlUreU+csu qDKYBeNgi+vBSFtMq5K1EiuF6ydkmv+SmXeT+/CxXqI3iPQ8X6UPFVkSC2iZpp9rVRRq 81EGLUUUuZwX0ygMCFX720NFwyOD7bGYgQAx2IpKZll6IY+mA/bqBvbheF1AqN+nP7Xz V2YQ== X-Forwarded-Encrypted: i=1; AJvYcCUJT1r0Cr4f7u7TvNjBdMOBwMNzd7Lrgpg3H2M5hhHFQ1yzg5IPEGA6HDt2geLtMkSfS0w=@dpdk.org X-Gm-Message-State: AOJu0Yx1hVNHfz7f4uwwQToUaK4y/6mT40yl1y178fiuBbajEyzSzsZ1 YgofkhuSDr3C3/7Nl35GuyPG7ygHdlBD87RPCysNb+vAmWEnWGqD X-Google-Smtp-Source: AGHT+IF0EorNiVuXgOrNvnbG8iMv8cTySy/c1UwyoK5qRdNnyKIDsfBCq/uBPf+HEVdE+qZjzOZi4Q== X-Received: by 2002:a05:6512:2384:b0:53d:a9ab:2953 with SMTP id 2adb3069b0e04-53dab29cae8mr8125658e87.14.1732040827316; Tue, 19 Nov 2024 10:27:07 -0800 (PST) Received: from sovereign (broadband-109-173-43-194.ip.moscow.rt.ru. [109.173.43.194]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-53dbd467391sm362270e87.122.2024.11.19.10.27.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 Nov 2024 10:27:05 -0800 (PST) Date: Tue, 19 Nov 2024 21:27:03 +0300 From: Dmitry Kozlyuk To: Bruce Richardson Cc: Lewis Donzis , dev , Anatoly Burakov , Stephen Hemminger , Morten =?UTF-8?B?QnLDuHJ1cA==?= Subject: Re: [PATCH v2 1/2] contigmem: support including mapped buffers in core dump Message-ID: <20241119212703.0dc6c9b0@sovereign> In-Reply-To: References: <20241023231859.1323727-1-kozlyuk@bifit.com> <20241025202615.2581513-1-dmitry.kozliuk@gmail.com> <20241025202615.2581513-2-dmitry.kozliuk@gmail.com> <1865717992.9940628.1729942988633.JavaMail.zimbra@donzis.com> <20241028162606.48381738@sovereign> X-Mailer: Claws Mail 3.18.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 2024-11-19 15:48 (UTC+0000), Bruce Richardson: > On Mon, Oct 28, 2024 at 04:26:06PM +0300, Dmitry Kozlyuk wrote: > > 2024-10-26 06:43 (UTC-0500), Lewis Donzis: > > > Is the extra control necessary, i.e., why not just always do this and let > > > the EAL option control whether the pages get dumped? > > > > I've been evaluating your suggestion and see no downsides, > > except contigmem default behavior change, but does it have non-DPDK users? > > If no one objects, I'll prepare v3 doing the following: > > 1) everything from v2, > > 2) except always mark contigmem buffers as dumpable, > > 3) add --dump-mapped back and make DPDK disable dumping by default. > > As a result, in order to include mapped memory in coredump: > > * FreeBSD will require only "--dump-mapped"; > > * Linux will require both "coredump_filter" setup and "--dump-mapped". > > That all seems very reasonable, but it is late in the release cycle at this > point. Do you think it would be good to just take the v2 as is for 24.11, > and then change things thereafter to have more dynamic/runtime control of > the dump-setting in 25.03? > > From compatibility viewpoint, I don't think there are any non-DPDK users, > so if behaviour with EAL doesn't change, I don't think having the kernel > module default be different matters as we go from one release to the next. If you think it is worth adding to 24.11, then by all means. V2 works as intended and it solves Lewis' problem. I wasn't rushing with v3 just because I knew that new EAL options can only target 25.03 since 24.11 RC was out already.