From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E575745D55; Wed, 20 Nov 2024 18:12:19 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0B64540285; Wed, 20 Nov 2024 18:12:19 +0100 (CET) Received: from mail-pg1-f172.google.com (mail-pg1-f172.google.com [209.85.215.172]) by mails.dpdk.org (Postfix) with ESMTP id E3F184021E for ; Wed, 20 Nov 2024 18:12:17 +0100 (CET) Received: by mail-pg1-f172.google.com with SMTP id 41be03b00d2f7-7e6cbf6cd1dso12966a12.3 for ; Wed, 20 Nov 2024 09:12:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1732122737; x=1732727537; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=ltCGu4oC8N1Yfm+mfAlDzhVdrOLUfqKjS175t5XqOoU=; b=2BwYVUiJogWlSo4zrA4e84uQZ11dScEO91IWoW8xV4SNnAMikLabwYSB+mqdCXZEP6 Rcl8Fc8cQaOD9xZzgT7s62Q5ldWNHqNB9mdYo3KquOIr0ADYsLUfE3973uCl5OKChPT6 e1nN58/Yl0aiRiXt4CvH7UsTsPy3dE0xGqUToCy+4Q9l8pM3geMiYD0tDl63HB+BnHa/ VJCdKCvyyjxuHEHUrPXxmfMnGc/7TPAPdrJBc8EoFU81BGCYYnkuANS/LgK/jFqGKpV3 eKOnNrAi/LxV85arEtrsbcW2uvrHqQMrZYol6tijsKIueCixZTbHz/5bbpYTGH13PEfO Yfxw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1732122737; x=1732727537; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ltCGu4oC8N1Yfm+mfAlDzhVdrOLUfqKjS175t5XqOoU=; b=n6GL8jU1VxgjSAR4zLdbyLmMUZhiH4843MO6xrf8Wj2AafF2fKdU9mZx761ydrXOdd wYN2XygWyxMkDwzUkGqoNn09X6bDg6kMSpIXfsINpbjA5RQ6BlBbmTLZB876w4JMvBIU E7BGA+jYhgRquZOEETxnOxk3oQmYOFY1vt0RO1irI2pjOP6jUAhCinkgsZwHVzTMFBoz YwOON9iCm8V7Z6SunFYRN85MobG2b4uFAvu9IkzSs91/U8mNcMiu7VRX5ynuLqikyxFp Z+t5x7UfjmdgRZ1CEWBm9XRbhzXl2IWLY/pc0dfEc8F4st8A2UAjGpmeQ0Mllh4NCEsm K1UA== X-Gm-Message-State: AOJu0YwusN+DS62WJ2p0l9Jst+XLntGjncdfXjqAjORuI3ozx6VWgO0P TQMyFyzKk/ZNO+T9KZpx7nKn39bzziwiUfo6TpLfXARAmGZWEkq28ss7AmpQ2qwO7Hc3/C4A/ip A X-Google-Smtp-Source: AGHT+IHbf+xPKjoXL8xQ51Odcsn6ajWNzDLe2/mPk+5Cep6wt7NLn99xImg2lfJ5Q4Fj2VVnF1YNFg== X-Received: by 2002:a05:6a21:6d8a:b0:1db:e82e:c802 with SMTP id adf61e73a8af0-1ddb0625130mr5683819637.41.1732122736984; Wed, 20 Nov 2024 09:12:16 -0800 (PST) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-724befe718csm1890556b3a.176.2024.11.20.09.12.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 Nov 2024 09:12:16 -0800 (PST) Date: Wed, 20 Nov 2024 09:12:15 -0800 From: Stephen Hemminger To: Andre Muezerie Cc: dev@dpdk.org, Tyler Retzlaff Subject: Re: [PATCH v10 01/21] eal: include header required for alloca Message-ID: <20241120091215.23f9c32e@hermes.local> In-Reply-To: <1732072401-15962-2-git-send-email-andremue@linux.microsoft.com> References: <1713397319-26135-1-git-send-email-roretzla@linux.microsoft.com> <1732072401-15962-1-git-send-email-andremue@linux.microsoft.com> <1732072401-15962-2-git-send-email-andremue@linux.microsoft.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, 19 Nov 2024 19:13:01 -0800 Andre Muezerie wrote: > From: Tyler Retzlaff > > Include alloca.h for Linux and malloc.h for Windows to get declaration > of alloca(). > > Signed-off-by: Tyler Retzlaff > --- > lib/eal/linux/include/rte_os.h | 1 + > lib/eal/windows/include/rte_os.h | 1 + > 2 files changed, 2 insertions(+) What about FreeBSD? https://man.freebsd.org/cgi/man.cgi?alloca Looks like to be pedantic stdlib.h should be included there.