From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 46AB945D55; Wed, 20 Nov 2024 18:20:34 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E34FC42FAB; Wed, 20 Nov 2024 18:20:33 +0100 (CET) Received: from mail-pg1-f178.google.com (mail-pg1-f178.google.com [209.85.215.178]) by mails.dpdk.org (Postfix) with ESMTP id 88E3542FA1 for ; Wed, 20 Nov 2024 18:20:32 +0100 (CET) Received: by mail-pg1-f178.google.com with SMTP id 41be03b00d2f7-7f8cc29aaf2so17083a12.3 for ; Wed, 20 Nov 2024 09:20:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1732123231; x=1732728031; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=FXd0Ham7HmU6aEZKpwFRoqjFj8T3nocz9CR0D8dtGYM=; b=wYf+0PYU66YWmR9396S/mkBwvLQIqNlzFk9G2jUwJ6gbthfEuBwFnrcOQbfN7tOZ1I PQ+TEiV3tl6oQAYQj8nxelNlIGsltcsdDQW/iM5iiOucy5y2if5a9eqBkdV+JVBFePLf rib42KtMjnh0VLsGLapbqp/V53v95LWa9frIHOJv/cLerqWrMOQJtwdRqoFUYHbu3+q5 EGch/2yx1wSSEd9og2AWo5H4xPiDs7nta5NXK+b5+ILyAjsRixb+/CAUMAwzgJSlsuFS GSeAnIq4brVk1Dg/J0i81hKwW31sYnS7lyQp8pGkUkBnOnnDUjhHChpIOtJOLftHHJIR DeFA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1732123231; x=1732728031; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=FXd0Ham7HmU6aEZKpwFRoqjFj8T3nocz9CR0D8dtGYM=; b=NVhMyogpgTUc0wrfBeLD/2fHcG3cZRRkPAwtfOLLRBKfbhyIAgOHiJeS9foZJa5JVj iGD6ydphGLa3FMbfuNvAxkyal1KPH+hGqBZYHjdnztQ1mD4zByL3ukPFaECbGSWMajt9 tSUp+goidee9fpxbzTwyPg1rr4EQCZuY+AlldUVc2Z0eBVE4+7IMZJylNv81soM3WY6B HZ9PL4n92SqPyrcsKgsy4TAWXtJwIBRLCzDh2w7K1t9ZL16iT7GGpcg4u1Jbf5rAWOtz KL4up9IDasS1+H3cIjK8x4kGlQ5EsQ2gnD8XNAOyq+9lF/PH4nKd2YgKJ6MUyDd5bH+/ FxIQ== X-Gm-Message-State: AOJu0YzczfB95vUqxJ31dQurPvAZ/19IQRCHMmR/TwS3iP5f380NW5Tk GcBbhQnIA+ehH3j8/SOnAFjAuZ5DoLULqDXvDrjhxtpAeo93dM+rV7uZjohkxbY= X-Gm-Gg: ASbGncvc3/PhC1ubk++ZrNmsTNKVCOiWKOi7QIO+dv9Ud9//IRIe3UOlcps8lsablR2 TmXZfcKFtOttDFH3Z4f9uu95+Uiru6uJyGrbrApPkjelcxLckHjDTeP6YU68rTppqvTTowy8sqN bxYH2a72gLb8BHrS/Aew4PyTh6chrGfCkMWo4wo575dJuk4KNasaFczZpXaHaYafhIBpBo9XyRt RXDEcTJZAmJsdotOnFYS9wo65LPSC0ZOcgfPdg69MdXg0lfdjmGOuPRzxq/tmNVAd9zSODk8N6r vZ4VoCHvcQSsPYEtUvGrJD+wheY= X-Google-Smtp-Source: AGHT+IF7QYYHqzmzKiAKKE0/2uCP+cL3RX05i3JYzOJ2zfUpCBJqudnnD9Y/MlfvIf5VPfT3iz8KPQ== X-Received: by 2002:a05:6a20:7290:b0:1d6:e635:5c5e with SMTP id adf61e73a8af0-1ddae1fa5b5mr5544731637.9.1732123231503; Wed, 20 Nov 2024 09:20:31 -0800 (PST) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-724beefef5dsm1903225b3a.51.2024.11.20.09.20.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 Nov 2024 09:20:31 -0800 (PST) Date: Wed, 20 Nov 2024 09:20:29 -0800 From: Stephen Hemminger To: Andre Muezerie Cc: dev@dpdk.org, Tyler Retzlaff Subject: Re: [PATCH v9 18/21] build: enable vla warnings on Windows built code Message-ID: <20241120092029.2baa1d1e@hermes.local> In-Reply-To: <1732067686-5938-19-git-send-email-andremue@linux.microsoft.com> References: <1713397319-26135-1-git-send-email-roretzla@linux.microsoft.com> <1732067686-5938-1-git-send-email-andremue@linux.microsoft.com> <1732067686-5938-19-git-send-email-andremue@linux.microsoft.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, 19 Nov 2024 17:54:43 -0800 Andre Muezerie wrote: > From: Tyler Retzlaff > > MSVC does not support optional C11 VLAs. When building for Windows > enable -Wvla so that mingw and clang also fail if a VLA is used. > > Signed-off-by: Tyler Retzlaff > --- It would be good to catch VLA's in new code even if not on Windows. Some parts like testpmd and eal should have it enabled