From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8F98145D55; Wed, 20 Nov 2024 18:01:06 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5361540E36; Wed, 20 Nov 2024 18:01:06 +0100 (CET) Received: from mail-qk1-f170.google.com (mail-qk1-f170.google.com [209.85.222.170]) by mails.dpdk.org (Postfix) with ESMTP id 4FE924021E for ; Wed, 20 Nov 2024 18:01:04 +0100 (CET) Received: by mail-qk1-f170.google.com with SMTP id af79cd13be357-7b1b224f6c6so329537985a.3 for ; Wed, 20 Nov 2024 09:01:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1732122063; x=1732726863; darn=dpdk.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=eZodZpPdwwx9Mx8Xv0JgQBDHgvZACvnaxQVyFBQy9Uk=; b=FC2KOBXrnyGzzez8mOwDSTIYnxRLkxb2NrBPn3xGEkyyteOPf8WY609NWDDIALLD5f erLgr/6KL7AFvtKY5IcQDICQZD5NeVs/cnrwiZDWLyE6mE1xlIPthbvyBp04ORxOxNLw DqgnGil3ica4JImDESSrEvmAUwkZDHmToDYSQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1732122063; x=1732726863; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=eZodZpPdwwx9Mx8Xv0JgQBDHgvZACvnaxQVyFBQy9Uk=; b=ERMxpdXpXFJlKd+NH0Q57pl126C4rdFRWUzP1cNT+FbmjjYTvyj3gCG+ygM7kXdCzL mKazYYIjFpQCoeZMSy/OgrReC8I5mPGHynNJK4jWRh/nQ/c73S+XFivEXKd5gy5hY93v v7pgB/mD17YdjjGQUKxP6QoKqvJZD6ojcPK2e305l0jOECpAgcRlLyDIaHd1VVPIwRLV r+kQXuz1SI+OtEHj5FImTlmQl5VsSpUqbEUb2iwipDcRJ6ML3FKiRLNo6PZln2nx/64b uCr6IzFkB3DBKJ+9na9ZszMJvEpXw0OTOQnVK2cCxH0tP1lLFWk3/WlecZMaW1XDdpmF 51iQ== X-Gm-Message-State: AOJu0YwGx5iXmq1JChX5lMlfED8hrII/dqzhKknIyfZ0NC3IsTyF9DeJ 3MrbWBdFA5Cq2EB5NTJOLJ7/wcbAT6fmg3VGNCBJn/ewpbn0AH8vZ6que/IxXjU7Ws25qetVsnG cYHRKMkOyLn3uaHzKp7qKmLE/LhQv9aXTEZKhKeLmvL2OFOibH7nMcZ96x9QerN7UeeVE7rfxQR smV8p123mgSRXYa/QxcjSD7S7KGWrx X-Google-Smtp-Source: AGHT+IEJxhOsWYQVHtKSLJYlTK2Ef9gV1kxw9qiwjtn8CtBp9lJR2jtsugvDfcdLqgGP5p4eUyVUqw== X-Received: by 2002:a05:620a:718a:b0:7b1:7f5f:4988 with SMTP id af79cd13be357-7b42edd0f4bmr385514285a.36.1732122063248; Wed, 20 Nov 2024 09:01:03 -0800 (PST) Received: from C02GC2QQMD6T.wifi.broadcom.net ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7b479d2e0b9sm116750285a.13.2024.11.20.09.01.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 Nov 2024 09:01:02 -0800 (PST) From: Ajit Khaparde To: dev@dpdk.org Cc: Kishore Padmanabha , stable@dpdk.org, Jay Ding Subject: [PATCH] net/bnxt: fix segmentation fault Date: Wed, 20 Nov 2024 09:00:58 -0800 Message-Id: <20241120170058.18742-1-ajit.khaparde@broadcom.com> X-Mailer: git-send-email 2.39.5 (Apple Git-154) MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: Kishore Padmanabha The mbuf offload flags were not reset before the flags were populated with the received packet details. This causes certain applications to act differently on the offload flags. That can cause applaction to assert at many locations. Fixes: 65d2b0557ba3 ("net/bnxt: support Rx completion v3") Cc: stable@dpdk.org Signed-off-by: Kishore Padmanabha Reviewed-by: Jay Ding Reviewed-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_rxr.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/bnxt/bnxt_rxr.h b/drivers/net/bnxt/bnxt_rxr.h index 5e5496964f..7357ca4427 100644 --- a/drivers/net/bnxt/bnxt_rxr.h +++ b/drivers/net/bnxt/bnxt_rxr.h @@ -535,6 +535,6 @@ bnxt_parse_csum_v3(struct rte_mbuf *mbuf, struct rx_pkt_cmpl_hi *rxcmp1) uint16_t error_v2 = rte_le_to_cpu_16(v3_cmp->errors_v2); uint32_t flags2 = rte_le_to_cpu_32(v3_cmp->flags2); - mbuf->ol_flags |= bnxt_parse_csum_fields_v3(flags2, error_v2); + mbuf->ol_flags = bnxt_parse_csum_fields_v3(flags2, error_v2); } #endif /* _BNXT_RXR_H_ */ -- 2.39.5 (Apple Git-154)