From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 01D4345D6B;
	Thu, 21 Nov 2024 19:11:16 +0100 (CET)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id E17E240A81;
	Thu, 21 Nov 2024 19:11:15 +0100 (CET)
Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182])
 by mails.dpdk.org (Postfix) with ESMTP id 27D5540A6B
 for <dev@dpdk.org>; Thu, 21 Nov 2024 19:11:14 +0100 (CET)
Received: by linux.microsoft.com (Postfix, from userid 1213)
 id 47AEC205A777; Thu, 21 Nov 2024 10:11:13 -0800 (PST)
DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 47AEC205A777
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;
 s=default; t=1732212673;
 bh=2Y/eRoopOOwVvpMwRmv511CqD6I6CPyaTtayupS7vd8=;
 h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
 b=ZPjZNtYG4hLRc3iPI7WTNvLOYEXuX/UOZaHLKjvkakcNkk3WbXtXX2fhdV7xjOuJR
 7nBoa8c1JGx19fHwQxYj8Rdb3Bko7SExXs1EtS39mVdb0YOQLEFEmdH5ja8rXXoliE
 7QpEu5tGTdUjL7ptymf0aT2XHNvwIU2KfNi14zQQ=
Date: Thu, 21 Nov 2024 10:11:13 -0800
From: Andre Muezerie <andremue@linux.microsoft.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: dev@dpdk.org, Tyler Retzlaff <roretzla@linux.microsoft.com>
Subject: Re: [PATCH v9 18/21] build: enable vla warnings on Windows built code
Message-ID: <20241121181113.GC22492@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net>
References: <1713397319-26135-1-git-send-email-roretzla@linux.microsoft.com>
 <1732067686-5938-1-git-send-email-andremue@linux.microsoft.com>
 <1732067686-5938-19-git-send-email-andremue@linux.microsoft.com>
 <20241120092029.2baa1d1e@hermes.local>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20241120092029.2baa1d1e@hermes.local>
User-Agent: Mutt/1.5.21 (2010-09-15)
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

On Wed, Nov 20, 2024 at 09:20:29AM -0800, Stephen Hemminger wrote:
> On Tue, 19 Nov 2024 17:54:43 -0800
> Andre Muezerie <andremue@linux.microsoft.com> wrote:
> 
> > From: Tyler Retzlaff <roretzla@linux.microsoft.com>
> > 
> > MSVC does not support optional C11 VLAs. When building for Windows
> > enable -Wvla so that mingw and clang also fail if a VLA is used.
> > 
> > Signed-off-by: Tyler Retzlaff <roretzla@linux.microsoft.com>
> > ---
> 
> It would be good to catch VLA's in new code even if not on Windows.
> Some parts like testpmd and eal should have it enabled

That sounds like a good idea for further improvement. I would like
to keep that out of scope for this series though, so that other work
can be unblocked, if that is OK.

Regards,
Andre