From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id A8EDA45D6B;
	Thu, 21 Nov 2024 19:26:49 +0100 (CET)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 9772F40A81;
	Thu, 21 Nov 2024 19:26:49 +0100 (CET)
Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182])
 by mails.dpdk.org (Postfix) with ESMTP id A9CDA40A6B
 for <dev@dpdk.org>; Thu, 21 Nov 2024 19:26:47 +0100 (CET)
Received: by linux.microsoft.com (Postfix, from userid 1213)
 id CECE1205A76E; Thu, 21 Nov 2024 10:26:46 -0800 (PST)
DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com CECE1205A76E
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;
 s=default; t=1732213606;
 bh=dA3SiZq+ax0FviwZVTu05Qe+QeATOwg3YdgUkpXwCBI=;
 h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
 b=AAdXyZxbJbpvv5AsXSbAn/0ObnO1qaJCSTtP0xQBO2UW6m+yj/oSJJvVHeGCK0efz
 PGKoCMx3YIGW+ZkGNv3mMAdHQ5w2hRZX2R94B6L93JLindSpqIwzy6+DkME2noHnKy
 YL0RcsdJSBeZwd95vI6lCkjKNSgHVEXCTl5l3DDY=
Date: Thu, 21 Nov 2024 10:26:46 -0800
From: Andre Muezerie <andremue@linux.microsoft.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: dev@dpdk.org, Tyler Retzlaff <roretzla@linux.microsoft.com>
Subject: Re: [PATCH v10 01/21] eal: include header required for alloca
Message-ID: <20241121182646.GD22492@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net>
References: <1713397319-26135-1-git-send-email-roretzla@linux.microsoft.com>
 <1732072401-15962-1-git-send-email-andremue@linux.microsoft.com>
 <1732072401-15962-2-git-send-email-andremue@linux.microsoft.com>
 <20241120091215.23f9c32e@hermes.local>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20241120091215.23f9c32e@hermes.local>
User-Agent: Mutt/1.5.21 (2010-09-15)
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

On Wed, Nov 20, 2024 at 09:12:15AM -0800, Stephen Hemminger wrote:
> On Tue, 19 Nov 2024 19:13:01 -0800
> Andre Muezerie <andremue@linux.microsoft.com> wrote:
> 
> > From: Tyler Retzlaff <roretzla@linux.microsoft.com>
> > 
> > Include alloca.h for Linux and malloc.h for Windows to get declaration
> > of alloca().
> > 
> > Signed-off-by: Tyler Retzlaff <roretzla@linux.microsoft.com>
> > ---
> >  lib/eal/linux/include/rte_os.h   | 1 +
> >  lib/eal/windows/include/rte_os.h | 1 +
> >  2 files changed, 2 insertions(+)
> 
> What about FreeBSD?
> 	https://man.freebsd.org/cgi/man.cgi?alloca
> 
> Looks like to be pedantic stdlib.h should be included there.

Indeed. I'll include it.
Is FreeBSD tested when a patch is submitted? I did not see it in the list
of OSes/distros tested. I'm asking because it's always possible to break
something inadvertently if not tested.

Regards,
Andre