From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5E8E445D7D; Fri, 22 Nov 2024 18:11:00 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4ECCB402CE; Fri, 22 Nov 2024 18:11:00 +0100 (CET) Received: from mail-pf1-f179.google.com (mail-pf1-f179.google.com [209.85.210.179]) by mails.dpdk.org (Postfix) with ESMTP id 08485402C3 for ; Fri, 22 Nov 2024 18:10:59 +0100 (CET) Received: by mail-pf1-f179.google.com with SMTP id d2e1a72fcca58-724e7d5d5b2so656922b3a.2 for ; Fri, 22 Nov 2024 09:10:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1732295458; x=1732900258; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=gVh02WjBHde6PbXRIjKcpjO5yl4LLek1FeiBggbxG4U=; b=NRQT2iC7WAa0WqmD6jpiT4bRZw3vgtz3QNuebSnchXFOUSjWLN3+x/u0Xqlz8ZAgP3 lVwi2G7ZdViLqaEnnCqn3ZSiKCAihp3kh6822k66wh2nEXF5bGg9LMyIZYZZVhnrtmIl dDOFN4ekBFXCasc39BnUa4H8I3KiiDNGxq19yYSrh1Ur+DfkDzpJGOZf+59zy/f1n8j1 FP5Yq9El+jJYJFZsThSQs5Xe8cyO525Q0ax/bE4HTMfG7PTV5b+hh1isK16yIl1J+ub9 dTj1TVR+VACgbbhpiBmdzPbzjMc6nBNC17iHg8+9PyvvxtzG0HiBCG/CaxDeuPzB5QSZ ETIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1732295458; x=1732900258; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=gVh02WjBHde6PbXRIjKcpjO5yl4LLek1FeiBggbxG4U=; b=uaVHz13yAhxH5tLK7FGIWuXX7zoWkZoCL0OQAgZ1TnAiwcexB6I3z8JhWDVof/FupG tUlSgXB3HIdh7j9UTCIgvxX4Z612eiILGi5hZKcWfCKjnb3arMVNKZbo+gv5aC+wuueu PEIX9V0ZpK0oqCLe12RQu+aUqlWRbPH47v1FVzCqXt/4yovea/08/A9aGNuOJ5AQV578 2LxOiQSzn0zq/qN6Jf/eFcqcx04BNnck2hiiR5t9Iag8xf1fHkMM3m1frIwbFt4h08ZN 3k8GkYqu5N4BouNiV3xBqpTwRsBk+BkcravgMc3Yw6R0pcloGjRI+q89RGR4gbfpJfny eusA== X-Gm-Message-State: AOJu0Yx1WmXkaCIw3CPORQiL1VO3o0kXUuTRkSSI9Xj+BSNQPjYyvUlG llvh07xJuMV24pMelEcwztlMDRnrD2Yho3JT8rTIyBd5ZQq0jVwAhn9/g9VWkU8= X-Gm-Gg: ASbGnct1MES/2Rpt03lm1a7jltx5oCK4Nos1MYYdsUhiCG9MW+K2+YZM1czSjtAV2U8 je/kFP+wrzS8Bn0GW41oiR+Y8eSAg9bjcYaQyEejDvyXDWCWJe5E7SE/cOU1HGp7Bz4buPAIU68 Nf3nSzgECZNxw+S2fuWqu1QHVw7zMxRFa3apDWGdhQlZ8JF8uZB4TN8QR6AXB8sKGF+tEzUcDaW EYXWbexuaNuRGwghXoocC5jnLKfxztdZlCu59DN40bU7YKIwAAwmjZU5JQFYjNvxGG7qnzSDGwK 4BY0ftmbOB8j4KMqNDZTS2oSXi4= X-Google-Smtp-Source: AGHT+IF5hx4v+ZOR7KImtU4SBbX1SksPCXBXF622K++rbXSHLSRGaWgbRKybKitry367btWBcXk4YQ== X-Received: by 2002:a05:6a00:17a1:b0:71e:7a56:3eaf with SMTP id d2e1a72fcca58-724df6aaff1mr4273581b3a.24.1732295458150; Fri, 22 Nov 2024 09:10:58 -0800 (PST) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-724de478f7csm1927619b3a.69.2024.11.22.09.10.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 Nov 2024 09:10:57 -0800 (PST) Date: Fri, 22 Nov 2024 09:10:55 -0800 From: Stephen Hemminger To: Jie Hai Cc: , , , , Thomas Monjalon , Allain Legacy , , , Subject: Re: [PATCH v3 1/3] ethdev: add description for KEEP CRC offload Message-ID: <20241122091055.5e87f298@hermes.local> In-Reply-To: <20240719090415.1513301-2-haijie1@huawei.com> References: <20240206011030.2007689-1-haijie1@huawei.com> <20240719090415.1513301-1-haijie1@huawei.com> <20240719090415.1513301-2-haijie1@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, 19 Jul 2024 17:04:13 +0800 Jie Hai wrote: > From: Dengdui Huang > > The data exceeds the pkt_len in mbuf is inavailable for user. unavailable > When KEEP CRC offload is enabled, CRC field length should be > included in the pkt_len in mbuf. However, almost of drivers > supported KEEP CRC feature didn't add the CRC data length to > pkt_len. So it is very necessary to add comments for this. All drivers must do the same thing, or this is a serious bug in the drivers. Just changing a comment is not going to be helpful. To fix this right: 1. Do a test with one of the original drivers in DPDK that has this feature. I would suggest ixgbe, mlx5 or bnxt. 2. Add a test to the PMD tests that validates this (if there is not one already). 3. Put the documentation in a place where it shows up in user documentation. Either in doxygen comment or in doc/guides/nics 4. Verify that all devices conform to the desired behavior I can help, but only have some old mlx5 cards to test here. Just putting comment in ethdev.h is not enough.