From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id ABD2845D7D; Fri, 22 Nov 2024 18:55:08 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 526DB402C5; Fri, 22 Nov 2024 18:55:08 +0100 (CET) Received: from mail-pf1-f169.google.com (mail-pf1-f169.google.com [209.85.210.169]) by mails.dpdk.org (Postfix) with ESMTP id D56194028C for ; Fri, 22 Nov 2024 18:55:06 +0100 (CET) Received: by mail-pf1-f169.google.com with SMTP id d2e1a72fcca58-7242f559a9fso2353942b3a.1 for ; Fri, 22 Nov 2024 09:55:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1732298106; x=1732902906; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=hnWsRmsxhLUYmtvst82yUUqXoq+C2Rka+gv1Hd74Y2s=; b=CtcjkwvY27l6a/Mv5IbF6NxSgeqHESbh6K9twhak26GmRDd7Dnbyq+Md2GEBFO7Z5w xNDd7cNHpeIp0zRgO9oyjV8Hc6E5XHcy6XPld8EQr5UxifXoONGKjzjMpANkzJl/7J/C Eez0ISbeDD1aSJX9uIetIK8YWiMfyYlLt8Lcgif9b0xeCpjdjn3q2E1hj1c5prXiPWNO /VG8h2nPSzC5t49VieJMQqRGnAYJcIP6p5v/XQF+qNGSI4xB53lGohOi2tTHSJ0TUwaQ dOIHrhzIZcefNiXsVIolpJBEM2kWdxCdn7QXLWkLXp4XS+CDx8dzCgl2LanDcU1zvqoX 7qRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1732298106; x=1732902906; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=hnWsRmsxhLUYmtvst82yUUqXoq+C2Rka+gv1Hd74Y2s=; b=bjXDOpOYHCjhA/RUu1YfQ3RZ5pDSWrw41FoV1u5l264azpbggw39o6P3EeWucZ0qbG AekRwlyChwavKFZhWzVd32TOYywv0aghHcVgBHHurfxsn66x+xYSCrUvG1LYRGzPsjeI /BnErsRSuHkLEOOLaPhSJcRSkzkq1KPDHhm9Hub3w0TNEpXex1ocistmSvaIowgC2uy0 TRkeFChXRTvdsKwUScBBR/LCDhtFiDATzrL+C+DEvxEdr4mJbdJRi1gaQXlcWJ9liPaw Vtvwk4b+rAEKC/rafDwtTJLsEMzny3YdXi3WF6+/BIYbRb6+f1HnDMXOy7I/1X7kw0th fP0w== X-Gm-Message-State: AOJu0YzlghuaGsk+pXbiu9NhHCZvCr7A0qD2LorueJ98Ft+XuLq/Zd6p +oqy53CoWzp/LD5zGcJUTTuV1izEBLpY0OjTjjX44UkT6jXMNH34iWo3R5GjsqNJTTc93JSy2tf t X-Gm-Gg: ASbGncsMaUTf9lXovCA7v7APLFu7+ChQFmyo8dXpegjdOoSP3axU6OkrrzNQKhf+XGd GhPsUN8nlLBlZybZNaee1Gkq7OzpL6+wXG6YOUIrhaMThW5Ek81QmVFSiGtBXZiHGRhuD9NkiE9 uTo2VMKT7ecCCWwV50Hd/0yDwyxlyNuSFAUGBauPE4TAmTTKaqGoIkAAaa6Ly0KAn5ivK/dKloL PoGEVNRbwjNxZNhAJUGWPW3CuhMFwBmQ/S5/U9miQGa7LzNYivDZZvki32x5km1ynfo1c5AlPJd BCrZLMd2LOoy1/Td4tCO9K2Bbn0= X-Google-Smtp-Source: AGHT+IG/XJFS3LtXBwZ8lb8HQnidacNET+KcwO/oxATBYWo1qHYEY/21FgGe2FW+q2p6tBa45zPb/w== X-Received: by 2002:a05:6a00:230c:b0:71e:7846:8463 with SMTP id d2e1a72fcca58-724df6df471mr5365168b3a.19.1732298105801; Fri, 22 Nov 2024 09:55:05 -0800 (PST) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-724de554f87sm1889860b3a.138.2024.11.22.09.55.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 Nov 2024 09:55:05 -0800 (PST) Date: Fri, 22 Nov 2024 09:55:03 -0800 From: Stephen Hemminger To: liwencheng Cc: dev@dpdk.org Subject: Re: [PATCH v2 1/3] net/macb: add new driver Message-ID: <20241122095503.05bd29fd@hermes.local> In-Reply-To: <1730796099-1235390-1-git-send-email-liwencheng@phytium.com.cn> References: <1730455640-1084345-1-git-send-email-liwencheng@phytium.com.cn> <1730796099-1235390-1-git-send-email-liwencheng@phytium.com.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, 5 Nov 2024 08:41:38 +0000 liwencheng wrote: > add Phytium NIC MACB ethdev PMD driver. >=20 > Signed-off-by: liwencheng > --- Several things need to be addressed before this driver can be merged. For better review, it is preferred that drivers be broken into smaller chunks when submitting. https://doc.dpdk.org/guides/contributing/new_driver.html 1. Missing documentation all new drivers need to have documentation in doc/guides/nics to describe hardware and features. 2. Missing license tag. These files are missing required SPDX license tags: drivers/net/macb/base/generic_phy.h drivers/net/macb/base/macb_errno.h drivers/net/macb/base/macb_hw.h 3. Missing mailmap entry 4. Missing update to MAINTAINERS 5. Build fails with lastest GCC Warnings found: [1307/3230] Compiling C object drivers/libtmp_rte_net_macb.a.p/net_macb_mac= b_ethdev.c.o In file included from ../drivers/net/macb/base/macb_common.h:36, from ../drivers/net/macb/macb_ethdev.h:10, from ../drivers/net/macb/macb_rxtx.h:8, from ../drivers/net/macb/macb_ethdev.c:11: ../drivers/net/macb/base/macb_hw.h:1063:35: warning: initializer-string for= array of =E2=80=98char=E2=80=99 is too long [-Wunterminated-string-initial= ization] 1063 | GEM_STAT_TITLE(TX1519CNT, "tx_greater_than_1518_byte_frames= "), | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ../drivers/net/macb/base/macb_hw.h:1043:24: note: in definition of macro = =E2=80=98GEM_STAT_TITLE_BITS=E2=80=99 1043 | .stat_string =3D title, \ | ^~~~~ ../drivers/net/macb/base/macb_hw.h:1063:9: note: in expansion of macro =E2= =80=98GEM_STAT_TITLE=E2=80=99 1063 | GEM_STAT_TITLE(TX1519CNT, "tx_greater_than_1518_byte_frames= "), | ^~~~~~~~~~~~~~ ../drivers/net/macb/base/macb_hw.h:1088:35: warning: initializer-string for= array of =E2=80=98char=E2=80=99 is too long [-Wunterminated-string-initial= ization] 1088 | GEM_STAT_TITLE(RX1519CNT, "rx_greater_than_1518_byte_frames= "), | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ../drivers/net/macb/base/macb_hw.h:1043:24: note: in definition of macro = =E2=80=98GEM_STAT_TITLE_BITS=E2=80=99 1043 | .stat_string =3D title, \ | ^~~~~ ../drivers/net/macb/base/macb_hw.h:1088:9: note: in expansion of macro =E2= =80=98GEM_STAT_TITLE=E2=80=99 1088 | GEM_STAT_TITLE(RX1519CNT, "rx_greater_than_1518_byte_frames= "), | ^~~~~~~~~~~~~~ [1326/3230] Compiling C object drivers/libtmp_rte_net_macb.a.p/net_macb_mac= b_rxtx.c.o In file included from ../drivers/net/macb/base/macb_common.h:36, from ../drivers/net/macb/macb_ethdev.h:10, from ../drivers/net/macb/macb_rxtx.h:8, from ../drivers/net/macb/macb_rxtx.c:24: ../drivers/net/macb/base/macb_hw.h:1063:35: warning: initializer-string for= array of =E2=80=98char=E2=80=99 is too long [-Wunterminated-string-initial= ization] 1063 | GEM_STAT_TITLE(TX1519CNT, "tx_greater_than_1518_byte_frames= "), | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ../drivers/net/macb/base/macb_hw.h:1043:24: note: in definition of macro = =E2=80=98GEM_STAT_TITLE_BITS=E2=80=99 1043 | .stat_string =3D title, \ | ^~~~~ ../drivers/net/macb/base/macb_hw.h:1063:9: note: in expansion of macro =E2= =80=98GEM_STAT_TITLE=E2=80=99 1063 | GEM_STAT_TITLE(TX1519CNT, "tx_greater_than_1518_byte_frames= "), | ^~~~~~~~~~~~~~ ../drivers/net/macb/base/macb_hw.h:1088:35: warning: initializer-string for= array of =E2=80=98char=E2=80=99 is too long [-Wunterminated-string-initial= ization] 1088 | GEM_STAT_TITLE(RX1519CNT, "rx_greater_than_1518_byte_frames= "), | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ../drivers/net/macb/base/macb_hw.h:1043:24: note: in definition of macro = =E2=80=98GEM_STAT_TITLE_BITS=E2=80=99 1043 | .stat_string =3D title, \ | ^~~~~ ../drivers/net/macb/base/macb_hw.h:1088:9: note: in expansion of macro =E2= =80=98GEM_STAT_TITLE=E2=80=99 1088 | GEM_STAT_TITLE(RX1519CNT, "rx_greater_than_1518_byte_frames= "), | ^~~~~~~~~~~~~~ [2338/3230] Compiling C object drivers/net/macb/base/libmacb_base.a.p/gener= ic_phy.c.o In file included from ../drivers/net/macb/base/macb_common.h:36, from ../drivers/net/macb/base/generic_phy.h:4, from ../drivers/net/macb/base/generic_phy.c:5: ../drivers/net/macb/base/macb_hw.h:1063:35: warning: initializer-string for= array of =E2=80=98char=E2=80=99 is too long [-Wunterminated-string-initial= ization] 1063 | GEM_STAT_TITLE(TX1519CNT, "tx_greater_than_1518_byte_frames= "), | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ../drivers/net/macb/base/macb_hw.h:1043:24: note: in definition of macro = =E2=80=98GEM_STAT_TITLE_BITS=E2=80=99 1043 | .stat_string =3D title, \ | ^~~~~ ../drivers/net/macb/base/macb_hw.h:1063:9: note: in expansion of macro =E2= =80=98GEM_STAT_TITLE=E2=80=99 1063 | GEM_STAT_TITLE(TX1519CNT, "tx_greater_than_1518_byte_frames= "), | ^~~~~~~~~~~~~~ ../drivers/net/macb/base/macb_hw.h:1088:35: warning: initializer-string for= array of =E2=80=98char=E2=80=99 is too long [-Wunterminated-string-initial= ization] 1088 | GEM_STAT_TITLE(RX1519CNT, "rx_greater_than_1518_byte_frames= "), | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ../drivers/net/macb/base/macb_hw.h:1043:24: note: in definition of macro = =E2=80=98GEM_STAT_TITLE_BITS=E2=80=99 1043 | .stat_string =3D title, \ | ^~~~~ ../drivers/net/macb/base/macb_hw.h:1088:9: note: in expansion of macro =E2= =80=98GEM_STAT_TITLE=E2=80=99 1088 | GEM_STAT_TITLE(RX1519CNT, "rx_greater_than_1518_byte_frames= "), | ^~~~~~~~~~~~~~ [2343/3230] Compiling C object drivers/net/macb/base/libmacb_base.a.p/macb_= uio.c.o In file included from ../drivers/net/macb/base/macb_common.h:36, from ../drivers/net/macb/base/macb_uio.h:4, from ../drivers/net/macb/base/macb_uio.c:6: ../drivers/net/macb/base/macb_hw.h:1063:35: warning: initializer-string for= array of =E2=80=98char=E2=80=99 is too long [-Wunterminated-string-initial= ization] 1063 | GEM_STAT_TITLE(TX1519CNT, "tx_greater_than_1518_byte_frames= "), | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ../drivers/net/macb/base/macb_hw.h:1043:24: note: in definition of macro = =E2=80=98GEM_STAT_TITLE_BITS=E2=80=99 1043 | .stat_string =3D title, \ | ^~~~~ ../drivers/net/macb/base/macb_hw.h:1063:9: note: in expansion of macro =E2= =80=98GEM_STAT_TITLE=E2=80=99 1063 | GEM_STAT_TITLE(TX1519CNT, "tx_greater_than_1518_byte_frames= "), | ^~~~~~~~~~~~~~ ../drivers/net/macb/base/macb_hw.h:1088:35: warning: initializer-string for= array of =E2=80=98char=E2=80=99 is too long [-Wunterminated-string-initial= ization] 1088 | GEM_STAT_TITLE(RX1519CNT, "rx_greater_than_1518_byte_frames= "), | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ../drivers/net/macb/base/macb_hw.h:1043:24: note: in definition of macro = =E2=80=98GEM_STAT_TITLE_BITS=E2=80=99 1043 | .stat_string =3D title, \ | ^~~~~ ../drivers/net/macb/base/macb_hw.h:1088:9: note: in expansion of macro =E2= =80=98GEM_STAT_TITLE=E2=80=99 1088 | GEM_STAT_TITLE(RX1519CNT, "rx_greater_than_1518_byte_frames= "), | ^~~~~~~~~~~~~~ [2352/3230] Compiling C object drivers/net/macb/base/libmacb_base.a.p/macb_= common.c.o In file included from ../drivers/net/macb/base/macb_common.h:36, from ../drivers/net/macb/base/macb_uio.h:4, from ../drivers/net/macb/base/macb_common.c:7: ../drivers/net/macb/base/macb_hw.h:1063:35: warning: initializer-string for= array of =E2=80=98char=E2=80=99 is too long [-Wunterminated-string-initial= ization] 1063 | GEM_STAT_TITLE(TX1519CNT, "tx_greater_than_1518_byte_frames= "), | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ../drivers/net/macb/base/macb_hw.h:1043:24: note: in definition of macro = =E2=80=98GEM_STAT_TITLE_BITS=E2=80=99 1043 | .stat_string =3D title, \ | ^~~~~ ../drivers/net/macb/base/macb_hw.h:1063:9: note: in expansion of macro =E2= =80=98GEM_STAT_TITLE=E2=80=99 1063 | GEM_STAT_TITLE(TX1519CNT, "tx_greater_than_1518_byte_frames= "), | ^~~~~~~~~~~~~~ ../drivers/net/macb/base/macb_hw.h:1088:35: warning: initializer-string for= array of =E2=80=98char=E2=80=99 is too long [-Wunterminated-string-initial= ization] 1088 | GEM_STAT_TITLE(RX1519CNT, "rx_greater_than_1518_byte_frames= "), | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ../drivers/net/macb/base/macb_hw.h:1043:24: note: in definition of macro = =E2=80=98GEM_STAT_TITLE_BITS=E2=80=99 1043 | .stat_string =3D title, \ | ^~~~~ ../drivers/net/macb/base/macb_hw.h:1088:9: note: in expansion of macro =E2= =80=98GEM_STAT_TITLE=E2=80=99 1088 | GEM_STAT_TITLE(RX1519CNT, "rx_greater_than_1518_byte_frames= "),