From: Stephen Hemminger <stephen@networkplumber.org>
To: liwencheng <liwencheng@phytium.com.cn>
Cc: dev@dpdk.org
Subject: Re: [PATCH v2 1/3] net/macb: add new driver
Date: Fri, 22 Nov 2024 12:38:18 -0800 [thread overview]
Message-ID: <20241122123818.7e1aadb1@hermes.local> (raw)
In-Reply-To: <1730796099-1235390-1-git-send-email-liwencheng@phytium.com.cn>
On Tue, 5 Nov 2024 08:41:38 +0000
liwencheng <liwencheng@phytium.com.cn> wrote:
> +struct phy_driver genphy_driver = {
> + .phy_id = 0xffffffff,
> + .phy_id_mask = 0xffffffff,
> + .name = "Generic PHY",
> + .soft_reset = genphy_soft_reset,
> + .suspend = genphy_suspend,
> + .resume = genphy_resume,
> + .check_for_link = genphy_check_for_link,
> + .read_status = genphy_read_status,
> + .force_speed_duplex = genphy_force_speed_duplex,
> +};
> +
> +struct phy_driver macb_gbe_pcs_driver = {
> + .phy_id = 0xffffffff,
> + .phy_id_mask = 0xffffffff,
> + .name = "Macb gbe pcs PHY",
> + .soft_reset = NULL,
> + .suspend = NULL,
> + .resume = NULL,
> + .check_for_link = macb_gbe_pcs_check_for_link,
> + .read_status = NULL,
> + .force_speed_duplex = NULL,
> +};
> +
> +struct phy_driver macb_usxgmii_pcs_driver = {
> + .phy_id = 0xffffffff,
> + .phy_id_mask = 0xffffffff,
> + .name = "Macb usxgmii pcs PHY",
> + .soft_reset = NULL,
> + .suspend = macb_usxgmii_pcs_suspend,
> + .resume = macb_usxgmii_pcs_resume,
> + .check_for_link = macb_usxgmii_pcs_check_for_link,
> + .read_status = NULL,
> + .force_speed_duplex = NULL,
> +};
Can these be const and static?
next prev parent reply other threads:[~2024-11-22 20:38 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-01 10:07 [PATCH v1 1/2] " liwencheng
2024-11-01 10:07 ` [PATCH v1 2/2] /usertools/dpdk-devbind:add the binding and unbinding of platform device liwencheng
2024-11-05 8:43 ` [PATCH v2 3/3] usertools/dpdk-devbind: add platform device bind/unbind liwencheng
2024-11-06 3:34 ` [PATCH v2 3/3] usertools/dpdk-devbind: add bind/unbind for platform device liwencheng
2024-11-11 7:43 ` liwencheng
2024-11-06 3:55 ` [PATCH v1 2/2] /usertools/dpdk-devbind:add the binding and unbinding of " Stephen Hemminger
2024-11-12 1:08 ` liwencheng
2024-11-01 16:13 ` [PATCH v1 1/2] net/macb: add new driver Stephen Hemminger
2024-11-01 17:42 ` Stephen Hemminger
2024-11-02 5:43 ` Stephen Hemminger
2024-11-05 8:41 ` [PATCH v2 1/3] " liwencheng
2024-11-05 8:41 ` [PATCH v2 2/3] net/macb: add NEON vectorized Rx/Tx liwencheng
2024-11-06 3:33 ` liwencheng
2024-11-11 7:42 ` liwencheng
2024-11-06 3:32 ` [PATCH v2 1/3] net/macb: add new driver liwencheng
2024-11-11 7:42 ` liwencheng
2024-11-22 17:55 ` Stephen Hemminger
2024-11-22 20:38 ` Stephen Hemminger [this message]
2024-11-22 20:44 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241122123818.7e1aadb1@hermes.local \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=liwencheng@phytium.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).