From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6FC0245D7E; Fri, 22 Nov 2024 21:38:23 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E395240291; Fri, 22 Nov 2024 21:38:22 +0100 (CET) Received: from mail-pl1-f180.google.com (mail-pl1-f180.google.com [209.85.214.180]) by mails.dpdk.org (Postfix) with ESMTP id 00B5340280 for ; Fri, 22 Nov 2024 21:38:21 +0100 (CET) Received: by mail-pl1-f180.google.com with SMTP id d9443c01a7336-20cf3e36a76so25947575ad.0 for ; Fri, 22 Nov 2024 12:38:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1732307901; x=1732912701; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=/3MmTZ3C2jLXnHNiIpNOjOK7qn7Une1ivBYJG+9SwMA=; b=wVeHc9V2x40V9dnnkTlZxPajx96Cl7nadzaGQv2amnONJ4l3hPixlMPg5gpXQ7Nmhf htD1MLbGghO8JTQqQQMrziqcmX+5wZCgmRoS6k2hJH9JEgfJgbGkI+MAPUHPgNZ3NfII VZMFy3cVZuSubJWWMEqeyb6KS+iWOBtRjiKaGvRe2x15TtZkYPUPLFvPdDBgQq2MzQ4k ailJzJeN/yWb+rI/b33LppV6EgvWj/1m/pvrCNasiyPngwPEOtIQYNnLUoft/OgNQhsl /N3M1IGDEnQbJ4iZCzu11hhJUsKNdCQQhFOnUNSpuBkm3jhp/ikpRJ5BKT7ZHFwT+4K/ DO3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1732307901; x=1732912701; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/3MmTZ3C2jLXnHNiIpNOjOK7qn7Une1ivBYJG+9SwMA=; b=EYwOMXWVI+qnedW/D/10rdY4fvFKOvqar61H0loIeGPe/ck81R5ZhN6qGm8EuLAC/W EpQOLqvStmKrkyjxZBkhxTws82hsyJwMySBhZAxFjpFCZRWL9SFYCcdNAne35YV0SpuT icMzLtllypggpY/6unOdyvmx4NevByI/82lDxL024GkTiCwcL+XnQwn23vJEa2yAV+fc TNiiBbu/pgif95XLhIxes3XLYJCDZ0VmVqBDJs8Un7cEWtkKHnZsMbJQO0VQoHO96WLd fJL70MjHUJgy7KiGxjTFVuE9Hb5z28siYoR26VKcZQE6leLZPLCytrlUKNWT2/2Isgaf hKFQ== X-Gm-Message-State: AOJu0Yy6xIdK648WOn+SFyLGl/ROhl8fgiXbGizNX+n4MCJXzfHrZ93T r7AZRpCRjuW5I5DAsazZNV5ZnZ0rtkE1H7po56iPKiOWfj4OsED7CzvU2brTa16r9NsLDDp7qef A X-Gm-Gg: ASbGncuw88IrR90r/Mo+49+Mu55ztA471wElvysixvelwrQtTDqJ8+/sAXipp3p0yjM 7aFWZxLW5iPjjRG5ZeEA1FaOd1nXTfIsSpv9bJ0QuvwVriez3lnbLTCyUHVrPJUTbHHhfFhTks5 cKU2k1WHLom1MNELCl8UGA8xkWU6LzMjUyexJTJeZ2pM6+tPxEsen/llryH8px2fqRPn0nzhbK5 D5nvnEhb0PUDwcWn94wkOUOpCwKq4kZmBiYZeGqA2lXC2ze6yyXMTHfncmpw3TMsmmOOuRvUVgq vgzvvLiQET2mrzNfOfbqE9YVfdg= X-Google-Smtp-Source: AGHT+IGe8DHCwU2HnDNFIdbbXvH+OyAHpD4LKb/Uh8devPlKZ8MRguiZVYPNi2cIaciHNo1nCO3bzw== X-Received: by 2002:a17:902:ec91:b0:206:9a3f:15e5 with SMTP id d9443c01a7336-2129f6ffbc6mr58683085ad.32.1732307900899; Fri, 22 Nov 2024 12:38:20 -0800 (PST) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2129dba2691sm20638695ad.68.2024.11.22.12.38.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 Nov 2024 12:38:20 -0800 (PST) Date: Fri, 22 Nov 2024 12:38:18 -0800 From: Stephen Hemminger To: liwencheng Cc: dev@dpdk.org Subject: Re: [PATCH v2 1/3] net/macb: add new driver Message-ID: <20241122123818.7e1aadb1@hermes.local> In-Reply-To: <1730796099-1235390-1-git-send-email-liwencheng@phytium.com.cn> References: <1730455640-1084345-1-git-send-email-liwencheng@phytium.com.cn> <1730796099-1235390-1-git-send-email-liwencheng@phytium.com.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, 5 Nov 2024 08:41:38 +0000 liwencheng wrote: > +struct phy_driver genphy_driver = { > + .phy_id = 0xffffffff, > + .phy_id_mask = 0xffffffff, > + .name = "Generic PHY", > + .soft_reset = genphy_soft_reset, > + .suspend = genphy_suspend, > + .resume = genphy_resume, > + .check_for_link = genphy_check_for_link, > + .read_status = genphy_read_status, > + .force_speed_duplex = genphy_force_speed_duplex, > +}; > + > +struct phy_driver macb_gbe_pcs_driver = { > + .phy_id = 0xffffffff, > + .phy_id_mask = 0xffffffff, > + .name = "Macb gbe pcs PHY", > + .soft_reset = NULL, > + .suspend = NULL, > + .resume = NULL, > + .check_for_link = macb_gbe_pcs_check_for_link, > + .read_status = NULL, > + .force_speed_duplex = NULL, > +}; > + > +struct phy_driver macb_usxgmii_pcs_driver = { > + .phy_id = 0xffffffff, > + .phy_id_mask = 0xffffffff, > + .name = "Macb usxgmii pcs PHY", > + .soft_reset = NULL, > + .suspend = macb_usxgmii_pcs_suspend, > + .resume = macb_usxgmii_pcs_resume, > + .check_for_link = macb_usxgmii_pcs_check_for_link, > + .read_status = NULL, > + .force_speed_duplex = NULL, > +}; Can these be const and static?